From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tiger.tulip.relay.mailchannels.net (tiger.tulip.relay.mailchannels.net [23.83.218.248]) by sourceware.org (Postfix) with ESMTPS id 4E0283858C53 for ; Wed, 4 May 2022 15:22:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E0283858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nadler.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nadler.com X-Sender-Id: dreamhost|x-authsender|drn@nadler.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 438326C0E83 for ; Wed, 4 May 2022 15:22:26 +0000 (UTC) Received: from pdx1-sub0-mail-a248.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A9BCC6C0849 for ; Wed, 4 May 2022 15:22:25 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1651677745; a=rsa-sha256; cv=none; b=i6xSu18wUs4URs2318MCM36AcztBdtJ0K80BktddyjychUIxf/OnKITUrMtIfhmpnd+bEd JnuQqYhyprxBA48Fnx6cqOFI7LXSRGzbPhrm+BoOQHkrmBXFBmGyEhNeVp3cmdRajQf8lr vu3EtFrOYeZRyXtJ1T5hdQW6GhXzgx94/qY6iMBzULtSF9UUdWhZu5e4UOs1NTK6hXp+9w agDmyzeYb4BMGXEVjuofUPIdnjxcgdpggYbRKP65ddG1NVeDR29ZqHEdnQMGSOjL0C4VFe nXHUU0O0bQdbNRL+RjFhvncVq1Cu167ynqBYLhLfLvxEPqHsiSmEyT1DRwwjhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1651677745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AOl5KToZbXZtzVpOwy+1jusHCxIb9DiwfTrC3h2qU5c=; b=BMn1M0hp1CX4f3TTvGdDUeYXI67dbdAquJ6/puDR/OKbaTjOS9NRP+3NIHMf0Q0Z2Htapj Qb1T5c4Kr3kjP2eGN1I86f8bIxhKwFZyUzfpaUAMPv3rXaY4YuIN3csCNiDzD+lyGTCC8q 07noVUfLKfJH+kOUP7rcT4VqQieFOplu2eyDvbz6UULL5kXwTkceOQvkW1vATmc44jxYhq k/loIgrqdeMp/FgpIlaoQ0bH8GV/ptPyQagFhBtR3PJ+Y9/tvS71RJ+QF8pPOKpfOryJxR pyxig/KG6E+tB/rX5KaEMod8A9B7RZmoMOBHSF1ZNUE1wbkgK9ZWnfSgGNtLyA== ARC-Authentication-Results: i=1; rspamd-847dd8955c-8zvzc; auth=pass smtp.auth=dreamhost smtp.mailfrom=drn@nadler.com X-Sender-Id: dreamhost|x-authsender|drn@nadler.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|drn@nadler.com X-MailChannels-Auth-Id: dreamhost X-Keen-Tart: 306aad5f648dd994_1651677745983_117786447 X-MC-Loop-Signature: 1651677745983:3122454547 X-MC-Ingress-Time: 1651677745983 Received: from pdx1-sub0-mail-a248.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.95.68 (trex/6.7.1); Wed, 04 May 2022 15:22:25 +0000 Received: from [192.168.1.3] (pool-72-74-171-157.bstnma.fios.verizon.net [72.74.171.157]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: drn@nadler.com) by pdx1-sub0-mail-a248.dreamhost.com (Postfix) with ESMTPSA id 4KtgYY2JZsz1TH for ; Wed, 4 May 2022 08:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nadler.com; s=dreamhost; t=1651677745; bh=AOl5KToZbXZtzVpOwy+1jusHCxIb9DiwfTrC3h2qU5c=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=lvrbwoLpTqqUo17Bnve1y/p/AXB/BQheNLdj05Eze0Q5rN6MDWH7AVnN5l6kiGaRo GmBXMKwjtOIPeNLIIKKoBIkzYCpNgiTG/QtQPK0/gEYXpqWxcn1DTFYoSPIHBy2xOd EjnbEsbc7XPEmvxJI/TqZOFqHCwhdGHk9E3kEcmtO4jq0F+gOPbAQVMM4N6PG5aBna L0UC/QtKRi1e16gGR0oqN7ueXNyVu/CILtQ1XQMlpJjswyC5Bo8UMzdj3W1d/sE1qj If12giIGajvNTPp+IpSiofSidYQ3PNwu3XhnT4E8yMlsh9nTdA13Dtt/NJXm9StKqd n19pzR4DMvexA== Message-ID: <2e8518f4-f26a-b360-cef4-0d5361c3f2fb@nadler.com> Date: Wed, 4 May 2022 11:22:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Remove use of _global_impure_ptr Content-Language: en-US To: newlib@sourceware.org References: <20220503134043.122345-1-sebastian.huber@embedded-brains.de> From: Dave Nadler In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 15:22:32 -0000 On 5/4/2022 9:34 AM, Corinna Vinschen wrote: > Hi Sebastian, > > On May 3 15:40, Sebastian Huber wrote: >> Remove the pointer indrection through the read-only _global_impure_ptr and >> directly use a globally visible _impure_data object of type struct reent. This >> enables the static initialization of global data structures in a follow up >> patch. In addition, we get rid of a machine-specific file. > the patch looks good. I just wonder if we really need the > impure-compat.c file. Backward-compat is no problem for embedded stuff, > and Cygwin doesn't expose _global_impure_ptr to user space either. > > If there's no other compelling reason, you can just drop it and push > the rest. > > Thanks, > Corinna Apologies if this is a dumb question, but this patch does not affect the use of the global _impure_ptr, right? For example FreeRTOS allocates a reentrancy structure for each task and switches _impure_ptr on context switches. Thanks! Best Regards, Dave -- Dave Nadler, USA East Coast voice (978) 263-0097, drn@nadler.com, Skype Dave.Nadler1