From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73884 invoked by alias); 14 Jun 2017 16:07:21 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 73523 invoked by uid 89); 14 Jun 2017 16:07:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=johnston, Johnston, H*r:0500, perceived X-HELO: OARmail.OARCORP.com Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 16:07:16 +0000 Received: from [192.168.0.66] (207.98.215.166) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.3.389.2; Wed, 14 Jun 2017 11:07:12 -0500 Subject: Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval. To: Jeff Johnston , Newlib References: <1497389420-19708-1-git-send-email-joel@rtems.org> <20170614085049.GR13513@calimero.vinschen.de> From: Joel Sherrill Message-ID: <35bd4a26-95e3-9640-9383-773282cdfdee@oarcorp.com> Date: Wed, 14 Jun 2017 16:07:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017/txt/msg00425.txt.bz2 On 6/14/2017 10:49 AM, Jeff Johnston wrote: > It would have been nicer to ask first, but that said, I am ok with a > clarification added to the definition. > > For an OS maintainer, changes that add OS-specific changes to existing > shared files need approval. That means you may > make changes to an existing RTEMS section of a header file, but you cannot > add an RTEMS section to a > header or source file that did not have such a section without approval. I > don't want to have RTEMS stuff added all over the > place to save you having to have your own version in your directory. It wasn't a power grab and I am sorry if it was perceived as such. I didn't intend it to change anything in how anyone in the RTEMS community approached newlib. We have been users for since before 1995 and have always submitted patches for review before merging. I am pretty sure I have had the equivalent of write after approval for 20 years. I viewed updating that as contact information and a reflection of existing practice. I post patches and wait for approval (even for RTEMS specific parts) before committing. I agree 100% that caution should be exercised when touching common files. At the same time, sharing common source/header files has value so it is worth posting patches and going back and forth. Again I apologize that more was read into that patch than was intended. --joel > > -- Jeff J. > > On Wed, Jun 14, 2017 at 4:50 AM, Corinna Vinschen wrote: >> On Jun 13 16:30, Joel Sherrill wrote: >>> --- >>> newlib/MAINTAINERS | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS >>> index 6117ff4..0bd93ff 100644 >>> --- a/newlib/MAINTAINERS >>> +++ b/newlib/MAINTAINERS >>> @@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com >>> msp430 DJ Delorie dj@redhat.com >>> Nick Clifton nickc@redhat.com >>> >>> + OS Port Maintainers (OS alphabetical order) >>> + >>> +OS port maintainers may make changes in OS-specific directories, as >>> +well as OS-specific portions of the build system, without approval. >>> + >>> +RTEMS Joel Sherrill joel.sherrill@oarcorp.com >>> >>> Write After Approval >>> >>> @@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com >>> Eric Blake eblake@redhat.com >>> Will Newton will.newton@linaro.org >>> Sebastian Huber sebastian.huber@embedded-brains.de >>> +Joel Sherrill joel.sherrill@oarcorp.com >>> -- >>> 1.8.3.1 >> >> On hold. I'm still discussing this with Jeff. >> >> >> Corinna >> >> -- >> Corinna Vinschen >> Cygwin Maintainer >> Red Hat