From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <newlib-return-14888-listarch-newlib=sources.redhat.com@sourceware.org>
Received: (qmail 103238 invoked by alias); 26 Jul 2017 14:59:58 -0000
Mailing-List: contact newlib-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <newlib.sourceware.org>
List-Subscribe: <mailto:newlib-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: newlib-owner@sourceware.org
Received: (qmail 103025 invoked by uid 89); 26 Jul 2017 14:59:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-HELO: OARmail.OARCORP.com
Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 14:59:55 +0000
Received: from [192.168.1.122] (192.168.1.122) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.3.389.2; Wed, 26 Jul 2017 09:59:41 -0500
To: "newlib@sourceware.org" <newlib@sourceware.org>, aditya upadhyay <aadit0402@gmail.com>
From: Joel Sherrill <joel.sherrill@oarcorp.com>
Subject: Procedure for Patches Merging FreeBSD Code
Message-ID: <368ae6d7-6985-4900-a7fa-db41216cd644@oarcorp.com>
Date: Wed, 26 Jul 2017 14:59:00 -0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017/txt/msg00650.txt.bz2

Hi

Gedare, Aditya, and I were discussing that it is useful
during development to have a git branch with a patch
series that adds the unmodified FreeBSD files followed
by a patch series that adds them to the build system
and makes them work. Then you can easily review the
differences against the original source.

Would it be desirable for patches submitted to newlib
to follow this pattern? Or should Aditya submit a
single patch series including the addition and
any modifications?

For sure, the addition change can only add the source
files and not touch the build system. Otherwise
git bisect will break. That can't be allowed if
avoidable.

Thanks.

--joel