From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86748 invoked by alias); 29 Jun 2017 13:47:06 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 86262 invoked by uid 89); 29 Jun 2017 13:47:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*r:ip*192.168.2.2, H*r:0500 X-HELO: OARmail.OARCORP.com Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jun 2017 13:47:04 +0000 Received: from [192.168.1.168] (192.168.1.168) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.3.389.2; Thu, 29 Jun 2017 08:47:02 -0500 Subject: Re: Long double complex methods To: newlib@sourceware.org, aditya upadhyay References: <20170629063911.GB31936@calimero.vinschen.de> From: Joel Sherrill Message-ID: <372bbc8f-afbc-2c26-2586-1f7bdf76fb33@oarcorp.com> Date: Thu, 29 Jun 2017 13:47:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170629063911.GB31936@calimero.vinschen.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017/txt/msg00522.txt.bz2 On 6/29/2017 1:39 AM, Corinna Vinschen wrote: > Hi Aditya, > > On Jun 29 02:04, Aditya Upadhyay wrote: >> Hello Developers, >> >> I have ported all long double complex methods with suffix "l" from >> NetBSD. I am attaching the patches for all the methods. I am >> requesting you to please review these patches and point me any >> modification needed. >> >> Thanks & Regards, > [...] > > Looks good, just the last patch in the series: > >> Subject: [PATCH 18/18] Importing csinl.c from NetBSD. > > is missing the Makefile.am change. Care to resend a v2 of patch 18? Aditya may not need this but it won't hurt to post a hint. git format-patch has some interesting options. The "-v N" option adds a version number to the subject so it is clear on mailing lists which patches are v1 and which are subsequent versions. Something like this: git format-patch -o DIRECTORY -v N MY_BRANCH master I always dump the patches into a subdirectory since the names are so long they tend to clutter up a normal source directory. Also it makes it easier to use git send-email to send a patch set to a mailing list. > Thanks, > Corinna > --joel