From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-046.btinternet.com (mailomta17-re.btinternet.com [213.120.69.110]) by sourceware.org (Postfix) with ESMTPS id C95AA3858D1E for ; Mon, 20 Feb 2023 22:03:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C95AA3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.54.8]) by re-prd-fep-046.btinternet.com with ESMTP id <20230220220300.GRRK7994.re-prd-fep-046.btinternet.com@re-prd-rgout-005.btmx-prd.synchronoss.net>; Mon, 20 Feb 2023 22:03:00 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A91244F4BDC0C X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrudejhedgudehtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepvddtteffkeevveejgeehgeelhfdtgefgieelgffgudetudefvdeggfeiiefftdevnecukfhppeekuddrudehfedrleekrddvgeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddvgeeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopeeurhhirghnrdfknhhglhhishesufhhrgifrdgtrgdprhgtphhtthhopehnvgiflhhisgesshhouhhrtggvfigrrhgvrdhorhhg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.246) by re-prd-rgout-005.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A91244F4BDC0C; Mon, 20 Feb 2023 22:03:00 +0000 Message-ID: <381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk> Date: Mon, 20 Feb 2023 22:03:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues Content-Language: en-GB To: Brian Inglis , "newlib@sourceware.org" References: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1189.7 required=5.0 tests=BAYES_00,BODY_8BITS,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/02/2023 20:25, Brian Inglis wrote: > On 2023-02-20 02:45, Corinna Vinschen wrote: >> Hi Brian, >> >> On Feb 17 13:49, Brian Inglis wrote: >>> Brian Inglis (2): >>>    newlib/libc/time/strftime.c: split table of conversion >>>      specifiers to fix man, tbl, groff multi-page table issues >>>    newlib/libc/Makefile.inc: sed fix strftime.3 table format >>>      man, tbl, groff multi-page issues >>> >>>   newlib/libc/time/strftime.c | 3 ++- >>>   newlib/libc/Makefile.inc    | 1 + >>>   2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> -- >>> 2.39.0 >> >> Would you mind terribly to add more text to the commit messages? >> explaining the problem, and its fix?  Just the subject line is quite >> terse. >> >> For patch 1, why adding the split and what's the desired effect.  For >> patch 2, what problem is the sed call fixing and what is the sed >> expression doing? > > Thanks Corinna, You're right - will redo all v3. You should also describe why this must be fixed in this ad-hoc fasion, rather than in the chew markup or makedocbook.