From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 27DC83858C83 for ; Wed, 9 Mar 2022 09:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27DC83858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy05.your-server.de ([78.46.172.2]) by dedi548.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1nRsDl-0003j6-WA for newlib@sourceware.org; Wed, 09 Mar 2022 10:03:02 +0100 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRsDl-000SOG-Td for newlib@sourceware.org; Wed, 09 Mar 2022 10:03:01 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 90A6C4800A7 for ; Wed, 9 Mar 2022 10:03:01 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fws7E5sHYu1B for ; Wed, 9 Mar 2022 10:03:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 35FFA4800CB for ; Wed, 9 Mar 2022 10:03:01 +0100 (CET) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mfxzbCAY25Ei for ; Wed, 9 Mar 2022 10:03:01 +0100 (CET) Received: from [10.10.171.10] (unknown [10.10.171.10]) by mail.embedded-brains.de (Postfix) with ESMTPSA id EF2BE4800A7 for ; Wed, 9 Mar 2022 10:03:00 +0100 (CET) Message-ID: <395c086f-f51b-d4c1-5b4a-4df0e8cad273@embedded-brains.de> Date: Wed, 9 Mar 2022 10:02:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] build: Avoid length() GNU awk extension Content-Language: en-US To: newlib@sourceware.org References: <20220309073105.129187-1-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26475/Tue Mar 8 10:31:43 2022) X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 09:03:04 -0000 On 09/03/2022 09:54, Mike Frysinger wrote: > On 09 Mar 2022 08:31, Sebastian Huber wrote: >> Other awk implementations such as mawk do not support the length() fun= ction. > those awk implementations are not POSIX compliant. length() is > *not* a GNU extension. you can see it clearly defined in POSIX: > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/awk.html#tag= _20_06_13_13 Ok, it is defined by POSIX, I will adjust the commit message. >=20 > that said, mawk does support length(), and has since at least 2008 in > the 1.3.3 release. i stopped looking back further in the history. >=20 > so you're going to have to provide a bit more info as to what you're > trying to do here, and what tools & versions exactly you're using. I received an error report from someone else which regularly builds=20 Newlib and this use of awk broke the build. I don't know the exact=20 version of mawk which was used. Independent of the POSIX compliance of the existing code I think the=20 change to use the return value of split() doesn't hurt? --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/