From: Craig Howland <howland@LGSInnovations.com>
To: <newlib@sourceware.org>
Subject: Re: [PATCH 1/2] Import strnstr.c from FreeBSD.
Date: Tue, 29 Aug 2017 14:56:00 -0000 [thread overview]
Message-ID: <3fe50885-7f1f-c095-125e-ad528d88f848@LGSInnovations.com> (raw)
In-Reply-To: <20170824084838.GB29964@calimero.vinschen.de>
In addition to a header patch being missing, the documentation/man page is also
missing. (It might make sense to add it to strstr.c, since strnstr() is just a
length-limited version of strstr(). If it does end up there, delete that
TRAD_SYNOPSIS section as long as it is being edited, as they have been unused
for years.)
Craig
On 08/24/2017 04:48 AM, Corinna Vinschen wrote:
> Hi Sichen,
>
> On Aug 24 10:14, Sichen Zhao wrote:
>> ---
>> newlib/libc/string/strnstr.c | 65 +++++++++++++++++++++++++++++++++++++++++++
> Isn't there a header patch missing?
>
>
> Thanks,
> Corinna
>
next prev parent reply other threads:[~2017-08-28 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 5:47 Sichen Zhao
2017-08-24 2:14 ` [PATCH 2/2] Port strnstr.c to newlib Sichen Zhao
2017-08-24 8:50 ` [PATCH 1/2] Import strnstr.c from FreeBSD Corinna Vinschen
2017-08-24 14:34 ` Sichen Zhao
2017-08-29 14:56 ` Craig Howland [this message]
2017-08-25 18:12 ` Eric Blake
2017-08-25 19:18 ` Eric Blake
2017-08-26 12:31 ` Sichen Zhao
2017-08-26 13:03 ` Gedare Bloom
2017-08-26 13:28 ` Sichen Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe50885-7f1f-c095-125e-ad528d88f848@LGSInnovations.com \
--to=howland@lgsinnovations.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).