From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 270613858C74 for ; Fri, 19 Jan 2024 16:23:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 270613858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=livius.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=livius.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 270613858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705681400; cv=none; b=ryWpSHmAdMeaKkOY5beUpPEFnlgqMXnHkpDx+9TU8anQ0YTWXRZAbrqbyvTPU0JRFPwr01D3fRqMktfy3YGqbWfv2hLISMQjlAoVAwjmBXxq1l4/nUaQOEBRlQgAD6Xb1+LDreeH+BcO89HMTZQu8/k68dNtj9NbrUbm9HojECU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705681400; c=relaxed/simple; bh=tUUcI6Xjh6pTaLpqljgsqHUVEokc9C7lUz3mPz0OwMo=; h=DKIM-Signature:From:Mime-Version:Subject:Date:To:Message-Id; b=bUUcE9hWJk9yANxHHj9GIIHwixdB13lpGh0b+J9mJYDA1Sn/tnDs7PQ288YN0m+MI4OkzK/WqAQXYWsSCKNp0ONOSlUNBJvklbA8v/+HzjYJCLq8uOlOXoVfUqDNKKn+9ZYFQkdpf7F7yA7S53mTXHa0u+aySPQRFJePFIiRN08= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a2cad931c50so107190966b.1 for ; Fri, 19 Jan 2024 08:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=livius-net.20230601.gappssmtp.com; s=20230601; t=1705681396; x=1706286196; darn=sourceware.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=tUUcI6Xjh6pTaLpqljgsqHUVEokc9C7lUz3mPz0OwMo=; b=LdjMNBVacv94HtxVNapfWUzOpZq1bL3+FSc9P28TGa51fqiADqIYZHnvpyJkWSruXi 8UyzG73zpEuenHlEgVSMbaMSco9pFwLEd5VgspMsnHTonO4gU+zdR2Kyle9rlC8BmY53 hs3Gl3prb8xhRRSM1kspV7TZqFeL+4hyuQewkUfpNA5Q6pFKamg0lEDNnh6ol3u4EuEQ uL8xIiF87b8Sf9My/If2sfGDrVWsj8J5r7mWuAf4TRL4J98IIcETtZhUKjtxQbyd0Sqg a5tMM5l68YmGudCkvGmkemwj8Ki+My+LwqSAkO1rRge7KkH7ElW5cBTgeqSKtpTQPoc2 kduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705681396; x=1706286196; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tUUcI6Xjh6pTaLpqljgsqHUVEokc9C7lUz3mPz0OwMo=; b=PAzcCnlcMKuO8kWJnrlZGz6LSACMH9YzCdcucH3XungPcZ54ht1RMQ6ah5LOXXPET6 iqTmJaNHvBvefB8XkITtf4O3OA6kMZKInr9hwORyjZwCX3mUapKR6q6W9l01xIL8W5j2 90kVhJnj/JDpVWCgBvdjiqtWwS3Ob4d/HRSjqWyam/44yOSf0chaM4JrRbUO6Xi43/1Z dkR4wE60f0JBw61Jm4CCJdewIjRGfcMH4zauu+Yn7mTY+e5e1EGXmVDrvscciEB+wdLS d9PMkdok7xzULhMKwv9B7zjoTUFfcHtm5KhC6eJZvmdm9Z/ka9DmpYbrfAuBrgvq6sNf 4bbw== X-Gm-Message-State: AOJu0YyYfp4WVid1OBNpzpXLCtjsTpjIpR4FcwSyAXyDsIWAbHwlMKH0 ZZBMYdL0rf1YqFeiLw5WA3gVvgAD21D3PPTIDpPiw7i4KZyng109RhJ2l0lY/Tkvvuuyu7P5HCW X X-Google-Smtp-Source: AGHT+IEVCiYfQWBQmRdVuv/FvExDlqzMiURYMxJkpyf6KQI8jx0HT7Q4BEDwpi4xQyNDcPoBeWg3JA== X-Received: by 2002:a17:907:54d:b0:a2d:5394:18fb with SMTP id wk13-20020a170907054d00b00a2d539418fbmr16167ejb.109.1705681396396; Fri, 19 Jan 2024 08:23:16 -0800 (PST) Received: from smtpclient.apple ([86.121.22.146]) by smtp.gmail.com with ESMTPSA id fj6-20020a1709069c8600b00a2ddacf4e2esm6291986ejc.177.2024.01.19.08.23.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2024 08:23:15 -0800 (PST) From: Liviu Ionescu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: -Wall Date: Fri, 19 Jan 2024 18:23:04 +0200 References: To: newlib@sourceware.org In-Reply-To: Message-Id: <42301155-A500-4FEC-B075-83C7D28500ED@livius.net> X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 19 Jan 2024, at 14:55, Corinna Vinschen = wrote: >=20 > ... I'd like to suggest to add -Wall by default to the > build flags for newlib, just as it is already for ages in the Cygwin > tree. >=20 > Anybody having a strong opinion, pro or contra? For my own code I run all tests with `-Werror -Wall` and as many extra = `-fxxx` options I can (trying to emulate the LLVM/clang `-feverything`). = This usually requires a combination of code edits and pragmas to silence = some warnings, which may be tedious, but it gives me some peace of mind = when my code is integrated in various build environments. However, when I make binary distributions using someone else code (*), I = find compiler warnings less useful (read annoying), since there is not = much I can do to fix them. For the newlib configure, if not already available, I suggest you = implement `--enable-warnings`/`--disable-warnings` and = `--enable-werror`/`--disable-werror`. The default are usually disabled, but are not that relevant; for my = builds I generally use explicit `--disable-warnings --disable-werror` = when available. But for your CI tests, sure, enable `-Wall` and try to fix the code to = clear all warnings, using the latest toolchains. Regards, Liviu (*) I maintain the xPack binary cross-platform distributions of = arm-none-eabi-gcc and riscv-none-elf-gcc, which also include newlib.