From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-047.btinternet.com (mailomta4-re.btinternet.com [213.120.69.97]) by sourceware.org (Postfix) with ESMTPS id 9A5943858D1E for ; Wed, 9 Feb 2022 19:42:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A5943858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-047.btinternet.com with ESMTP id <20220209194236.FJXL23513.re-prd-fep-047.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Wed, 9 Feb 2022 19:42:36 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A8DE813ED3569 X-Originating-IP: [86.144.41.66] X-OWM-Source-IP: 86.144.41.66 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgdduvdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepgfeludfggefhteetueelieeltddufeevieduiefgudelueektdeutefftedvheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepkeeirddugeegrdeguddrieeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdefngdpihhnvghtpeekiedrudeggedrgedurdeiiedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepnhgvfihlihgssehsohhurhgtvgifrghrvgdrohhrghdprhgtphhtthhopehvrghpihgvrhesghgvnhhtohhordhorhhg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.103] (86.144.41.66) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE813ED3569; Wed, 9 Feb 2022 19:42:36 +0000 Message-ID: <48be44ec-5051-3f60-279b-ae53500559e5@dronecode.org.uk> Date: Wed, 9 Feb 2022 19:42:03 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 1/7] newlib: move AC_NO_EXECUTABLES logic up to common code Content-Language: en-GB To: Mike Frysinger , "newlib@sourceware.org" References: <20220205073436.6577-1-vapier@gentoo.org> <20220205073436.6577-2-vapier@gentoo.org> From: Jon Turney In-Reply-To: <20220205073436.6577-2-vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1200.3 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 19:42:40 -0000 On 05/02/2022 07:34, Mike Frysinger wrote: > This logic was added to libc & libm to get it working again after some > reworks in the CPP handling, but now that that's settled, let's move > this to the common newlib configure logic. This will make it easier > to consolidate all the configure calls into the top-level newlib dir. > > This does create a lot of noise in the generate scripts, but that's > because of the ordering of the calls, not because of correctness. We > will try to draw that back down in follow up commits as we modernize > the toolchain calls in here. Somehow, this change seems to prevent a self-hosted cygwin build from working. See e.g. https://github.com/cygwin/cygwin/runs/5118411294 Comparing this with the previous successful run, it looks like: Because doc/makedoc appears in noinst_DATA, which the target all depends on, it tries to make the target doc/makedoc (without EXEEXT_FOR_BUILD appended), which uses a one step built-in(?) compiler rule, and fails as the directory $builddir/doc/ doesn't exist yet. Note that 'make info' still works, as this properly depends on $(MKDOC). So maybe something like this is needed? But I have no idea what this change did to stop it working as before... > diff --git a/newlib/doc/local.mk b/newlib/doc/local.mk > index 15c43f225..de1dd1f2b 100644 > --- a/newlib/doc/local.mk > +++ b/newlib/doc/local.mk > @@ -1,8 +1,8 @@ > -# We can't use noinst_PROGRAMS, because automake will add $(EXEEXT). > -noinst_DATA += doc/makedoc > - > MKDOC = doc/makedoc$(EXEEXT_FOR_BUILD) > > +# We can't use noinst_PROGRAMS, because automake will add $(EXEEXT). > +noinst_DATA += $(MKDOC) > + > # We don't use CFLAGS with CC_FOR_BUILD because here CFLAGS will > # actually be CFLAGS_FOR_TARGET, and in some cases that will include > # -Os, which CC_FOR_BUILD may not recognize.