Re: [PATCH] Refactor mktime and add the POSIX function timegm

["R. Diez" <rdiezmail-newlib@yahoo.de>]

> [...]
> Don't see where *non-inline* static functions and trivial renames are improvements over macros.
 > [...]

Like I said, I did not write the code, I only manually reconstructed the last patch version from Andrew Russell.

I was under the impression that the patch had already been reviewed, at least up to a point. It was by no means the first patch version posted.

But, if there is some sort of consensus here, I could rework the patch.


 > It may have been better to compare against the upstream BSD (or tzcode) sources
 > [...]

That means extra work. Do you have any reason to suspect that the existing code is wrong in some way? Or do you know whether the code in Newlib is 
actually supposed to track some BSD or tzcode source? There is no source code comment to that respect, and the code in other libraries will probably 
have diverged by now.

Unless you volunteer and/or specify concrete reasons, I would assume that the existing implementation in Newlib is fine, so a small refactor in order 
to provide timegm() is probably the best solution. Such a patch is also easier to review than bringing in new or further modified code from an 
external source.

Regards,
   rdiez