From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123259 invoked by alias); 28 Jul 2017 18:24:59 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 121761 invoked by uid 89); 28 Jul 2017 18:23:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=OnLine, On-Line, H*r:0500, huntsville X-HELO: OARmail.OARCORP.com Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jul 2017 18:23:47 +0000 Received: from [192.168.1.124] (192.168.1.124) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.3.389.2; Fri, 28 Jul 2017 13:23:33 -0500 Subject: Re: Importing inttypes methods To: Aditya Upadhyay , "newlib@sourceware.org" References: <20170726110849.GG14419@calimero.vinschen.de> <20170727123207.GB27695@calimero.vinschen.de> <20170728104304.GA24013@calimero.vinschen.de> From: Joel Sherrill Message-ID: <4ac71d2e-e1aa-d819-6ce6-0a8526e5b719@oarcorp.com> Date: Fri, 28 Jul 2017 18:24:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017/txt/msg00691.txt.bz2 On 7/28/2017 6:02 AM, Aditya Upadhyay wrote: > Just give a little time. I am creating a new patch set that fix the > BSD_VISIBLE problem. And just to be clear the standards based guards go in the .h file. Not in the C body. For example, any BSD specific methods have their prototype wrapped in __BSD_VISIBLE. See strings.h for an example. --joel > > Thanks, > Aditya > > > On Fri, Jul 28, 2017 at 4:13 PM, Corinna Vinschen wrote: >> On Jul 27 19:30, Aditya Upadhyay wrote: >>> Hi, >>> >>> I apologize for the inconvenience caused. Actually i am new to git and >>> still learning commands. I am trying my best and want to assure you >>> that i will be familiar with the git soon. I will try not to repeat >>> the same mistakes again in future. >>> I am attaching the fresh new patches for last 4 methods with all >>> possible changes. I am requesting you to please review the patches. >> >> Patches are fine and what we talked about, but I realized belatedly >> that we have a problem with the inttypes.h header file: >> >> Your patch includes xlocale.h only if __POSIX_VISIBLE >= 200809. >> However, you declare the _l functions unconditionally. This will >> break builds which don't define _POSIX_SOURCE to the right value. >> >> Additionally, these functions are BSD-only at the moment. They are >> neither in glibc nor in POSIX. >> >> So, what we should do here is this: >> >> * Include xlocale.h only if __BSD_VISIBLE. >> * Declare the _l functions only if __BSD_VISIBLE, too. >> >> It's your choice now: Do you want to recreate the below patches >> accordingly, or shall I aplly the patches as they are, and you create >> a followup patch just fixing inttypes.h? >> >> >> Thanks, >> Corinna >> >> -- >> Corinna Vinschen >> Cygwin Maintainer >> Red Hat -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35806 Support Available (256) 722-9985