From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Srinath Parvathaneni <srinath.parvathaneni@arm.com>,
newlib@sourceware.org
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][Newlib] arm: Fix the SP used in setting stack limit for standalone application.
Date: Fri, 3 Mar 2023 13:34:41 +0000 [thread overview]
Message-ID: <4b34f3e3-df83-b4b5-50a0-993483671df5@foss.arm.com> (raw)
In-Reply-To: <41d4f38f-d108-7913-97a2-c60acd11e421@arm.com>
I've tweaked the commit message and pushed (we don't use ChangeLog files
in newlib).
R.
On 03/03/2023 12:45, Srinath Parvathaneni wrote:
> Hi,
>
> When the processor by default starts in USER mode, in __stack_init
> function of crt0.s the stack limit register is not getting set
> correctly for standalone application. This is because the register r3
> used to set this stack limit register is not updated with correct stack
> pointer value. This patch fixes this issue and updates r3 with correct
> stack pointer value.
>
> Regression tested on arm-none-eabi target for newlib and newlib-nano and
> found
> no regressions.
>
> Ok for newlib master?
>
> Regards,
> Srinath.
>
> libgloss/ChangeLog:
>
> 2023-03-03 Srinath Parvathaneni<srinath.parvathaneni@arm.com>
>
> * arm/crt0.S (__stack_init): Update r3 value before mode checking.
>
> newlib/ChangeLog:
>
> 2023-03-03 Srinath Parvathaneni<srinath.parvathaneni@arm.com>
>
> * libc/sys/arm/crt0.S (__stack_init): Update r3 value before mode
> checking.
prev parent reply other threads:[~2023-03-03 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 12:45 Srinath Parvathaneni
2023-03-03 13:34 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b34f3e3-df83-b4b5-50a0-993483671df5@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=newlib@sourceware.org \
--cc=srinath.parvathaneni@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).