From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 289FB3858405 for ; Wed, 30 Mar 2022 09:44:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 289FB3858405 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="73621339" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 30 Mar 2022 01:44:05 -0800 IronPort-SDR: nGYZkBT16h7dE1/dmuVqAUuONyn2zkl+uLuhN4Z/MQoXGiSZUhtZJMI3CiOC+KOO+chWIVq6Wk 5RDpCvEh6Vy3CN9t/0EP7mCaa5TAYxW1FYm5IXGSiWQOBFCKO4hxW+YWhFat4h6/i2UE7yiMOj PP+nY4Xd94kHs/wI5L87pTAYkewDY2G0SJ86CI3aWcqidpYEZQA5lz2fWykMd/W1mIJmK/KvSR pKFIjxQqvsKwI8Wg3jWh0c1pI1viH71ypOOBQ/mwo46p5KGX8TvOTJGFRrvsMg+pVuViNjAhWC Nrs= Content-Type: multipart/mixed; boundary="------------RsLmfkOrW2egBnBWWWnaKnLd" Message-ID: <4c157ae5-3133-88da-7156-0e454e1f6535@codesourcery.com> Date: Wed, 30 Mar 2022 11:43:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: [Patch] (1/n) newlib: Only call _fputwc_r if ELIX_LEVEL >= 4 (was: Build-dependency issues with ELIX_LEVEL) Content-Language: en-US From: Tobias Burnus To: References: <0e04b11a-1b6d-c70a-c0fe-4ece59996461@codesourcery.com> In-Reply-To: <0e04b11a-1b6d-c70a-c0fe-4ece59996461@codesourcery.com> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 09:44:07 -0000 --------------RsLmfkOrW2egBnBWWWnaKnLd Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hello, this packages the the first patch of last/first email in this thread. As described in the commit log (and previous email), __sprint_r and __sfputs_r of (nano-)vfprintf.c call fputwc.c's _fputwc_r. While the vfprintf.c file is compiled for ELIX_LEVEL >=3D 1, the fputwc.c file is only compiled with ELIX_LEVEL >=3D 4. Solution: This patch ignores the _WIDE_ORIENT support in __sprint_r / __sfputs_r unless ELIX_LEVEL >=3D 4. It feels like the right solution but the ELIX description is vague enough to be not sure. Without that patch I get for ELIX_LEVEL =3D=3D 1 (with nvptx) a link error (missing symbol) for a code calling 'fprintf' (with no wide char used). OK? =E2=80=93 If so, please commit. Otherwise, comments are welcome. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------RsLmfkOrW2egBnBWWWnaKnLd Content-Type: text/x-patch; charset="UTF-8"; name="0001-newlib-Only-call-_fputwc_r-if-ELIX_LEVEL-4.patch" Content-Disposition: attachment; filename="0001-newlib-Only-call-_fputwc_r-if-ELIX_LEVEL-4.patch" Content-Transfer-Encoding: base64 W1BBVENIXSBuZXdsaWI6IE9ubHkgY2FsbCBfZnB1dHdjX3IgaWYgRUxJWF9MRVZFTCA+PSA0 CgoobmFuby0pdmZwcmludGYuYyBpcyBlbmFibGVkIGZvciBFTElYX0xFVkVMID49IDEuIFdo ZW4gX1dJREVfT1JJRU5UCmlzIHNldCwgaXRzIF9fc3ByaW50X3IgLyBfX3NmcHV0c19yIGZ1 bmN0aW9ucyB1bmNvbmRpdGlvbmFsbHkgY2FsbGVkCl9mcHV0d2NfciB3aGljaCBpcyBvbmx5 IGluIEVMRVhfTEVWRUwgPj0gNC4gV2l0aCB0aGlzIGNvbW1pdCwKdGhlIF9XSURFIHN1cHBv cnQgaW4gKG5hbm8tKXZmcHJpbnRmLmMgaXMgZGlzYWJsZWQgZm9yIEVMRVhfTEVWRUwgPCA0 LgoKLS0tCiBuZXdsaWIvbGliYy9zdGRpby9uYW5vLXZmcHJpbnRmLmMgfCA0ICsrLS0KIG5l d2xpYi9saWJjL3N0ZGlvL3ZmcHJpbnRmLmMgICAgICB8IDQgKystLQogMiBmaWxlcyBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbmV3 bGliL2xpYmMvc3RkaW8vbmFuby12ZnByaW50Zi5jIGIvbmV3bGliL2xpYmMvc3RkaW8vbmFu by12ZnByaW50Zi5jCmluZGV4IGJjN2VkMDc0My4uMjQ0NzIxOTVmIDEwMDY0NAotLS0gYS9u ZXdsaWIvbGliYy9zdGRpby9uYW5vLXZmcHJpbnRmLmMKKysrIGIvbmV3bGliL2xpYmMvc3Rk aW8vbmFuby12ZnByaW50Zi5jCkBAIC0zNTEsMTcgKzM1MSwxNyBAQCBfX3NwcmludF9yIChz dHJ1Y3QgX3JlZW50ICpwdHIsCiB7CiAgIHJlZ2lzdGVyIGludCBlcnIgPSAwOwogCiAgIGlm ICh1aW8tPnVpb19yZXNpZCA9PSAwKQogICAgIHsKICAgICAgIHVpby0+dWlvX2lvdmNudCA9 IDA7CiAgICAgICByZXR1cm4gMDsKICAgICB9Ci0jaWZkZWYgX1dJREVfT1JJRU5UCisjaWYg ZGVmaW5lZCBfV0lERV9PUklFTlQgJiYgKCFkZWZpbmVkIF9FTElYX0xFVkVMIHx8IF9FTElY X0xFVkVMID49IDQpCiAgICAgaWYgKGZwLT5fZmxhZ3MyICYgX19TV0lEKQogICAgICAgewog CXN0cnVjdCBfX3Npb3YgKmlvdjsKIAl3Y2hhcl90ICpwOwogCWludCBpLCBsZW47CiAKIAlp b3YgPSB1aW8tPnVpb19pb3Y7CiAJZm9yICg7IHVpby0+dWlvX3Jlc2lkICE9IDA7CkBAIC00 MDIsMTcgKzQwMiwxNyBAQCBfX3NmcHV0Y19yIChzdHJ1Y3QgX3JlZW50ICpwdHIsCiBpbnQK IF9fc2ZwdXRzX3IgKHN0cnVjdCBfcmVlbnQgKnB0ciwKICAgICAgICBGSUxFICpmcCwKICAg ICAgICBjb25zdCBjaGFyICpidWYsCiAgICAgICAgc2l6ZV90IGxlbikKIHsKICAgcmVnaXN0 ZXIgaW50IGk7CiAKLSNpZmRlZiBfV0lERV9PUklFTlQKKyNpZiBkZWZpbmVkIF9XSURFX09S SUVOVCAmJiAoIWRlZmluZWQgX0VMSVhfTEVWRUwgfHwgX0VMSVhfTEVWRUwgPj0gNCkKICAg aWYgKGZwLT5fZmxhZ3MyICYgX19TV0lEKQogICAgIHsKICAgICAgIHdjaGFyX3QgKnA7CiAK ICAgICAgIHAgPSAod2NoYXJfdCAqKSBidWY7CiAgICAgICBmb3IgKGkgPSAwOyBpIDwgKGxl biAvIHNpemVvZiAod2NoYXJfdCkpOyBpKyspCiAJewogCSAgaWYgKF9mcHV0d2NfciAocHRy LCBwW2ldLCBmcCkgPT0gV0VPRikKZGlmZiAtLWdpdCBhL25ld2xpYi9saWJjL3N0ZGlvL3Zm cHJpbnRmLmMgYi9uZXdsaWIvbGliYy9zdGRpby92ZnByaW50Zi5jCmluZGV4IGMxNDgzYzBh Yy4uNmZmNWI1Njg2IDEwMDY0NAotLS0gYS9uZXdsaWIvbGliYy9zdGRpby92ZnByaW50Zi5j CisrKyBiL25ld2xpYi9saWJjL3N0ZGlvL3ZmcHJpbnRmLmMKQEAgLTM2NSwxNyArMzY1LDE3 IEBAIGludCBfX3NzcHJpbnRfciAoc3RydWN0IF9yZWVudCAqLCBGSUxFICosIHJlZ2lzdGVy IHN0cnVjdCBfX3N1aW8gKik7CiBpbnQKIF9fc2ZwdXRzX3IgKHN0cnVjdCBfcmVlbnQgKnB0 ciwKICAgICAgICBGSUxFICpmcCwKICAgICAgICBjb25zdCBjaGFyICpidWYsCiAgICAgICAg c2l6ZV90IGxlbikKIHsKIAlyZWdpc3RlciBpbnQgaTsKIAotI2lmZGVmIF9XSURFX09SSUVO VAorI2lmIGRlZmluZWQgX1dJREVfT1JJRU5UICYmICghZGVmaW5lZCBfRUxJWF9MRVZFTCB8 fCBfRUxJWF9MRVZFTCA+PSA0KQogCWlmIChmcC0+X2ZsYWdzMiAmIF9fU1dJRCkgewogCQl3 Y2hhcl90ICpwOwogCiAJCXAgPSAod2NoYXJfdCAqKSBidWY7CiAJCWZvciAoaSA9IDA7IGkg PCAobGVuIC8gc2l6ZW9mICh3Y2hhcl90KSk7IGkrKykgewogCQkJaWYgKF9mcHV0d2NfciAo cHRyLCBwW2ldLCBmcCkgPT0gV0VPRikKIAkJCQlyZXR1cm4gLTE7CiAJCX0KQEAgLTQwMSwx NyArNDAxLDE3IEBAIF9fc3ByaW50X3IgKHN0cnVjdCBfcmVlbnQgKnB0ciwKICAgICAgICBy ZWdpc3RlciBzdHJ1Y3QgX19zdWlvICp1aW8pCiB7CiAJcmVnaXN0ZXIgaW50IGVyciA9IDA7 CiAKIAlpZiAodWlvLT51aW9fcmVzaWQgPT0gMCkgewogCQl1aW8tPnVpb19pb3ZjbnQgPSAw OwogCQlyZXR1cm4gKDApOwogCX0KLSNpZmRlZiBfV0lERV9PUklFTlQKKyNpZiBkZWZpbmVk IF9XSURFX09SSUVOVCAmJiAoIWRlZmluZWQgX0VMSVhfTEVWRUwgfHwgX0VMSVhfTEVWRUwg Pj0gNCkKIAlpZiAoZnAtPl9mbGFnczIgJiBfX1NXSUQpIHsKIAkJc3RydWN0IF9fc2lvdiAq aW92OwogCQl3Y2hhcl90ICpwOwogCQlpbnQgaSwgbGVuOwogCiAJCWlvdiA9IHVpby0+dWlv X2lvdjsKIAkJZm9yICg7IHVpby0+dWlvX3Jlc2lkICE9IDA7CiAJCSAgICAgdWlvLT51aW9f cmVzaWQgLT0gbGVuICogc2l6ZW9mICh3Y2hhcl90KSwgaW92KyspIHsK --------------RsLmfkOrW2egBnBWWWnaKnLd--