From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id 3C3083858D1E for ; Mon, 20 Feb 2023 23:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C3083858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=Shaw.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=shaw.ca Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id UEkkpV3VduZMSUFSuplZ3L; Mon, 20 Feb 2023 23:21:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=shaw.ca; s=s20180605; t=1676935260; bh=JuUvJWTIM4N5IovP0KEScLHjQD+lJNXWG6fjYDpufrs=; h=Date:Reply-To:Subject:To:References:From:In-Reply-To; b=p7EdmB1yMJxjaZ6nzfc9wiv4Bu6xh0GECg/q1Zt9j9PZaDL2aXZSbDdrcndpAdgnS glrsyjHe7qAG9yTRc0ZtaUU4Ip9TlvB/xNRfmU5GN4NMMC6KzwJBs+URiWMEB7Wj0e Ct0FIZ3p7O8apwOiyV9c3vm42yfM2jYRWQecjP2EzFqPkuIil1UGKCfIwB3jXnxPyV 27U59wNJbOMyInJekK83bBhsmVASjcRL6MNtu6kRDiLKY5WUw+vF6ndZ16+u122Qeg mBd5extV4ekWGFxC+Es7nqji04b5KwBDY59qMRmk4shQp+hj1x6y7roLqdXVtEPKqm XhSBGdA8TLEIA== Received: from [10.0.0.5] ([184.64.102.149]) by cmsmtp with ESMTP id UFStpU6uoyAOeUFStpmrej; Mon, 20 Feb 2023 23:21:00 +0000 X-Authority-Analysis: v=2.4 cv=e5oV9Il/ c=1 sm=1 tr=0 ts=63f4005c a=DxHlV3/gbUaP7LOF0QAmaA==:117 a=DxHlV3/gbUaP7LOF0QAmaA==:17 a=IkcTkHD0fZMA:10 a=mDV3o1hIAAAA:8 a=Vq65zw_2q53cptxraFIA:9 a=QEXdDO2ut3YA:10 a=AP3JQZ_qGYIA:10 a=_FVE-zBwftR9WsbkzFJk:22 Message-ID: <4c52eb49-e114-53e6-b30b-48bbfb6ba9bc@Shaw.ca> Date: Mon, 20 Feb 2023 16:20:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Reply-To: newlib@sourceware.org Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues Content-Language: en-CA To: newlib@sourceware.org References: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> <381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk> From: Brian Inglis Organization: Inglis In-Reply-To: <381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfJWW5GDMJVdh8/7ojqMov/oo8X3d/ebBRG/0oYZThwEnUDgF9WncFZRwQ9eLyQrpgv4rll/NHkKH0+BI5XhxrhanwkpHHev3Btuo83BOc1/u4oddCPHz 0VAdC8kFzGVgornyf2LsfsCm6moTunfagTPy6n6M0FQORv5gGLVadTaNhEjH3sooROBWULDAN14Z8g== X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-20 15:03, Jon Turney wrote: > On 20/02/2023 20:25, Brian Inglis wrote: >> On 2023-02-20 02:45, Corinna Vinschen wrote: >>> Hi Brian, >>> >>> On Feb 17 13:49, Brian Inglis wrote: >>>> Brian Inglis (2): >>>>    newlib/libc/time/strftime.c: split table of conversion >>>>      specifiers to fix man, tbl, groff multi-page table issues >>>>    newlib/libc/Makefile.inc: sed fix strftime.3 table format >>>>      man, tbl, groff multi-page issues >>>> >>>>   newlib/libc/time/strftime.c | 3 ++- >>>>   newlib/libc/Makefile.inc    | 1 + >>>>   2 files changed, 3 insertions(+), 1 deletion(-) >>>> >>>> -- >>>> 2.39.0 >>> >>> Would you mind terribly to add more text to the commit messages? >>> explaining the problem, and its fix?  Just the subject line is quite >>> terse. >>> >>> For patch 1, why adding the split and what's the desired effect.  For >>> patch 2, what problem is the sed call fixing and what is the sed >>> expression doing? >> >> Thanks Corinna, You're right - will redo all v3. > > You should also describe why this must be fixed in this ad-hoc fasion, rather > than in the chew markup or makedocbook. I'll also ref the discussion with Branden, following comments from linux-man, the newlib man generation by docbook2man is incompatible with how man is incompatible with groff/tbl/grohtml: https://lists.gnu.org/archive/html/bug-groff/2023-02/msg00118.html I dug and could not find a good point to alter generation of tables > page size that may not adversely affect other [newlib] doc man page tables, where the problem occurs solely on that strftime.3 man page! Also the imminent groff/tbl/grohtml release fixes a number of tbl issues, so may affect man pages with tables differently. The following release plans to change grohtml, from generating tables as PNG graphics, which don't work on some output "devices"/file formats, and are not searchable, to generating tables in searchable text form on the target "devices"/file formats, so will also affect man pages with tables differently, and fix other related issues. -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut -- Antoine de Saint-Exupéry