From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8052 invoked by alias); 2 Nov 2017 12:08:31 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 8038 invoked by uid 89); 2 Nov 2017 12:08:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-17.6 required=5.0 tests=AWL,BAYES_40,FOREIGN_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=HTo:U*joel, EMail, E-Mail, Nachricht X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Nov 2017 12:08:28 +0000 Received: from [88.198.220.132] (helo=sslproxy03.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1eAEIM-0000i4-1x; Thu, 02 Nov 2017 13:08:26 +0100 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy03.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eAEIL-0003o3-Im; Thu, 02 Nov 2017 13:08:25 +0100 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id AD5D92A096E; Thu, 2 Nov 2017 13:08:46 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id TFaAdinDcQwx; Thu, 2 Nov 2017 13:08:46 +0100 (CET) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 49B3A2A1677; Thu, 2 Nov 2017 13:08:46 +0100 (CET) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6dWNSRp7NmfY; Thu, 2 Nov 2017 13:08:46 +0100 (CET) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 31BFF2A096E; Thu, 2 Nov 2017 13:08:46 +0100 (CET) Subject: Re: [PATCH v3 2/2] newlib/.../getreent.c: Do not define if __DYNAMIC_REENT__ is enabled To: Joel Sherrill , newlib@sourceware.org References: <1509139960-28052-1-git-send-email-joel@rtems.org> <1509139960-28052-2-git-send-email-joel@rtems.org> From: Sebastian Huber Message-ID: <51ed1480-5ca5-08da-b394-e5efeb8a82a7@embedded-brains.de> Date: Thu, 02 Nov 2017 12:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509139960-28052-2-git-send-email-joel@rtems.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg01072.txt.bz2 On 27/10/17 23:32, Joel Sherrill wrote: > RTEMS provides the option to have a global or per-thread reentrancy > as part of application configuration. As part of this, RTEMS provides > the implementation of __getreent() as appropriate. Allow the target > to determine if this method is present in libc.a. > --- > newlib/libc/reent/getreent.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/newlib/libc/reent/getreent.c b/newlib/libc/reent/getreent.c > index 60ae6fb..b42a88b 100644 > --- a/newlib/libc/reent/getreent.c > +++ b/newlib/libc/reent/getreent.c > @@ -1,5 +1,13 @@ > /* default reentrant pointer when multithread enabled */ >=20=20=20 > +#include > + > +#ifdef __DYNAMIC_REENT__ > + > +int _dummy_getreent; > + > +#else > + > #include <_ansi.h> > #include >=20=20=20 > @@ -12,3 +20,5 @@ _DEFUN_VOID(__getreent) > { > return _impure_ptr; > } > + > +#endif __getreent() is only used if __DYNAMIC_REENT__ is defined: #if defined(__DYNAMIC_REENT__) && !defined(__SINGLE_THREAD__) #ifndef __getreent =C2=A0 struct _reent * _EXFUN(__getreent, (void)); #endif # define _REENT (__getreent()) #else /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */ # define _REENT _impure_ptr #endif /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */ Why can't we delete this file (newlib/libc/reent/getreent.c)? --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.