* tzcalc_limits.c:49:28: error: 'month_lengths' undeclared
@ 2014-09-12 21:21 Logan Anteau
2014-09-12 21:43 ` Jeff Johnston
0 siblings, 1 reply; 6+ messages in thread
From: Logan Anteau @ 2014-09-12 21:21 UTC (permalink / raw)
To: newlib
I believe tzcalc_limits.c line 49 should use __month_lengths instead.
Logan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tzcalc_limits.c:49:28: error: 'month_lengths' undeclared
2014-09-12 21:21 tzcalc_limits.c:49:28: error: 'month_lengths' undeclared Logan Anteau
@ 2014-09-12 21:43 ` Jeff Johnston
2014-09-13 7:00 ` [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths" Freddie Chopin
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnston @ 2014-09-12 21:43 UTC (permalink / raw)
To: Logan Anteau; +Cc: newlib
Yes...I didn't look at the fix-up patch closely. Fixed. Thanks.
----- Original Message -----
From: "Logan Anteau" <logan.anteau@gmail.com>
To: newlib@sourceware.org
Sent: Friday, September 12, 2014 5:21:41 PM
Subject: tzcalc_limits.c:49:28: error: 'month_lengths' undeclared
I believe tzcalc_limits.c line 49 should use __month_lengths instead.
Logan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"
2014-09-12 21:43 ` Jeff Johnston
@ 2014-09-13 7:00 ` Freddie Chopin
2014-09-15 14:20 ` Freddie Chopin
0 siblings, 1 reply; 6+ messages in thread
From: Freddie Chopin @ 2014-09-13 7:00 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
W dniu 2014-09-12 23:43, Jeff Johnston pisze:
> Yes...I didn't look at the fix-up patch closely. Fixed. Thanks.
You took both missing files (month_lengths.c and tzcalc_limits.c) from
the first version of patch, so that's the reason for the above problem.
But that's not the only problem - the problematic array has old name
"month_lengths", not "__month_lengths".
I compile-checked that (with a call to localtime(), to actually pull the
relevant code in the link) and it seems to be the last problem. I attach
patch with a changelog.
Are patches in git format a problem to apply on CVS repo?
Regards,
FCh
[-- Attachment #2: ChangeLog.txt --]
[-- Type: text/plain, Size: 183 bytes --]
2014-09-13 Freddie Chopin <freddie_chopin@op.pl>
* libc\time\month_lengths.c: use proper (as in original patch) name for
array - "__month_lengths" instead of "month_lengths"
[-- Attachment #3: 0001-libc-time-month_lengths.c-use-proper-as-in-original-.patch --]
[-- Type: text/plain, Size: 846 bytes --]
From 6be988383b1adba2f9f92724ae3e3d9a9545bc5a Mon Sep 17 00:00:00 2001
From: Freddie Chopin <freddie.chopin@gmail.com>
Date: Sat, 13 Sep 2014 08:58:00 +0200
Subject: [PATCH] libc/time/month_lengths.c: use proper (as in original patch)
name for array - "__month_lengths" instead of "month_lengths"
---
newlib/libc/time/month_lengths.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/time/month_lengths.c b/newlib/libc/time/month_lengths.c
index 764e700..57f70eb 100644
--- a/newlib/libc/time/month_lengths.c
+++ b/newlib/libc/time/month_lengths.c
@@ -8,7 +8,7 @@
#include "local.h"
-_CONST int month_lengths[2][MONSPERYEAR] = {
+_CONST int __month_lengths[2][MONSPERYEAR] = {
{31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31},
{31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}
} ;
--
1.8.1.msysgit.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"
2014-09-13 7:00 ` [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths" Freddie Chopin
@ 2014-09-15 14:20 ` Freddie Chopin
2014-09-15 16:11 ` Jeff Johnston
0 siblings, 1 reply; 6+ messages in thread
From: Freddie Chopin @ 2014-09-15 14:20 UTC (permalink / raw)
To: newlib
W dniu 2014-09-13 09:00, Freddie Chopin pisze:
> W dniu 2014-09-12 23:43, Jeff Johnston pisze:
>> Yes...I didn't look at the fix-up patch closely. Fixed. Thanks.
>
> You took both missing files (month_lengths.c and tzcalc_limits.c) from
> the first version of patch, so that's the reason for the above problem.
> But that's not the only problem - the problematic array has old name
> "month_lengths", not "__month_lengths".
>
> I compile-checked that (with a call to localtime(), to actually pull the
> relevant code in the link) and it seems to be the last problem. I attach
> patch with a changelog.
>
> Are patches in git format a problem to apply on CVS repo?
I'm pinging about the patch I posted on Friday, as the problem now is
hidden - newlib will compile fine, but any application which would
actually need this array would fail to link, there will be no previous
indication of the problem.
Regards,
FCh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"
2014-09-15 14:20 ` Freddie Chopin
@ 2014-09-15 16:11 ` Jeff Johnston
2014-09-15 17:30 ` Freddie Chopin
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnston @ 2014-09-15 16:11 UTC (permalink / raw)
To: newlib
The change has been made. Hopefully, this time I finally got it right.
-- Jeff J.
----- Original Message -----
From: "Freddie Chopin" <freddie_chopin@op.pl>
To: newlib@sourceware.org
Sent: Monday, September 15, 2014 10:20:28 AM
Subject: Re: [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"
W dniu 2014-09-13 09:00, Freddie Chopin pisze:
> W dniu 2014-09-12 23:43, Jeff Johnston pisze:
>> Yes...I didn't look at the fix-up patch closely. Fixed. Thanks.
>
> You took both missing files (month_lengths.c and tzcalc_limits.c) from
> the first version of patch, so that's the reason for the above problem.
> But that's not the only problem - the problematic array has old name
> "month_lengths", not "__month_lengths".
>
> I compile-checked that (with a call to localtime(), to actually pull the
> relevant code in the link) and it seems to be the last problem. I attach
> patch with a changelog.
>
> Are patches in git format a problem to apply on CVS repo?
I'm pinging about the patch I posted on Friday, as the problem now is
hidden - newlib will compile fine, but any application which would
actually need this array would fail to link, there will be no previous
indication of the problem.
Regards,
FCh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths"
2014-09-15 16:11 ` Jeff Johnston
@ 2014-09-15 17:30 ` Freddie Chopin
0 siblings, 0 replies; 6+ messages in thread
From: Freddie Chopin @ 2014-09-15 17:30 UTC (permalink / raw)
To: newlib
W dniu 2014-09-15 18:11, Jeff Johnston pisze:
> The change has been made. Hopefully, this time I finally got it right.
Yes, it's OK now. If there's anything that I can do to make applying
patches easier - just let me know.
Regards,
FCh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-15 17:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12 21:21 tzcalc_limits.c:49:28: error: 'month_lengths' undeclared Logan Anteau
2014-09-12 21:43 ` Jeff Johnston
2014-09-13 7:00 ` [PATCH] libc/time/month_lengths.c: use proper (as in original patch) name for array - "__month_lengths" instead of "month_lengths" Freddie Chopin
2014-09-15 14:20 ` Freddie Chopin
2014-09-15 16:11 ` Jeff Johnston
2014-09-15 17:30 ` Freddie Chopin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).