From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81897 invoked by alias); 14 Jun 2017 09:25:36 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 78269 invoked by uid 89); 14 Jun 2017 09:25:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,FOREIGN_BODY,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=no version=3.3.2 spammy=Hx-languages-length:2103, summer, Summer X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 09:25:26 +0000 Received: from [88.198.220.132] (helo=sslproxy03.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1dL4YK-00068a-RY for newlib@sourceware.org; Wed, 14 Jun 2017 11:25:28 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy03.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dL4YK-00068a-FW for newlib@sourceware.org; Wed, 14 Jun 2017 11:25:28 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 8A1DE2A004F for ; Wed, 14 Jun 2017 11:25:37 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QzZFdR32Bp3N for ; Wed, 14 Jun 2017 11:25:35 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 32ED52A160A for ; Wed, 14 Jun 2017 11:25:35 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HIsZQHT_wbK7 for ; Wed, 14 Jun 2017 11:25:35 +0200 (CEST) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id E37922A004F for ; Wed, 14 Jun 2017 11:25:34 +0200 (CEST) Subject: Re: Adding Methods related to inttypes.h To: newlib@sourceware.org References: <20170614084406.GP13513@calimero.vinschen.de> From: Sebastian Huber Message-ID: <54a660fc-e50a-62eb-cabd-257069c09cb8@embedded-brains.de> Date: Wed, 14 Jun 2017 09:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170614084406.GP13513@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00417.txt.bz2 On 14/06/17 10:44, Corinna Vinschen wrote: > On Jun 14 07:42, Sebastian Huber wrote: >> On 13/06/17 21:03, aditya upadhyay wrote: >> >>> Hello Developers, >>> >>> I have ported the methods what are declared inside the inttypes.h >>> header file from freebsd. I am requesting you to please review the >>> code. >>> >>> I am not able to push the code of ccoshl.c in my forked repo. It is >>> saying fatal error. I do not know how to apply the signature.asc file. >>> Please have a look on my issue. >>> [...] >>> newlib/libc/Makefile.am | 4 +- >>> newlib/libc/inttypes/Makefile.am | 24 +++++++ >>> newlib/libc/inttypes/imaxabs.c | 44 ++++++++++++ >>> newlib/libc/inttypes/imaxdiv.c | 53 ++++++++++++++ >>> newlib/libc/inttypes/strtoimax.c | 144 +++++++++++++++++++++++++++++= ++++++++ >>> newlib/libc/inttypes/strtoumax.c | 135 +++++++++++++++++++++++++++++= +++++ >>> newlib/libc/inttypes/wcstoimax.c | 151 +++++++++++++++++++++++++++++= ++++++++++ >>> newlib/libc/inttypes/wcstoumax.c | 144 +++++++++++++++++++++++++++++= ++++++++ >> These functions should probably go into "newlib/libc/stdlib" just like on >> FreeBSD and NetBSD. Where does this "inttypes" directory come from? > ACK. > > Also, newlib already has functions strtoll, strtoull, wcstoll, wcstoull. > So the aliasing to strtoimax, etc, seems like a bad idea. In theory, > all we need is an aliasing from strtoll to strtoumax, etc, in the existing > sources. As a background information, this is part of a Google Summer of Code=20 project: https://docs.google.com/document/d/1_eo87eOiHmIHokfsgFYY3F98FNmorpVTm4AI1WE= -iKo/edit You can use __strong_alias from to create an alias from=20 strtoll to strtoumax. We should make sure that the types have the same=20 size with a compile-time assertion. --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.