From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53461 invoked by alias); 13 Feb 2017 22:16:54 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 53442 invoked by uid 89); 13 Feb 2017 22:16:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=misc, H*M:zimbra, armnoneeabi, arm-none-eabi X-HELO: mx6-phx2.redhat.com Received: from mx6-phx2.redhat.com (HELO mx6-phx2.redhat.com) (209.132.183.39) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Feb 2017 22:16:42 +0000 Received: from zmail20.collab.prod.int.phx2.redhat.com (zmail20.collab.prod.int.phx2.redhat.com [10.5.83.23]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1DMGfhT005508; Mon, 13 Feb 2017 17:16:41 -0500 Date: Mon, 13 Feb 2017 22:16:00 -0000 From: Jeff Johnston To: Thomas Preudhomme Cc: newlib@sourceware.org Message-ID: <581333258.27144233.1487024201901.JavaMail.zimbra@redhat.com> In-Reply-To: <6cc898f2-c2e9-5d38-d4be-03194bc3201d@foss.arm.com> References: <53697464-af87-8917-c5ec-b1a0d06cca00@foss.arm.com> <7477136f-dc07-5081-a06f-2144a8ce2251@foss.arm.com> <1485938598.1269.1.camel@op.pl> <5e4abc64-54d7-9402-d2ac-d08c4d419402@foss.arm.com> <336826923.24372261.1486503410689.JavaMail.zimbra@redhat.com> <9f1e2c24-40d9-c163-4895-fb2ad418165d@foss.arm.com> <1199540764.24714361.1486590050100.JavaMail.zimbra@redhat.com> <6cc898f2-c2e9-5d38-d4be-03194bc3201d@foss.arm.com> Subject: Re: [PATCH 3/3, newlib] Allow locking routine to be retargeted MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00142.txt.bz2 Patch checked in. -- Jeff J. ----- Original Message ----- > Hi Jeff, > > Please find an updated patch which does not add extra noop code for single > threaded mode in sys/lock.h as requested. Please note that it goes together > with > an updated version of the previous patch in the patch series [1]. > > [1] https://sourceware.org/ml/newlib/2017/msg00136.html > > Best regards, > > Thomas > > On 08/02/17 21:40, Jeff Johnston wrote: > > Thanks Thomas, > > > > Regarding that other patch. I do not feel the extra noop code in > > sys/lock.h is warranted and > > seems extraneous. I would prefer the users of the lock protect the usage > > as you have added. > > > > -- Jeff J. > > > > ----- Original Message ----- > >> Hi Jeff, > >> > >> Please find an updated patch with consistent lock naming. Have you had a > >> look > >> at > >> the patch prior to this one [1]? > >> > >> [1] https://sourceware.org/ml/newlib/2017/msg00112.html > >> > >> Thanks for your time. > >> > >> Best regards, > >> > >> Thomas > >> > >> On 07/02/17 21:36, Jeff Johnston wrote: > >>> Hi Thomas, > >>> > >>> The patch is fine except for the lock.c inline docs still have references > >>> to old lock names (prior to the ANSI_SYNOPSIS). > >>> > >>> -- Jeff J. > >>> > >>> ----- Original Message ----- > >>>> Ooops, forgot about this. Please find an updated patch attached. > >>>> > >>>> Best regards, > >>>> > >>>> Thomas > >>>> > >>>> On 01/02/17 08:43, Freddie Chopin wrote: > >>>>> Hi! > >>>>> > >>>>> With all relevant 3 patches applied the toolchain builds and works > >>>>> fine, but the issue with HTML documentation still persists - at least > >>>>> here on Arch Linux: > >>>>> > >>>>> --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- > >>>>> > >>>>> make[2]: Entering directory '/home/freddie/bleeding-edge- > >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc/syscalls' > >>>>> for chapter in ; \ > >>>>> do \ > >>>>> cat /home/freddie/bleeding-edge-toolchain/sources/newlib- > >>>>> 2.5.0/newlib/libc/syscalls/$chapter >> /home/freddie/bleeding-edge- > >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc/tmp- > >>>>> targetdep.texi ; \ > >>>>> done > >>>>> make[2]: Leaving directory '/home/freddie/bleeding-edge- > >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc/syscalls' > >>>>> cat /home/freddie/bleeding-edge-toolchain/sources/newlib- > >>>>> 2.5.0/newlib/libc/sys.tex >>tmp-targetdep.texi > >>>>> /bin/sh /home/freddie/bleeding-edge-toolchain/sources/newlib- > >>>>> 2.5.0/newlib/libc/../../move-if-change tmp-targetdep.texi targetdep.tex > >>>>> touch stmp-targetdep > >>>>> rm -rf libc.htp > >>>>> if makeinfo --split-size=5000000 --html -I /home/freddie/bleeding- > >>>>> edge-toolchain/sources/newlib-2.5.0/newlib/libc \ > >>>>> -o libc.htp /home/freddie/bleeding-edge-toolchain/sources/newlib- > >>>>> 2.5.0/newlib/libc/libc.texinfo; \ > >>>>> then \ > >>>>> rm -rf libc.html; \ > >>>>> if test ! -d libc.htp && test -d libc; then \ > >>>>> mv libc libc.html; else mv libc.htp libc.html; fi; \ > >>>>> else \ > >>>>> if test ! -d libc.htp && test -d libc; then \ > >>>>> rm -rf libc; else rm -Rf libc.htp libc.html; fi; \ > >>>>> exit 1; \ > >>>>> fi > >>>>> ./targetdep.tex:1420: @menu reference to nonexistent node `lock' > >>>>> stdlib/div.def:1: warning: node next `div' in menu `ecvtbuf' and in > >>>>> sectioning `ecvt' differ > >>>>> stdlib/efgcvt.def:1: warning: node next `ecvt' in menu `__env_lock' and > >>>>> in sectioning `gcvt' differ > >>>>> stdlib/efgcvt.def:1: warning: node prev `ecvt' in menu `ecvtbuf' and in > >>>>> sectioning `div' differ > >>>>> stdlib/efgcvt.def:60: warning: node next `gcvt' in menu `exit' and in > >>>>> sectioning `ecvtbuf' differ > >>>>> stdlib/efgcvt.def:60: warning: node prev `gcvt' in menu `__env_lock' > >>>>> and in sectioning `ecvt' differ > >>>>> stdlib/ecvtbuf.def:1: warning: node next `ecvtbuf' in menu `ecvt' and > >>>>> in sectioning `__env_lock' differ > >>>>> stdlib/ecvtbuf.def:1: warning: node prev `ecvtbuf' in menu `div' and in > >>>>> sectioning `gcvt' differ > >>>>> stdlib/envlock.def:1: warning: node next `__env_lock' in menu `gcvt' > >>>>> and in sectioning `exit' differ > >>>>> stdlib/envlock.def:1: warning: node prev `__env_lock' in menu `ecvt' > >>>>> and in sectioning `ecvtbuf' differ > >>>>> stdlib/exit.def:1: warning: node prev `exit' in menu `gcvt' and in > >>>>> sectioning `__env_lock' differ > >>>>> stdlib/mlock.def:1: warning: node next `__malloc_lock' in menu > >>>>> `mbsrtowcs' and in sectioning `mblen' differ > >>>>> stdlib/mblen.def:1: warning: node next `mblen' in menu `mbtowc' and in > >>>>> sectioning `mbsrtowcs' differ > >>>>> stdlib/mblen.def:1: warning: node prev `mblen' in menu `mbstowcs' and > >>>>> in sectioning `__malloc_lock' differ > >>>>> stdlib/mbsnrtowcs.def:1: warning: node prev `mbsrtowcs' in menu > >>>>> `__malloc_lock' and in sectioning `mblen' differ > >>>>> stdlib/mbstowcs.def:1: warning: node next `mbstowcs' in menu `mblen' > >>>>> and in sectioning `mbtowc' differ > >>>>> stdlib/mbtowc.def:1: warning: node prev `mbtowc' in menu `mblen' and in > >>>>> sectioning `mbstowcs' differ > >>>>> ctype/iswalpha.def:1: warning: node next `iswalpha' in menu `iswblank' > >>>>> and in sectioning `iswcntrl' differ > >>>>> ctype/iswcntrl.def:1: warning: node next `iswcntrl' in menu `iswdigit' > >>>>> and in sectioning `iswblank' differ > >>>>> ctype/iswcntrl.def:1: warning: node prev `iswcntrl' in menu `iswblank' > >>>>> and in sectioning `iswalpha' differ > >>>>> ctype/iswblank.def:1: warning: node next `iswblank' in menu `iswcntrl' > >>>>> and in sectioning `iswdigit' differ > >>>>> ctype/iswblank.def:1: warning: node prev `iswblank' in menu `iswalpha' > >>>>> and in sectioning `iswcntrl' differ > >>>>> ctype/iswdigit.def:1: warning: node prev `iswdigit' in menu `iswcntrl' > >>>>> and in sectioning `iswblank' differ > >>>>> misc/ffs.def:1: warning: node next `ffs' in menu `unctrl' and in > >>>>> sectioning `__retarget_lock_init' differ > >>>>> misc/lock.def:1: warning: unreferenced node `__retarget_lock_init' > >>>>> misc/lock.def:1: warning: node `unctrl' is next for > >>>>> `__retarget_lock_init' in sectioning but not in menu > >>>>> misc/lock.def:1: warning: node `ffs' is prev for `__retarget_lock_init' > >>>>> in sectioning but not in menu > >>>>> misc/lock.def:1: warning: node `Misc' is up for `__retarget_lock_init' > >>>>> in sectioning but not in menu > >>>>> ./targetdep.tex:1414: node `Misc' lacks menu item for > >>>>> `__retarget_lock_init' despite being its Up target > >>>>> misc/unctrl.def:1: warning: node prev `unctrl' in menu `ffs' and in > >>>>> sectioning `__retarget_lock_init' differ > >>>>> reent/execr.def:19: warning: node next `_fork_r' in menu `_fstat_r' and > >>>>> in sectioning `_wait_r' differ > >>>>> reent/execr.def:36: warning: node next `_wait_r' in menu `_write_r' and > >>>>> in sectioning `_fstat_r' differ > >>>>> reent/execr.def:36: warning: node prev `_wait_r' in menu `_unlink_r' > >>>>> and in sectioning `_fork_r' differ > >>>>> reent/fstatr.def:1: warning: node next `_fstat_r' in menu `_getpid_r' > >>>>> and in sectioning `_link_r' differ > >>>>> reent/fstatr.def:1: warning: node prev `_fstat_r' in menu `_fork_r' and > >>>>> in sectioning `_wait_r' differ > >>>>> reent/linkr.def:1: warning: node prev `_link_r' in menu `_kill_r' and > >>>>> in sectioning `_fstat_r' differ > >>>>> reent/sbrkr.def:1: warning: node next `_sbrk_r' in menu `_stat_r' and > >>>>> in sectioning `_kill_r' differ > >>>>> reent/signalr.def:1: warning: node next `_kill_r' in menu `_link_r' and > >>>>> in sectioning `_getpid_r' differ > >>>>> reent/signalr.def:1: warning: node prev `_kill_r' in menu `_getpid_r' > >>>>> and in sectioning `_sbrk_r' differ > >>>>> reent/signalr.def:18: warning: node next `_getpid_r' in menu `_kill_r' > >>>>> and in sectioning `_stat_r' differ > >>>>> reent/signalr.def:18: warning: node prev `_getpid_r' in menu `_fstat_r' > >>>>> and in sectioning `_kill_r' differ > >>>>> reent/statr.def:1: warning: node prev `_stat_r' in menu `_sbrk_r' and > >>>>> in sectioning `_getpid_r' differ > >>>>> reent/unlinkr.def:1: warning: node next `_unlink_r' in menu `_wait_r' > >>>>> and in sectioning `_write_r' differ > >>>>> reent/writer.def:1: warning: node prev `_write_r' in menu `_wait_r' and > >>>>> in sectioning `_unlink_r' differ > >>>>> make[1]: *** [Makefile:561: libc.html] Error 1 > >>>>> make[1]: Leaving directory '/home/freddie/bleeding-edge- > >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc' > >>>>> make: *** [Makefile:680: install-html-recursive] Error 1 > >>>>> > >>>>> --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- > >>>>> > >>>>> Regards, > >>>>> FCh > >>>>> > >>>> > >> >