From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8101 invoked by alias); 23 May 2017 21:20:39 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 8090 invoked by uid 89); 23 May 2017 21:20:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=years, year's X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 May 2017 21:20:38 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60E9480C11 for ; Tue, 23 May 2017 21:20:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 60E9480C11 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=none smtp.mailfrom=yselkowitz@cygwin.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 60E9480C11 Received: from [10.10.120.19] (ovpn-120-19.rdu2.redhat.com [10.10.120.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AA4217135 for ; Tue, 23 May 2017 21:20:39 +0000 (UTC) Subject: Re: [PATCH] Use __BSD_VISIBLE for RTEMS To: newlib@sourceware.org References: <20170523082353.1793-1-sebastian.huber@embedded-brains.de> <63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com> From: Yaakov Selkowitz Message-ID: <5cdb77fc-91c9-f600-9d0c-def874c557d9@cygwin.com> Date: Tue, 23 May 2017 21:20:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00353.txt.bz2 On 2017-05-23 10:16, Craig Howland wrote: > On 05/23/2017 04:23 AM, Sebastian Huber wrote: >> The Termios header used _POSIX_SOURCE directly to >> determine if a thing should be exposed to the user. This circumvented >> the feature mechanisms of . > Would you please explain why !_POSIX_SOURCE being replaced with > __BSD_VISIBLE rather than, for example, !__POSIX_VISIBLE? That is, you > seem to not only be updating to sys/features.h macro names, but also > shifting exactly how the gate is done. (I'm not saying it is > necessarily incorrect, just that the explanation does not mention the > logic change. The two are not logical opposites, so an implication is > that the original gate of POSIX is not really the right one.) LGTM. This goes along with last year's feature test macros overhaul. Feature test macros are meant to be inclusive, not exclusive (with a few exceptions not relevant here), and so the original guards weren't really correct to start with. -- Yaakov