public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Joel Sherrill <joel.sherrill@oarcorp.com>
To: Yaakov Selkowitz <yselkowitz@cygwin.com>,
	"newlib@sourceware.org" <newlib@sourceware.org>,
	aditya upadhyay <aadit0402@gmail.com>
Subject: Re: Long double complex methods
Date: Thu, 29 Jun 2017 21:17:00 -0000	[thread overview]
Message-ID: <5cff4633-2ef4-623b-e526-61c22e707d87@oarcorp.com> (raw)
In-Reply-To: <d7b7bbb4-d9f8-bf3f-334a-bccf115ca34d@cygwin.com>



On 6/29/2017 2:38 PM, Yaakov Selkowitz wrote:
> On 2017-06-29 07:04, Corinna Vinschen wrote:
>> On Jun 29 13:53, Corinna Vinschen wrote:
>>> On Jun 29 12:41, Aditya Upadhyay wrote:
>>>> Hello Developers,
>>>>
>>>> This is the modified patch for csinl.c which reflects changes in Makefile.am.
>>>
>>> Uhm... this patch now contains *only* the Makefile.am change, but
>>> not the expected csinl.c file.
>>>
>>> v3? ;)
>>
>> Never mind, I'm going to apply v1 and v2 of patch 18.  However, usually
>> a v2 (or v3, v4, ...) of a patch is expected to replace the v1 of the
>> patch entirely, not that it just contains a diff to v1.
>>
>> I pushed the set now and regenerated complex/Makefile.in.
> 
> This patchset is causing errors when building Cygwin:
> 
> newlib/libm/complex/cargl.c: In function  cargl’:
> newlib/libm/complex/cargl.c:16:25: error: implicit declaration of
> function ‘imag’ [-Werror=implicit-function-declaration]
>             return atan2l (imag (z), real (z));
>                            ^
> newlib/libm/complex/cargl.c:16:35: error: implicit declaration of
> function ‘real’ [-Werror=implicit-function-declaration]
>             return atan2l (imag (z), real (z));
>                                      ^
> 

It builds for RTEMS (sparc) with some new warnings:

newlib/libm/complex/cacoshl.c:42:16: warning: implicit declaration of function 'csqrtl'; did you mean 'csqrtf'? [-Wimplicit-function-declaration]
newlib/libm/complex/cacoshl.c:42:6: warning: implicit declaration of function 'clogl'; did you mean 'clogf'? [-Wimplicit-function-declaration]
newlib/libm/complex/cacosl.c:41:6: warning: implicit declaration of function 'casinl'; did you mean 'asinl'? [-Wimplicit-function-declaration]
newlib/libm/complex/casinhl.c:39:18: warning: implicit declaration of function 'casinl'; did you mean 'casinhl'? [-Wimplicit-function-declaration]
newlib/libm/complex/casinl.c:112:7: warning: implicit declaration of function 'csqrtl'; did you mean 'sqrtl'? [-Wimplicit-function-declaration]
newlib/libm/complex/casinl.c:115:7: warning: implicit declaration of function 'clogl'; did you mean 'logl'? [-Wimplicit-function-declaration]
newlib/libm/complex/catanhl.c:39:18: warning: implicit declaration of function 'catanl'; did you mean 'catanhl'? [-Wimplicit-function-declaration]
newlib/libm/complex/cpowl.c:47:9: warning: implicit declaration of function 'cargl'; did you mean 'cargf'? [-Wimplicit-function-declaration]

I don't see any Cygwin ifdef's related to imag()
so I built for i386-rtems to see if it was related
to _LDBL_EQ_DBL. i386-rtems built with a few warnings.

We have an x86_64-rtems tool target in anticipation of
a port. I built a tool chain just to check this and
the newlib master built cleanly on that.

I am sorry but I am not duplicating this. What would
be different about Cygwin in this case?

--joel

  reply	other threads:[~2017-06-29 21:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 20:35 Aditya Upadhyay
2017-06-28 21:36 ` Dionna Amalie Glaze via newlib
2017-06-28 21:57   ` Joel Sherrill
2017-06-29 16:18     ` Joseph Myers
2017-06-29 16:31       ` Joel Sherrill
2017-06-29  6:39 ` Corinna Vinschen
2017-06-29  7:11   ` Aditya Upadhyay
2017-06-29 11:53     ` Corinna Vinschen
2017-06-29 12:04       ` Corinna Vinschen
2017-06-29 19:38         ` Yaakov Selkowitz
2017-06-29 21:17           ` Joel Sherrill [this message]
2017-06-30  9:11             ` Aditya Upadhyay
2017-07-04 21:31               ` Aditya Upadhyay
2017-07-04 21:56                 ` Aditya Upadhyay
2017-07-05  8:27                   ` Corinna Vinschen
2017-07-05  9:02                     ` Aditya Upadhyay
2017-07-05 12:40                       ` Corinna Vinschen
2022-11-08 18:31                       ` [newlib] Generally make all 'long double complex' methods available in <complex.h> Thomas Schwinge
2022-11-08 20:24                         ` Jeff Johnston
2017-06-29 13:47   ` Long double complex methods Joel Sherrill
  -- strict thread matches above, loose matches on Subject: below --
2017-06-28 13:53 Aditya Upadhyay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cff4633-2ef4-623b-e526-61c22e707d87@oarcorp.com \
    --to=joel.sherrill@oarcorp.com \
    --cc=aadit0402@gmail.com \
    --cc=newlib@sourceware.org \
    --cc=yselkowitz@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).