From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id ADDE13857C40 for ; Sat, 11 Jul 2020 15:16:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ADDE13857C40 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sebastian.huber@embedded-brains.de Received: from sslproxy03.your-server.de ([88.198.220.132]) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1juHF8-00029j-Er; Sat, 11 Jul 2020 17:16:46 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy03.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1juHF8-000X9J-Ab; Sat, 11 Jul 2020 17:16:46 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 8E7AC2A1610; Sat, 11 Jul 2020 17:17:12 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id j5SkHW866pAn; Sat, 11 Jul 2020 17:17:12 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 362552A165B; Sat, 11 Jul 2020 17:17:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qSzAgyZBGWe8; Sat, 11 Jul 2020 17:17:12 +0200 (CEST) Received: from shuber-nb-linux.eb.localhost (unknown [10.10.171.22]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 0D97E2A1610; Sat, 11 Jul 2020 17:17:12 +0200 (CEST) Subject: Re: [PATCH] Remove multiple defination error To: Eshan dhawan , newlib@sourceware.org References: <20200710224109.18663-1-eshandhawan51@gmail.com> From: Sebastian Huber Message-ID: <5de6b501-b0a2-68a6-b5b2-6fb487506f3b@embedded-brains.de> Date: Sat, 11 Jul 2020 17:16:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200710224109.18663-1-eshandhawan51@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.102.3/25870/Sat Jul 11 16:04:25 2020) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2020 15:16:50 -0000 On 11/07/2020 00:41, Eshan dhawan wrote: > Signed-off-by: Eshan dhawan > --- > newlib/libm/machine/arm/fenv-vfp.c | 7 ++++- > newlib/libm/machine/arm/fenv.c | 47 +++++++++++++++++++----------- > 2 files changed, 36 insertions(+), 18 deletions(-) What are the design goals of this implementation? Should it work with some sort of run time VFP detection? Should it select the support using builtin defines? I would use builtin defines only and then just use a single file.