From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 280DC3858D3C for ; Tue, 17 May 2022 10:13:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 280DC3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nquD9-000N5p-F1; Tue, 17 May 2022 12:13:51 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nquD9-000Iat-CT; Tue, 17 May 2022 12:13:51 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id EC5A84800FA; Tue, 17 May 2022 12:13:50 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id LtBRI-KrCqT4; Tue, 17 May 2022 12:13:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 966F34800A8; Tue, 17 May 2022 12:13:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MZixEHh440XP; Tue, 17 May 2022 12:13:50 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 5BAA14800A5; Tue, 17 May 2022 12:13:50 +0200 (CEST) Message-ID: <5e23bc41-1b1c-45fe-c6c0-a3cc59a10976@embedded-brains.de> Date: Tue, 17 May 2022 12:13:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 08/11] Add stdio_exit_handler() Content-Language: en-US To: Takashi Yano , newlib@sourceware.org References: <20220512121143.21473-1-matthew.joyce@embedded-brains.de> <20220512121143.21473-9-matthew.joyce@embedded-brains.de> <20220517173651.e40369e3e02925df1d0c8e32@nifty.ne.jp> From: Sebastian Huber In-Reply-To: <20220517173651.e40369e3e02925df1d0c8e32@nifty.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26544/Tue May 17 10:09:52 2022) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 10:13:54 -0000 On 17/05/2022 10:36, Takashi Yano wrote: [...] > After this commit, "ps | cat" outputs nothing in cygwin. However, > just "ps" and "ls | cat" works. "stdbuf -o 0 ps | cat" also works. >=20 > I am not sure this is the right thing, however, I found the following > patch solves the issue. It seems that initializing __stdio_exit_handler > is missing. >=20 > diff --git a/newlib/libc/stdio/findfp.c b/newlib/libc/stdio/findfp.c > index 19952d4e0..e759b5402 100644 > --- a/newlib/libc/stdio/findfp.c > +++ b/newlib/libc/stdio/findfp.c > @@ -63,6 +63,8 @@ struct _glue __sglue =3D {NULL, 3, &_GLOBAL_REENT->__= sf[0]}; > #endif > #endif > =20 > +static void stdio_exit_handler (void); > + > #if (defined (__OPTIMIZE_SIZE__) || defined (PREFER_SIZE_OVER_SPEED)) > _NOINLINE_STATIC void > #else > @@ -109,6 +111,11 @@ std (FILE *ptr, > if (__stextmode (ptr->_file)) > ptr->_flags |=3D __SCLE; > #endif > + > + if (__stdio_exit_handler =3D=3D NULL) { > + __sinit (_GLOBAL_REENT); > + __stdio_exit_handler =3D stdio_exit_handler; > + } > } > =20 > static inline void >=20 > Could you please have a look? Could you please check if this patch fixes the issue: https://sourceware.org/pipermail/newlib/2022/019713.html --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/