From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <newlib-return-14590-listarch-newlib=sources.redhat.com@sourceware.org>
Received: (qmail 110078 invoked by alias); 23 May 2017 15:16:44 -0000
Mailing-List: contact newlib-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <newlib.sourceware.org>
List-Subscribe: <mailto:newlib-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: newlib-owner@sourceware.org
Received: (qmail 109961 invoked by uid 89); 23 May 2017 15:16:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1362, H*Ad:U*howland
X-HELO: mail02.lgsinnovations.com
Received: from mail02.lgsinnovations.com (HELO mail02.lgsinnovations.com) (63.149.110.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 May 2017 15:16:42 +0000
Subject: Re: [PATCH] Use __BSD_VISIBLE for RTEMS <sys/_termios.h>
To: <newlib@sourceware.org>
References: <20170523082353.1793-1-sebastian.huber@embedded-brains.de>
From: Craig Howland <howland@LGSInnovations.com>
Message-ID: <63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com>
Date: Tue, 23 May 2017 15:16:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170523082353.1793-1-sebastian.huber@embedded-brains.de>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LGS-EX05.lgsdirect.com (135.22.48.227) To LGS-EX01.lgsdirect.com (135.22.77.164)
X-IsSubscribed: yes
X-SW-Source: 2017/txt/msg00352.txt.bz2

On 05/23/2017 04:23 AM, Sebastian Huber wrote:
> The Termios header <sys/_termios.h> used _POSIX_SOURCE directly to
> determine if a thing should be exposed to the user.  This circumvented
> the feature mechanisms of <sys/cdefs.h>.
Would you please explain why !_POSIX_SOURCE being replaced with __BSD_VISIBLE 
rather than, for example, !__POSIX_VISIBLE?  That is, you seem to not only be 
updating to sys/features.h macro names, but also shifting exactly how the gate 
is done.  (I'm not saying it is necessarily incorrect, just that the explanation 
does not mention the logic change.  The two are not logical opposites, so an 
implication is that the original gate of POSIX is not really the right one.)
Craig

>
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>   newlib/libc/sys/rtems/include/sys/_termios.h | 46 ++++++++++++++--------------
>   1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/newlib/libc/sys/rtems/include/sys/_termios.h b/newlib/libc/sys/rtems/include/sys/_termios.h
> index c8fe054da..2e7cc36c2 100644
> --- a/newlib/libc/sys/rtems/include/sys/_termios.h
> +++ b/newlib/libc/sys/rtems/include/sys/_termios.h
> @@ -42,15 +42,15 @@
>    */
>   #define	VEOF		0	/* ICANON */
>   #define	VEOL		1	/* ICANON */
> -#ifndef _POSIX_SOURCE
> +#if __BSD_VISIBLE ...