From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 9E2FD3858D33 for ; Mon, 16 May 2022 05:31:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E2FD3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqTKV-0004Yg-NM for newlib@sourceware.org; Mon, 16 May 2022 07:31:40 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqTKV-000RJ7-KZ for newlib@sourceware.org; Mon, 16 May 2022 07:31:39 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 59D794800D5 for ; Mon, 16 May 2022 07:31:39 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id BtUgOPyDb-CR for ; Mon, 16 May 2022 07:31:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 071AE480163 for ; Mon, 16 May 2022 07:31:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RqkCZTHyW7Hn for ; Mon, 16 May 2022 07:31:38 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id D243B4800D5 for ; Mon, 16 May 2022 07:31:38 +0200 (CEST) Message-ID: <69617006-7222-3141-54aa-d3eff3031a1f@embedded-brains.de> Date: Mon, 16 May 2022 07:31:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/7] Cygwin: Enable backward binary compatibility Content-Language: en-US To: newlib@sourceware.org References: <20220513134700.68563-1-sebastian.huber@embedded-brains.de> <20220513134700.68563-3-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26542/Sun May 15 10:03:23 2022) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 05:31:43 -0000 On 13/05/2022 22:15, Corinna Vinschen wrote: > On May 13 15:46, Sebastian Huber wrote: >> --- >> winsup/cygwin/include/cygwin/config.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/winsup/cygwin/include/cygwin/config.h b/winsup/cygwin/inc= lude/cygwin/config.h >> index 71a216fbd..2d410a2e7 100644 >> --- a/winsup/cygwin/include/cygwin/config.h >> +++ b/winsup/cygwin/include/cygwin/config.h >> @@ -80,6 +80,7 @@ extern inline struct _reent *__getreent (void) >> #define __TM_GMTOFF tm_gmtoff >> #define __TM_ZONE tm_zone >> #define _USE_LONG_TIME_T 1 >> +#define _NEWLIB_BACKWARD_BINARY_COMPAT 1 > Why? >=20 > AFAICS we don't expose _REENT to user space. In theory (knocking > on wood here), we shouldn't need _REENT binary compat. Ok good, I always thought the unused members in struct _reent were=20 mainly for Cygwin. Maybe the option should be named --enable-newlib-reent-binary-compat and=20 restricted to struct _reent. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/