Hi Jeff, Please find an updated patch which does not add extra noop code for single threaded mode in sys/lock.h as requested. Please note that it goes together with an updated version of the previous patch in the patch series [1]. [1] https://sourceware.org/ml/newlib/2017/msg00136.html Best regards, Thomas On 08/02/17 21:40, Jeff Johnston wrote: > Thanks Thomas, > > Regarding that other patch. I do not feel the extra noop code in sys/lock.h is warranted and > seems extraneous. I would prefer the users of the lock protect the usage as you have added. > > -- Jeff J. > > ----- Original Message ----- >> Hi Jeff, >> >> Please find an updated patch with consistent lock naming. Have you had a look >> at >> the patch prior to this one [1]? >> >> [1] https://sourceware.org/ml/newlib/2017/msg00112.html >> >> Thanks for your time. >> >> Best regards, >> >> Thomas >> >> On 07/02/17 21:36, Jeff Johnston wrote: >>> Hi Thomas, >>> >>> The patch is fine except for the lock.c inline docs still have references >>> to old lock names (prior to the ANSI_SYNOPSIS). >>> >>> -- Jeff J. >>> >>> ----- Original Message ----- >>>> Ooops, forgot about this. Please find an updated patch attached. >>>> >>>> Best regards, >>>> >>>> Thomas >>>> >>>> On 01/02/17 08:43, Freddie Chopin wrote: >>>>> Hi! >>>>> >>>>> With all relevant 3 patches applied the toolchain builds and works >>>>> fine, but the issue with HTML documentation still persists - at least >>>>> here on Arch Linux: >>>>> >>>>> --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >>>>> >>>>> make[2]: Entering directory '/home/freddie/bleeding-edge- >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc/syscalls' >>>>> for chapter in ; \ >>>>> do \ >>>>> cat /home/freddie/bleeding-edge-toolchain/sources/newlib- >>>>> 2.5.0/newlib/libc/syscalls/$chapter >> /home/freddie/bleeding-edge- >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc/tmp- >>>>> targetdep.texi ; \ >>>>> done >>>>> make[2]: Leaving directory '/home/freddie/bleeding-edge- >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc/syscalls' >>>>> cat /home/freddie/bleeding-edge-toolchain/sources/newlib- >>>>> 2.5.0/newlib/libc/sys.tex >>tmp-targetdep.texi >>>>> /bin/sh /home/freddie/bleeding-edge-toolchain/sources/newlib- >>>>> 2.5.0/newlib/libc/../../move-if-change tmp-targetdep.texi targetdep.tex >>>>> touch stmp-targetdep >>>>> rm -rf libc.htp >>>>> if makeinfo --split-size=5000000 --html -I /home/freddie/bleeding- >>>>> edge-toolchain/sources/newlib-2.5.0/newlib/libc \ >>>>> -o libc.htp /home/freddie/bleeding-edge-toolchain/sources/newlib- >>>>> 2.5.0/newlib/libc/libc.texinfo; \ >>>>> then \ >>>>> rm -rf libc.html; \ >>>>> if test ! -d libc.htp && test -d libc; then \ >>>>> mv libc libc.html; else mv libc.htp libc.html; fi; \ >>>>> else \ >>>>> if test ! -d libc.htp && test -d libc; then \ >>>>> rm -rf libc; else rm -Rf libc.htp libc.html; fi; \ >>>>> exit 1; \ >>>>> fi >>>>> ./targetdep.tex:1420: @menu reference to nonexistent node `lock' >>>>> stdlib/div.def:1: warning: node next `div' in menu `ecvtbuf' and in >>>>> sectioning `ecvt' differ >>>>> stdlib/efgcvt.def:1: warning: node next `ecvt' in menu `__env_lock' and >>>>> in sectioning `gcvt' differ >>>>> stdlib/efgcvt.def:1: warning: node prev `ecvt' in menu `ecvtbuf' and in >>>>> sectioning `div' differ >>>>> stdlib/efgcvt.def:60: warning: node next `gcvt' in menu `exit' and in >>>>> sectioning `ecvtbuf' differ >>>>> stdlib/efgcvt.def:60: warning: node prev `gcvt' in menu `__env_lock' >>>>> and in sectioning `ecvt' differ >>>>> stdlib/ecvtbuf.def:1: warning: node next `ecvtbuf' in menu `ecvt' and >>>>> in sectioning `__env_lock' differ >>>>> stdlib/ecvtbuf.def:1: warning: node prev `ecvtbuf' in menu `div' and in >>>>> sectioning `gcvt' differ >>>>> stdlib/envlock.def:1: warning: node next `__env_lock' in menu `gcvt' >>>>> and in sectioning `exit' differ >>>>> stdlib/envlock.def:1: warning: node prev `__env_lock' in menu `ecvt' >>>>> and in sectioning `ecvtbuf' differ >>>>> stdlib/exit.def:1: warning: node prev `exit' in menu `gcvt' and in >>>>> sectioning `__env_lock' differ >>>>> stdlib/mlock.def:1: warning: node next `__malloc_lock' in menu >>>>> `mbsrtowcs' and in sectioning `mblen' differ >>>>> stdlib/mblen.def:1: warning: node next `mblen' in menu `mbtowc' and in >>>>> sectioning `mbsrtowcs' differ >>>>> stdlib/mblen.def:1: warning: node prev `mblen' in menu `mbstowcs' and >>>>> in sectioning `__malloc_lock' differ >>>>> stdlib/mbsnrtowcs.def:1: warning: node prev `mbsrtowcs' in menu >>>>> `__malloc_lock' and in sectioning `mblen' differ >>>>> stdlib/mbstowcs.def:1: warning: node next `mbstowcs' in menu `mblen' >>>>> and in sectioning `mbtowc' differ >>>>> stdlib/mbtowc.def:1: warning: node prev `mbtowc' in menu `mblen' and in >>>>> sectioning `mbstowcs' differ >>>>> ctype/iswalpha.def:1: warning: node next `iswalpha' in menu `iswblank' >>>>> and in sectioning `iswcntrl' differ >>>>> ctype/iswcntrl.def:1: warning: node next `iswcntrl' in menu `iswdigit' >>>>> and in sectioning `iswblank' differ >>>>> ctype/iswcntrl.def:1: warning: node prev `iswcntrl' in menu `iswblank' >>>>> and in sectioning `iswalpha' differ >>>>> ctype/iswblank.def:1: warning: node next `iswblank' in menu `iswcntrl' >>>>> and in sectioning `iswdigit' differ >>>>> ctype/iswblank.def:1: warning: node prev `iswblank' in menu `iswalpha' >>>>> and in sectioning `iswcntrl' differ >>>>> ctype/iswdigit.def:1: warning: node prev `iswdigit' in menu `iswcntrl' >>>>> and in sectioning `iswblank' differ >>>>> misc/ffs.def:1: warning: node next `ffs' in menu `unctrl' and in >>>>> sectioning `__retarget_lock_init' differ >>>>> misc/lock.def:1: warning: unreferenced node `__retarget_lock_init' >>>>> misc/lock.def:1: warning: node `unctrl' is next for >>>>> `__retarget_lock_init' in sectioning but not in menu >>>>> misc/lock.def:1: warning: node `ffs' is prev for `__retarget_lock_init' >>>>> in sectioning but not in menu >>>>> misc/lock.def:1: warning: node `Misc' is up for `__retarget_lock_init' >>>>> in sectioning but not in menu >>>>> ./targetdep.tex:1414: node `Misc' lacks menu item for >>>>> `__retarget_lock_init' despite being its Up target >>>>> misc/unctrl.def:1: warning: node prev `unctrl' in menu `ffs' and in >>>>> sectioning `__retarget_lock_init' differ >>>>> reent/execr.def:19: warning: node next `_fork_r' in menu `_fstat_r' and >>>>> in sectioning `_wait_r' differ >>>>> reent/execr.def:36: warning: node next `_wait_r' in menu `_write_r' and >>>>> in sectioning `_fstat_r' differ >>>>> reent/execr.def:36: warning: node prev `_wait_r' in menu `_unlink_r' >>>>> and in sectioning `_fork_r' differ >>>>> reent/fstatr.def:1: warning: node next `_fstat_r' in menu `_getpid_r' >>>>> and in sectioning `_link_r' differ >>>>> reent/fstatr.def:1: warning: node prev `_fstat_r' in menu `_fork_r' and >>>>> in sectioning `_wait_r' differ >>>>> reent/linkr.def:1: warning: node prev `_link_r' in menu `_kill_r' and >>>>> in sectioning `_fstat_r' differ >>>>> reent/sbrkr.def:1: warning: node next `_sbrk_r' in menu `_stat_r' and >>>>> in sectioning `_kill_r' differ >>>>> reent/signalr.def:1: warning: node next `_kill_r' in menu `_link_r' and >>>>> in sectioning `_getpid_r' differ >>>>> reent/signalr.def:1: warning: node prev `_kill_r' in menu `_getpid_r' >>>>> and in sectioning `_sbrk_r' differ >>>>> reent/signalr.def:18: warning: node next `_getpid_r' in menu `_kill_r' >>>>> and in sectioning `_stat_r' differ >>>>> reent/signalr.def:18: warning: node prev `_getpid_r' in menu `_fstat_r' >>>>> and in sectioning `_kill_r' differ >>>>> reent/statr.def:1: warning: node prev `_stat_r' in menu `_sbrk_r' and >>>>> in sectioning `_getpid_r' differ >>>>> reent/unlinkr.def:1: warning: node next `_unlink_r' in menu `_wait_r' >>>>> and in sectioning `_write_r' differ >>>>> reent/writer.def:1: warning: node prev `_write_r' in menu `_wait_r' and >>>>> in sectioning `_unlink_r' differ >>>>> make[1]: *** [Makefile:561: libc.html] Error 1 >>>>> make[1]: Leaving directory '/home/freddie/bleeding-edge- >>>>> toolchain/buildNative/newlib-2.5.0/arm-none-eabi/newlib/libc' >>>>> make: *** [Makefile:680: install-html-recursive] Error 1 >>>>> >>>>> --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >8 --- >>>>> >>>>> Regards, >>>>> FCh >>>>> >>>> >>