From: Andrew Stubbs <ams@codesourcery.com>
To: <newlib@sourceware.org>
Subject: [PATCH] amdgcn: remove unnecessary scalar cache flush
Date: Fri, 20 Oct 2023 12:54:17 +0100 [thread overview]
Message-ID: <6d9dea6e-5595-477e-b049-6992623f13fc@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
Hi,
This patch is necessary to support AMD RDNA2 GPUs that don't have a
writable scalar cache. However, the write back isn't actually doing
anything useful on any GPU any more, so we can remove it.
Andrew
[-- Attachment #2: 231020-newlib-remove-s_dcache_wb.patch --]
[-- Type: text/plain, Size: 555 bytes --]
amdgcn: remove unnecessary scalar cache flush
The exit code isn't actually written via the scalar cache so the cache flush
is not actually needed.
diff --git a/newlib/libc/machine/amdgcn/exit-value.h b/newlib/libc/machine/amdgcn/exit-value.h
index 7aa2508bb..6b9d2411b 100644
--- a/newlib/libc/machine/amdgcn/exit-value.h
+++ b/newlib/libc/machine/amdgcn/exit-value.h
@@ -32,7 +32,6 @@ exit_with_int (int val)
*return_value = val;
/* Terminate the current kernel. */
- asm ("s_dcache_wb");
asm ("s_endpgm");
__builtin_unreachable ();
}
next reply other threads:[~2023-10-20 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 11:54 Andrew Stubbs [this message]
2023-10-31 11:26 ` Andrew Stubbs
2023-10-31 12:39 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d9dea6e-5595-477e-b049-6992623f13fc@codesourcery.com \
--to=ams@codesourcery.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).