From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122374 invoked by alias); 3 Sep 2019 15:28:22 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 122364 invoked by uid 89); 3 Sep 2019 15:28:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=shortly, represents X-HELO: esa4.mentor.iphmx.com Received: from esa4.mentor.iphmx.com (HELO esa4.mentor.iphmx.com) (68.232.137.252) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2019 15:28:21 +0000 IronPort-SDR: gg8hkcRiB4ArLYepc/pb5PvzE6P81LYVPMLgO3PM/9T+bWUFOJU10HcsX20OOaT9oMW0EaeLC+ /EzPIwkwC9vSGLz3BPMZRIMrjI3vB7gr/HYyEjYjnglEA5h9ws3rhlr19T3XVPiN9rKRXzhAc6 2CJ4Vz2TRzc6EtLzI9Mh8WAwtLgWdYzSFvhn+A020nmJHBBbSJ4+jiASyh3WxTOD2nWUYySYnJ YrsINSmyR1aknGj7rTFoTABi9gNzmZ9Rltn07z7I7ssWwYVQOBlbH93upVyqNmYc7oDrAAYxsp RFg= Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 03 Sep 2019 07:28:20 -0800 IronPort-SDR: XfX49WOkQdrWNvtDN/WPk4G6JK+vHlrIbALSEbP0TkupDiIKaSx+ft884gF3JpQm6pK4z36BWz IL7uYHEgGr8WPwfepQ/AHIakYPWEI8eVakmPxllzb24a6f3cXmZn8AgS4mzw06tWEh3XG0JZ8O 0Y+DFxjxYSX//XBcGMSWOs7jEdrOZEiU7OaRqexzNFSk3rf2EQsCBGHo4342K6N6Tt95rMqk69 vU5sJ8CrZXsBdyYamNt0W7N3bV9V6j1w4wZadsaCkw1X9Y4OY7zQ7k/h7m70prj7IHfRHfQsux meI= Subject: Re: [PATCH] Adjust nios2 and m68k semihosting for sys/stat.h changes. To: References: <20190901235201.10239-1-sandra@codesourcery.com> <20190902083617.GE4164@calimero.vinschen.de> From: Sandra Loosemore Message-ID: <6e48fc02-8ba9-2e15-ed31-0530f28e9fa5@codesourcery.com> Date: Tue, 03 Sep 2019 15:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190902083617.GE4164@calimero.vinschen.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: sandra@codesourcery.com X-SW-Source: 2019/txt/msg00535.txt.bz2 On 9/2/19 2:36 AM, Corinna Vinschen wrote: > Hi Sandra, > > On Sep 1 17:52, Sandra Loosemore wrote: >> Commit 72ff9acad2ab54e80a19ddaec0106065c817e3f6 caused st_atime, >> st_ctime, and st_mtime to be defined as macros. This collided with use of >> these identifiers as field names in struct gdb_stat (which represents >> the GDB RSP encoding of struct stat) in libgloss semihosting support for >> nios2 and m68k. This patch renames all the fields of struct gdb_stat. > > Commit d0651704411d fixes this by only renaming the st_Xtime fields > in struct gdb_stat to st_Xtim. Maybe that's an option for you, too? > Otherwise we have multiple different names in an otherwise identical > struct... OK, that works too. I'll post a V2 patch shortly. -Sandra