From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 247A2385E019 for ; Wed, 27 Sep 2023 01:18:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 247A2385E019 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1c1ff5b741cso90199395ad.2 for ; Tue, 26 Sep 2023 18:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1695777486; x=1696382286; darn=sourceware.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=KFm0TQB97ERThHuXe5x95gc9tcWbABoOb2gUFdySScQ=; b=NnQ1SzAriaobrexB9ZdMYiWOEw6dFG63MLkuztquBVEYFBh2WIHmvVi1Wqj5s+beAD rqtWqKxt8qjHhuvEohwbGbfaXC2cPeOyoyVJ8NExMrKWnJvYpBPaqxWQtctNy4oVxPmX 12kqGGb28yZ2MjDO87g8q6Nz8/yEZzi9hLeXKI/jhyDwmQsg9NbFsvl3fUmwufm0LXQD ZDusGQ/Pk7476IQWlYioK4kXfPTZZUwHBtDYrdU01SrYOWe6qrMkqH7b9cXXOCO4HuFV POz9Xt/S4D4tlcSkLh5gMJLRBjv597mOQugOWtWv+PpQTRn+sRt4LuiydR3dqr3nFG4p OKWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695777486; x=1696382286; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KFm0TQB97ERThHuXe5x95gc9tcWbABoOb2gUFdySScQ=; b=Xme1baRgczskOx+FW9kk7KFMfQsCvX0PiQmj9Wh89dVi+izLKRBFHlAwB0ZtxhDigN I5S1aPFEf7FxO/m95wnzA4sXjYYDvKl+UPBDX7bcy4nrrQ+PuPaICQvR2DfPWkk9Axsm s/lMdyEQ1Mo2d+Io1hQymdUkWp996hqHw9NQZLOApCIDY05EU/N3vpOx9Vn1H2Tc+lUw 9Y4MCcguQafV1Xy9OCzhyJShs7NNYw64AvyUeBgvWmpZPhdoMCvbMYMxNjGRdheql5iM pAe1zKK0OhJG0epycSgfCfij7umVWphbvLkOxodVl6/FsGUSdIyiX/RBFIBwDCgB9b8b 2aQQ== X-Gm-Message-State: AOJu0YzY+ZIwJNmg82CVUY9m6+KQR+lTtUoDtWepfm4vY8AmORooHYjf m+iWKHLVQrc7xy2c0EvI2BRfKA562dyi6bn8UVY0MMepqFW9e2Xw4c5+PIL8lwIkVjMqLFlqwwo uJcoJATUdFq5z31V6SvtHorRGZwnY2D2aCpepc02r1+ZANfHKnNERocS3OI0ckjvnqMxl8LXH X-Google-Smtp-Source: AGHT+IGo3zE8f48dazPfbiFVSxc8xvHa6lnAQ1w4X1FTh1+F7XYq7PwXILfoxXHr6c79L0+3K1RU2g== X-Received: by 2002:a17:902:e80a:b0:1c6:117b:7086 with SMTP id u10-20020a170902e80a00b001c6117b7086mr504750plg.5.1695777486337; Tue, 26 Sep 2023 18:18:06 -0700 (PDT) Received: from smtpclient.apple (36-238-49-72.dynamic-ip.hinet.net. [36.238.49.72]) by smtp.gmail.com with ESMTPSA id u15-20020a170902e5cf00b001c0af36dd64sm11659502plf.162.2023.09.26.18.18.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Sep 2023 18:18:05 -0700 (PDT) From: Hau Hsu Message-Id: <716D0EAD-E213-47E3-BD46-72987C27450B@sifive.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_F7E3B260-EE7E-48B4-B84A-C011C863F24B" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: [PATCH] RISC-V: Initialize the jvt CSR Date: Wed, 27 Sep 2023 09:17:53 +0800 In-Reply-To: Cc: Kito Cheng To: Newlib References: <20230925053657.24959-1-hau.hsu@sifive.com> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_F7E3B260-EE7E-48B4-B84A-C011C863F24B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 We found a potential ISA conflict when compiling the crt0.S with zcd extens= ion. We already have a new patch under testing. I'll send it after it is verified. Best, Hau Hsu Software Engineer hau.hsu@sifive.com > Kito Cheng =E6=96=BC 2023=E5=B9=B49=E6=9C=8825=E6= =97=A5 =E4=B8=8B=E5=8D=882:17 =E5=AF=AB=E9=81=93=EF=BC=9A >=20 > LGTM=20 >=20 > Hau Hsu via Newlib >= =E6=96=BC 2023=E5=B9=B49=E6=9C=8825=E6=97=A5 =E9=80=B1=E4=B8=80 06:37 =E5= =AF=AB=E9=81=93=EF=BC=9A >> We set symbol '__jvt_base$' as weak. So if the symbol is not set in the >> linker script, the address would be 0. We initialize jvt CSR only if >> the address is not 0. >>=20 >> psabi reference: >> https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/2d770815dc9a8b= 11e61ea1abd487cb25ee56ad5e/riscv-elf.adoc#table-jump-relaxation >> --- >> libgloss/riscv/crt0.S | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >>=20 >> diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S >> index 7a4e4e32c..4744ba039 100644 >> --- a/libgloss/riscv/crt0.S >> +++ b/libgloss/riscv/crt0.S >> @@ -26,6 +26,16 @@ _start: >> addi gp, gp, %pcrel_lo(1b) >> .option pop >>=20 >> + /* Initialize jvt CSR */ >> + .weak __jvt_base$ >> +.option push >> +.option arch, +zcmt, +zicsr >> + lla a0, __jvt_base$ >> + beqz a0, .Ljvt_init_end >> + csrw jvt, a0 >> +.Ljvt_init_end: >> +.option pop >> + >> # Clear the bss segment >> la a0, __bss_start >> la a2, _end >> --=20 >> 2.42.0 >>=20 --Apple-Mail=_F7E3B260-EE7E-48B4-B84A-C011C863F24B--