From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) by sourceware.org (Postfix) with ESMTPS id 957283857C59 for ; Thu, 3 Sep 2020 22:09:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 957283857C59 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=brian.inglis@systematicsw.ab.ca Received: from [192.168.1.104] ([24.64.172.44]) by shaw.ca with ESMTP id DxQFkpE0wYYpxDxQGkvHwt; Thu, 03 Sep 2020 16:09:36 -0600 X-Authority-Analysis: v=2.3 cv=OubUNx3t c=1 sm=1 tr=0 a=kiZT5GMN3KAWqtYcXc+/4Q==:117 a=kiZT5GMN3KAWqtYcXc+/4Q==:17 a=13zjGPudsaEWiJwPRgMA:9 a=7vT8eNxyAAAA:8 a=CCpqsmhAAAAA:8 a=zeAeT-1tAAAA:8 a=UV4Khlu7AAAA:8 a=DU0EyFXtAAAA:8 a=f3ymcQucS9WEkSEaVnQA:9 a=QEXdDO2ut3YA:10 a=jaguKSgamQ8A:10 a=5nLeOxEVN4QA:10 a=R49TJVHHVMtelTR2RU0A:9 a=FfaGCDsud1wA:10 a=Mzmg39azMnTNyelF985k:22 a=ul9cdbp4aOFLsgKbc677:22 a=q4mi67SYSo5Z2N87e4-W:22 a=g3FnbuhPxHiixQM06tVt:22 a=UCR5be5CC-YrbG9FbbB0:22 Reply-To: newlib@sourceware.org Subject: Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants To: newlib@sourceware.org References: <20200826182046.GR3272@calimero.vinschen.de> <87v9h5dy00.fsf@keithp.com> <20200827072411.GT3272@calimero.vinschen.de> <87pn7cdnns.fsf@keithp.com> <20200828081951.GD3272@calimero.vinschen.de> <20200828083447.GE3272@calimero.vinschen.de> <3f611061-d504-dc26-29cc-dccffbe008a3@gtd-gmbh.de> <871rjlcsy0.fsf@keithp.com> <20200902080345.GF4127@calimero.vinschen.de> <87lfhrap9h.fsf@keithp.com> <20200903080441.GM4127@calimero.vinschen.de> <79b6e41b-5697-6c0b-5d11-59407b1e0ec8@SystematicSw.ab.ca> <87mu268sdv.fsf@keithp.com> From: Brian Inglis Autocrypt: addr=Brian.Inglis@SystematicSw.ab.ca; prefer-encrypt=mutual; keydata= mDMEXopx8xYJKwYBBAHaRw8BAQdAnCK0qv/xwUCCZQoA9BHRYpstERrspfT0NkUWQVuoePa0 LkJyaWFuIEluZ2xpcyA8QnJpYW4uSW5nbGlzQFN5c3RlbWF0aWNTdy5hYi5jYT6IlgQTFggA PhYhBMM5/lbU970GBS2bZB62lxu92I8YBQJeinHzAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQW AgMBAh4BAheAAAoJEB62lxu92I8Y0ioBAI8xrggNxziAVmr+Xm6nnyjoujMqWcq3oEhlYGAO WacZAQDFtdDx2koSVSoOmfaOyRTbIWSf9/Cjai29060fsmdsDLg4BF6KcfMSCisGAQQBl1UB BQEBB0Awv8kHI2PaEgViDqzbnoe8B9KMHoBZLS92HdC7ZPh8HQMBCAeIfgQYFggAJhYhBMM5 /lbU970GBS2bZB62lxu92I8YBQJeinHzAhsMBQkJZgGAAAoJEB62lxu92I8YZwUBAJw/74rF IyaSsGI7ewCdCy88Lce/kdwX7zGwid+f8NZ3AQC/ezTFFi5obXnyMxZJN464nPXiggtT9gN5 RSyTY8X+AQ== Organization: Systematic Software Message-ID: <7a4384ad-b698-84bf-a0bb-ef796dffdb99@SystematicSw.ab.ca> Date: Thu, 3 Sep 2020 16:09:34 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87mu268sdv.fsf@keithp.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FMuTMOKTqH0Y1E6UGLUiCLpRJ3jwkxhvm" X-CMAE-Envelope: MS4wfMp3ViI01ndAYcS8pQTj+YxxsRXlGMsSs9oohdVkWf9qu3jf6+nthfsIoq8+AeqPdr2emwd5yQwFMFp0IDy4TMvNzjcKxNnzVCBbbGLTVNXVPEv31PJW iFXIS//prg1WtZVANIl9kQ9yHD8joTJH89c9KkV6JQ9uKb7YYh6+vZs/Sf4SDXbXznFMJ5Hhp2M6HQ== X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2020 22:09:39 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FMuTMOKTqH0Y1E6UGLUiCLpRJ3jwkxhvm Content-Type: multipart/mixed; boundary="1IVpmx0n8GFb7pALq1yXoT1VTNgyLfXn0" --1IVpmx0n8GFb7pALq1yXoT1VTNgyLfXn0 Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: quoted-printable On 2020-09-03 15:25, Keith Packard wrote: > Brian Inglis writes: >=20 >>>> Then tell us what you want gamma and gamma_r to do for Cygwin. >>> >>> I did: https://sourceware.org/pipermail/newlib/2020/017946.html >=20 > Oops! I appear to have missed that mail. >=20 >> FYI docs/spec: >> https://sca.uwaterloo.ca/coldfire/gcc-doc/docs/libm_21.html#SEC21 >> http://www.ece.ualberta.ca/~cmpe401/docs/coldfire/libm.pdf#page=3D20 >> https://ftp.rtems.org/pub/rtems/docs/3.2.0/libm-3.2.0.ps - see p.18 >=20 > That's quite helpful actually and says that cygwin's gamma matches > glibc, which makes the change from 2002 just a bug. Switching gamma bac= k > to lgamma is quite simple. >=20 > Here's what I did: >=20 > 1. Remove the gamma* function implementations and make them explicit > aliases to lgamma*. >=20 > 2. Change the name of the __ieee754_gamma* functions to > __ieee754_tgamma* and remove the _ieee754_gamma*_r variants >=20 > I've sent a patch doing this to the list. I don't think you can "remove the _ieee754_gamma*_r variants" as I believ= e Cygwin has to keep these: $ nm --defined-only --extern-only /bin/cygwin1.dll | fgrep gamma 00000001801a76c0 T __ieee754_gamma_r 00000001801a7f90 T __ieee754_gammaf_r 00000001801a76e0 T __ieee754_lgamma_r 00000001801a7fb0 T __ieee754_lgammaf_r 000000018018a8c0 T __lgammal_r 000000018018ce10 T __tgammal_r 000000018019f690 T gamma 00000001801a0a40 T gamma_r 00000001801a0200 T gammaf 00000001801a0b80 T gammaf_r 000000018019fb00 T lgamma 00000001801a0ae0 T lgamma_r 00000001801a0660 T lgammaf 00000001801a0c20 T lgammaf_r 000000018018ae10 T lgammal 000000018018ae90 T lgammal_r 000000018019fe50 T tgamma 00000001801a0970 T tgammaf 000000018018d290 T tgammal although I don't have the Windows utilities to check the exports directly= =2E --=20 Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in IEC units and prefixes, physical quantities in SI.] --1IVpmx0n8GFb7pALq1yXoT1VTNgyLfXn0-- --FMuTMOKTqH0Y1E6UGLUiCLpRJ3jwkxhvm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTDOf5W1Pe9BgUtm2QetpcbvdiPGAUCX1FpngAKCRAetpcbvdiP GBUmAP9T/LxXSri3h+cB6vZr8o5WkjWzW+3rx7+wncujcS+r5gD/bNb2b7Gk0NUG EMBwGKYyYnnfl7raSYT4mZ/IakZdawM= =tKA1 -----END PGP SIGNATURE----- --FMuTMOKTqH0Y1E6UGLUiCLpRJ3jwkxhvm--