From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id C9ED53857C5F for ; Wed, 29 Jul 2020 05:07:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9ED53857C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sebastian.huber@embedded-brains.de Received: from sslproxy05.your-server.de ([78.46.172.2]) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k0eJG-00071N-0n; Wed, 29 Jul 2020 07:07:22 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1k0eJF-000ExO-Tv; Wed, 29 Jul 2020 07:07:21 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 478512A1610; Wed, 29 Jul 2020 07:07:30 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6T074ejSGhLP; Wed, 29 Jul 2020 07:07:29 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id C28FF2A1681; Wed, 29 Jul 2020 07:07:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0pt0EJoz1uT2; Wed, 29 Jul 2020 07:07:29 +0200 (CEST) Received: from shuber-nb-linux.eb.localhost (unknown [10.10.171.22]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 986FA2A1610; Wed, 29 Jul 2020 07:07:29 +0200 (CEST) Subject: Re: [PATCH 0/2] Fix fenv support for ARM To: newlib@sourceware.org References: <20200719110112.14255-1-sebastian.huber@embedded-brains.de> <20200727080729.GC4206@calimero.vinschen.de> From: Sebastian Huber Message-ID: <7ac0214f-6c16-b6ff-3b46-074f8ade9a70@embedded-brains.de> Date: Wed, 29 Jul 2020 07:07:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727080729.GC4206@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.102.3/25887/Tue Jul 28 17:44:20 2020) X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2020 05:07:26 -0000 On 27/07/2020 10:07, Corinna Vinschen via Newlib wrote: > On Jul 23 07:13, Sebastian Huber wrote: >> On 19/07/2020 13:01, Sebastian Huber wrote: >> >>> This patch set addresses some issues which popped up while building Newlib for >>> ARM with GCC 10 which enables -fno-common by default. >>> >>> Eshan dhawan (1): >>> arm: Fix fenv support >>> >>> Sebastian Huber (1): >>> arm: Remove superfluous fenv stub files >> I just noticed that the stub files I removed are not superfluous. Its seems >> they are necessary to somehow overwrite the default implementations in: >> >> newlib/libm/fenv >> >> There seems to be some build system magic involved here. I guess we have to >> split up fenv.c and move all the functions to individual files matching the >> ones in newlib/libm/fenv? > Splitting is probably better. When you created and tested a new patchset, > feel free to push it. I checked in two patches: https://sourceware.org/git?p=newlib-cygwin.git;a=commit;h=b7a6e02dc6a5289bfa489c0e7b6539abd281e2c6 https://sourceware.org/git?p=newlib-cygwin.git;a=commit;h=3ca43259686187e081d317e2b406724a849c9d7b I hope the ARM fenv support issues are now fixed.