From: Alexey Lapshin <alexey.lapshin@espressif.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: Alexey Gerenkov <alexey.gerenkov@espressif.com>,
Ivan Grokhotkov <ivan@espressif.com>,
Anton Maklakov <anton.maklakov@espressif.com>
Subject: [PATCH] libc: fix fropen/fwopen compile warnings
Date: Wed, 7 Dec 2022 10:59:23 +0000 [thread overview]
Message-ID: <7df8cf98f3652657eb0ff11565a8597af4e1e004.camel@espressif.com> (raw)
This patch fixes warnings that appears when compiling:
#define fwopen(__cookie,__fn) funopen(__cookie, (int (*)())0, __fn,
(fpos_t (*)())0, (int (*)())0)
Expands to:
funopen(__null, (int (*)())0, &app_printf, (fpos_t (*)())0, (int
(*)())0)
argument of type "int (*)()" is incompatible with parameter of type
"int (*)(void *__cookie, char *__buf, int __n)"C/C++(167)
invalid conversion from 'fpos_t (*)()' {aka 'long int (*)()'} to
'fpos_t (*)(void*, fpos_t, int)' {aka 'long int (*)(void*,
Discussion is here:
https://github.com/espressif/arduino-esp32/issues/7407
---
newlib/libc/include/stdio.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/newlib/libc/include/stdio.h b/newlib/libc/include/stdio.h
index ab18806e3..08c1ffe45 100644
--- a/newlib/libc/include/stdio.h
+++ b/newlib/libc/include/stdio.h
@@ -614,10 +614,8 @@ FILE *_funopen_r (struct _reent *, const
void *__cookie,
int (*__closefn)(void *__cookie));
# endif /* !__LARGE64_FILES */
-# define fropen(__cookie, __fn) funopen(__cookie, __fn, (int
(*)())0, \
- (fpos_t (*)())0, (int
(*)())0)
-# define fwopen(__cookie, __fn) funopen(__cookie, (int (*)())0,
__fn, \
- (fpos_t (*)())0, (int
(*)())0)
+# define fropen(__cookie, __fn) funopen(__cookie, __fn, NULL,
NULL, NULL)
+# define fwopen(__cookie, __fn) funopen(__cookie, NULL, __fn,
NULL, NULL)
#endif /* __BSD_VISIBLE */
#if __GNU_VISIBLE
--
2.34.1
next reply other threads:[~2022-12-07 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 10:59 Alexey Lapshin [this message]
2022-12-07 12:23 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7df8cf98f3652657eb0ff11565a8597af4e1e004.camel@espressif.com \
--to=alexey.lapshin@espressif.com \
--cc=alexey.gerenkov@espressif.com \
--cc=anton.maklakov@espressif.com \
--cc=ivan@espressif.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).