From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 876 invoked by alias); 15 Dec 2014 20:52:01 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 864 invoked by uid 89); 15 Dec 2014 20:52:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx6-phx2.redhat.com Received: from mx6-phx2.redhat.com (HELO mx6-phx2.redhat.com) (209.132.183.39) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Dec 2014 20:51:59 +0000 Received: from zmail13.collab.prod.int.phx2.redhat.com (zmail13.collab.prod.int.phx2.redhat.com [10.5.83.15]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBFKpul5027678; Mon, 15 Dec 2014 15:51:56 -0500 Date: Mon, 15 Dec 2014 20:52:00 -0000 From: Jeff Johnston To: Jonathan Roelofs Cc: Newlib Mailing List Message-ID: <834394271.1729377.1418676716395.JavaMail.zimbra@redhat.com> In-Reply-To: <5488BF5C.4040200@codesourcery.com> References: <5421D931.905@codesourcery.com> <5487087D.60109@codesourcery.com> <360451599.20515843.1418163322593.JavaMail.zimbra@redhat.com> <548779F0.5090308@codesourcery.com> <1019993084.20539736.1418168198498.JavaMail.zimbra@redhat.com> <54889EC2.6000209@codesourcery.com> <5488BF5C.4040200@codesourcery.com> Subject: Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014/txt/msg00741.txt.bz2 Patch committed. -- Jeff J. ----- Original Message ----- From: "Jonathan Roelofs" To: "JF Bastien" , "Jeff Johnston" , "Craig Howland" Sent: Wednesday, December 10, 2014 4:47:08 PM Subject: Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL systems Apparently patch management is hard. Here's what I meant to send. Jon On 12/10/14 2:43 PM, JF Bastien wrote: > FORCE_EVAL is still in newlib/libm/common/nexttowardf.c? > > On Wed, Dec 10, 2014 at 11:28 AM, Jonathan Roelofs < > jonathan@codesourcery.com> wrote: > >> Drop the FORCE_EVAL macro, and wrap nexttowardf in _LDBL_EQ_DBL as per >> Craig's suggestion. >> >> Jon >> >> >> On 12/9/14 4:36 PM, Jeff Johnston wrote: >> >>> ----- Original Message ----- >>> >>>> From: "Jonathan Roelofs" >>>> To: "Jeff Johnston" >>>> Cc: "JF Bastien" , "Craig Howland" < >>>> howland@lgsinnovations.com>, newlib@sourceware.org >>>> Sent: Tuesday, December 9, 2014 5:38:40 PM >>>> Subject: Re: [libcxx+newlib] nexttoward{f,l,} shims for _LDBL_EQ_DBL >>>> systems >>>> >>>> >>>> >>>> On 12/9/14 3:15 PM, Jeff Johnston wrote: >>>> >>>>> Just a couple comments. >>>>> >>>>> 1. The FORCE_EVAL macro looks for >>>>> double or long double, even though it is only used for floats in >>>>> nexttowardf >>>>> By any chance was this macro in a header that you brought into >>>>> the code and if so, would it not be better to put the general-purpose >>>>> macro in local.h? Otherwise, I would just suggest removing the >>>>> double/long >>>>> double >>>>> parts that are extraneous in this instance and clutter the code. >>>>> >>>> FORCE_EVAL did come from a header, and yeah, local.h probably is a better >>>> place >>>> for it. >>>> >>>>> >>>>> If you took it from a header, please confirm the license was the same as >>>>> nexttowardf() which is fine btw for inclusion into newlib. >>>>> >>>> That header has this at the top of it: >>>> >>>> * ==================================================== >>>> * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. >>>> * >>>> * Developed at SunPro, a Sun Microsystems, Inc. business. >>>> * Permission to use, copy, modify, and distribute this >>>> * software is freely granted, provided that this notice >>>> * is preserved. >>>> * ==================================================== >>>> >>>> >>> In that case, just do the volatile assignment manually instead of adding a >>> second license. >>> >>> >>>>> 2. You have put the nexttowardf function prototype in the math.h section >>>>> where >>>>> _LDBL_EQ_DOUBLE is true but the code itself doesn't use the flag as >>>>> it doesn't rely on long double internals. >>>>> >>>> Oh, right. Good point. I'll take it out of _LDBL_EQ_DOUBLE. >>>> >>>> Jon >>>> >>>>> >>>>> -- Jeff J. >>>>> >>>>> >>>> -- >>>> Jon Roelofs >>>> jonathan@codesourcery.com >>>> CodeSourcery / Mentor Embedded >>>> >>>> >> -- >> Jon Roelofs >> jonathan@codesourcery.com >> CodeSourcery / Mentor Embedded >> > -- Jon Roelofs jonathan@codesourcery.com CodeSourcery / Mentor Embedded