public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: jdoubleu <hi@jdoubleu.de>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] add tests for tzset(3)
Date: Mon, 11 Apr 2022 13:17:16 +0200	[thread overview]
Message-ID: <836b0ac6-5e3a-03ca-d696-16adda6554a8@jdoubleu.de> (raw)
In-Reply-To: <YlNFZ+JY0OxY+6d3@kendros>

[-- Attachment #1: Type: text/plain, Size: 1969 bytes --]

Hi,

looks like I'm running the testsuite against glibc and not newlib (for 
target x86_64-pc-linux-gnu). I'm not even sure whether there's a backend 
for linux.

I'm currently trying to run only the tzset code against the test vectors 
(like Brian Inglis did[1]).

At least it show, that the newlib implementation differs from glibc. 
Maybe the test case is flawed and it should indeed fail.

> 6:20:12 is the timezone string of the previous test case, whose tzset
> call was successful. Looking at the current code, this is expected
> behaviour.

Okay. Looks like the condition[2] fails. The question is, which part of 
it does?

I've appended a patch, which prints all variables when the condition 
fails. Could you please apply the patch and then recompile and re-run 
the tests again?

I've previously noticed something with the sscanf format[3].

> Perhaps TZ should be reset to UTC before the bail out?

I don't think the implementation should fall back to UTC whenever 
parsing failed. It apparently doesn't in glibc. I'm not sure if the 
behavior is specified somewhere.

Maybe resetting it before each test case is a good idea, though. That 
makes it clearer, why the test case failed.

> With that chunk removed, as shown below:
>     {"3:33:33",               IN_SECONDS(3, 33, 33),   NO_TIME},                 // truncates the name (17 + 1)
> I still get:
>   Assertion failed! Expected 1647906533 to equal 1647916532. winter time, timezone = "3:33:33"

My bad; "3:33:33" isn't a valid timezone string. It has to be prefixed 
by a name e.g. "MESZ" or "<+00>", as you tried. That explains why it is 
also failing.


Thanks for your effort so far!


[1]: https://sourceware.org/pipermail/newlib/2022/019529.html
[2]: 
https://sourceware.org/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/time/tzset_r.c;h=9cb30b188f989f65ec9eb6417f5d74020f8c72e9;hb=HEAD#l57
[3]: https://sourceware.org/pipermail/newlib/2022/019535.html


Cheers
---
🙎🏻‍♂️ jdoubleu

[-- Attachment #2: 0001-debug-print-condition-values-of-tz-string-name-parsi.patch --]
[-- Type: text/plain, Size: 1116 bytes --]

From 8c698dc63f765d4a5b3a49a25850c1738279d68d Mon Sep 17 00:00:00 2001
From: jdoubleu <hi@jdoubleu.de>
Date: Mon, 11 Apr 2022 13:10:38 +0200
Subject: [PATCH] debug print condition values of tz string name parsing

---
 newlib/libc/time/tzset_r.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/time/tzset_r.c b/newlib/libc/time/tzset_r.c
index 9cb30b188..e20a32a62 100644
--- a/newlib/libc/time/tzset_r.c
+++ b/newlib/libc/time/tzset_r.c
@@ -54,9 +54,11 @@ _tzset_unlocked_r (struct _reent *reent_ptr)
       ++tzenv;
 
       /* quit if no items, too few or too many chars, or no close quote '>' */
-      if (sscanf (tzenv, "%10[-+0-9A-Za-z]%n", __tzname_std, &n) <= 0
-		|| n < TZNAME_MIN || TZNAME_MAX < n || '>' != tzenv[n])
+      int res = sscanf (tzenv, "%10[-+0-9A-Za-z]%n", __tzname_std, &n);
+      if (res <= 0 || n < TZNAME_MIN || TZNAME_MAX < n || '>' != tzenv[n]) {
+        printf("parsing name: tzenv=\"%s\", res=%d, n=%d, tzenv[n] = %c\n", tzenv, res, n, tzenv[n]);
         return;
+      }
 
       ++tzenv;	/* bump for close quote '>' */
     }
-- 
2.35.1


  reply	other threads:[~2022-04-11 11:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 15:58 jdoubleu
2022-04-08 21:21 ` Jeff Johnston
2022-04-10  8:43 ` Dimitar Dimitrov
2022-04-10 17:55   ` jdoubleu
2022-04-10 21:00     ` Dimitar Dimitrov
2022-04-11 11:17       ` jdoubleu [this message]
2022-04-11 17:27         ` Dimitar Dimitrov
2022-04-12 11:19           ` jdoubleu
2022-04-12 18:33             ` Brian Inglis
2022-04-07 23:34               ` [PATCH v2 0/2] add tzset/_r POSIX angle bracket <> support in TZ env var Brian Inglis
2022-04-07 23:34                 ` [PATCH v2 1/2] newlib/libc/time/tzset.c: doc update POSIX angle bracket <> support Brian Inglis
2022-04-07 23:34                 ` [PATCH v2 2/2] newlib/libc/time/tzset_r.c(_tzset_unlocked_r): " Brian Inglis
2022-04-08 19:11                 ` [PATCH v2 0/2] add tzset/_r POSIX angle bracket <> support in TZ env var Jeff Johnston
2022-04-13 17:53                 ` [PATCH] add tests for tzset(3) Brian Inglis
2022-04-13 20:33                   ` Jeff Johnston
2022-04-13 22:19                     ` Brian Inglis
2022-04-14  8:59                       ` jdoubleu
2022-04-14 16:31                         ` Brian Inglis
2022-04-14 19:23                           ` Jeff Johnston
2022-04-15 10:10                             ` jdoubleu
2022-04-27 19:30                               ` Jeff Johnston
2022-05-14 14:39                         ` jdoubleu
2022-05-16 16:05                           ` Dimitar Dimitrov
2022-05-16 17:38                             ` Jeff Johnston
2022-05-17  8:45                           ` [PATCH] update tzset tests jdoubleu
2022-05-18 18:48                             ` Dimitar Dimitrov
2022-05-18 20:56                               ` Keith Packard
2022-05-19  8:47                                 ` jdoubleu
2022-05-22  9:51                                   ` [PATCH v2] " jdoubleu
2022-05-22 21:02                                     ` Dimitar Dimitrov
2022-05-27 15:46                                       ` Jeff Johnston
2022-04-13 22:21               ` [PATCH] add tests for tzset(3) Brian Inglis
2022-04-29 15:46 Jeff Johnston
2022-05-12 18:35 ` jdoubleu
2022-05-16 17:49   ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=836b0ac6-5e3a-03ca-d696-16adda6554a8@jdoubleu.de \
    --to=hi@jdoubleu.de \
    --cc=dimitar@dinux.eu \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).