From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 7D8783858009 for ; Sun, 20 Mar 2022 05:07:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D8783858009 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42c.google.com with SMTP id s42so12952778pfg.0 for ; Sat, 19 Mar 2022 22:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=Xhin8LElBAC90Z7tJWw5M64xdkdAY6UJLb2WUpypklQ=; b=nFv8xcxExC1PenYaxvjzS6OHaL5VC1p6pAUN1NBh8vwxYi4QvbjJzFJrJi7WdJY1dt a7RQXJ5kxLEL5Ka81ljM7/rq8wPU7Rruozcjdr/R6NVnPYJ3NDD2fnUpmJuahy55AxHF uUndFBr7u5eG3zJMlLty86OKFl5LomxHQmVqeUIHnItcyrCTkiRX3GDblRCNTzkvFPb6 w/8T+S1RWabRXmaM2nkFGbPxgLuXo3mqDMmTd8+GzQg56wsFos5mIXCPZNdSXzjxCFrF +8ZvWyRrIdg4wupj5bhhObttZOeMX9fedzWDU36hO6IjBtwCKUq5wN740uLbGiCZvSc7 LEhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Xhin8LElBAC90Z7tJWw5M64xdkdAY6UJLb2WUpypklQ=; b=ZPwMKq1riSxCwnL0wYUDz8navR3qUgeYX45ko/gJrxDBDmWig+HQOFuB6ju92lYNKL VK9thcm6kUmyYRHbrkdZiQsa6qRJ6g/4eVZpswZTcoNQr24JOQ2C76p4y9WXzHwvXCOg 3rQ87pJs5QZONjEQUUuIz/albgnWAMWNM9V8AwA8Lac3KtTKMxw2jhh6itOokBBikfcq 90cDcFlIfzxd7xokAXJ68lAyvpZAJYnY/5MEcA/X9cvv6glFKGiXlmfGJ3SJLWCpdWtL /GO4yhzfdmgLopCHEFXUOqs4SoySE/DKiTvQfUYFRSMNUH+/NzfD9zU4xWGpEgwqk2s1 FbYQ== X-Gm-Message-State: AOAM533wAjXewOJXafIcOsqiTZKBw+ABoWA8oErBgWeYr/um1eJi7+fw odRw6LYlOma6dXYQUhzZM6cS3bm79STY/w== X-Google-Smtp-Source: ABdhPJwTiMQ6L/27+SHjo4OSARHXb/VQ3fLh370p3nbQmgOOwOCcFtHhX59ModlrUCGLuhvgmvo3Hw== X-Received: by 2002:a05:6a00:1a90:b0:4fa:9400:afaf with SMTP id e16-20020a056a001a9000b004fa9400afafmr1060391pfv.82.1647752860113; Sat, 19 Mar 2022 22:07:40 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id i6-20020a633c46000000b003817d623f72sm11455172pgn.24.2022.03.19.22.07.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Mar 2022 22:07:39 -0700 (PDT) Message-ID: <86afc417-b274-cfca-c6aa-36cef7bde230@gmail.com> Date: Sat, 19 Mar 2022 23:07:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Avoid using common symbols in v850 libgloss Content-Language: en-US To: Newlib References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2022 05:07:42 -0000 On 3/19/2022 7:20 PM, Mike Frysinger wrote: > On 09 Feb 2022 18:58, Jeff Law wrote: >> I've had this lying around for probably a year or two at this point. >> It just changes all the instance of "errno" from a common symbol to an >> extern.  I can't offhand recall where the actual definition is, but it >> certainly exists in the generic code. >> >> --- a/libgloss/v850/_exit.c >> +++ b/libgloss/v850/_exit.c >> @@ -3,7 +3,7 @@ >> #include >> #include "sys/syscall.h" >> >> -int errno; >> +extern int errno; > why not just include errno.h ? using `extern int errno;` is so pre-2000 :p. :-0  I think i wrote it in the late 90s, so you're spot on. In reality it didn't even cross my mind.   No objections if it gets changed, though ideally I'll never hack v850 newlib again :-) jeff