From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by sourceware.org (Postfix) with ESMTPS id 37017385780E for ; Fri, 4 Sep 2020 04:52:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 37017385780E Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 172643F2D70D; Thu, 3 Sep 2020 21:52:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hn-b7nzzSqmc; Thu, 3 Sep 2020 21:51:59 -0700 (PDT) Received: from keithp.com (koto.keithp.com [10.0.0.2]) by elaine.keithp.com (Postfix) with ESMTPSA id 9DBFB3F2D70C; Thu, 3 Sep 2020 21:51:59 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1000) id 6A18D1582201; Thu, 3 Sep 2020 21:51:59 -0700 (PDT) From: "Keith Packard" To: Kito Cheng Cc: Newlib Subject: Re: [PATCH 0/2] libm/riscv: Fixing machine-specific fma/sqrt In-Reply-To: References: <20200903205433.2108717-1-keithp@keithp.com> Date: Thu, 03 Sep 2020 21:51:59 -0700 Message-ID: <87blim87ps.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 04:52:02 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kito Cheng writes: > Hi Keith: > > Thanks! and it's LGTM. > > Seems like those issues can't be captured by GCC testsuite, I should > add more tests to my regular patch review test list :) I've got a bunch of errno/exception tests that I've written for picolibc that catch missing errno values, which is what the sqrt difference would have caused. As for fma, you'd have to construct a test that checked for the difference between a true fma and (a*b)+c that the general code in newlib currently uses. I've now added a test for picolibc to make sure there aren't duplicate symbols in libm.a and libc.a, but that doesn't make sure you get the *right* symbols ... =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAl9Rx+8ACgkQ2yIaaQAA ABEuGhAAtX4U7XorZBFsETXZsP8zUCdBV9vouVxMIm7nOny+Uka+xh0MRUGEvxOo VXhiR0lXJHtrLUxyryCKoXzUwQjdt7moHbv8m6ND77QfO9nBFxK6IWB8WmyhXWcM PBTSnweSFP3l+l8x6JSHi12cr4LNLHEgZn5zB5PCSa26C8T3aN0IdYBaBiYB5Tk3 htyGoU/S9pq7MfgHnx9VRrzoXoYmjLz8PuqERjeewHRf5nsQl9WK1+17G1wSaCFa gflyhO4oTxmNbIPrIgsRiwgyEnVln3r3qYOxcuWBuucWLx/DQ0+4CP3eGWi5AoSZ mnQUSLId8KjM3/X5t1Qm7SajaDcQ6m1UnnkK2PK2+x/1D5592NoexU2aE3DZ1Ti4 FWRdcREoDUjpeMDskFDEoD9DwSq/QGtdRdZPbNJO2ywL+n/ukxmOuvLrHrvKi/vv iDYzoqBknetR4kAAd7V+hJQoCRGttdePQOvAGlJNLes/A/weMjjjPMBuBW8ZcPcJ Ugrmm55lDZEfjqEDrD2AphQpyHm+jr7SEvq3FD5djL8xxHZ60nkYqnx9OHl6+JIM ayAt9KiJWG080vMSUwdJVHKJZfcRVP+frO783DzfmgaFjiWsvlHlbNHWzhgjcnKH /NvEzXLL7iG8QOj49dwu7x/AbtWUMmU74sJBEM+zGjLaah/LwUs= =WUUI -----END PGP SIGNATURE----- --=-=-=--