From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by sourceware.org (Postfix) with ESMTPS id 65BC73858C60 for ; Tue, 9 Nov 2021 03:15:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 65BC73858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=keithp.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=keithp.com Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id E5AC53F31292; Mon, 8 Nov 2021 19:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1636427734; bh=0ha08+lr++XQfRvT0UxjjC+fNyOazqGGcMRgHyR6siE=; h=From:To:Subject:In-Reply-To:References:Date:From; b=hTe36FZCYtBxJ5Iyvj18yUQue+YEpKQle0kI4kBVrhjGsZUCxHZC4Hq202VsAUujY JopsyBz5ez9Do8JjmK3w6ViFrfJ6RRx7xCTp2aXZ0RBpaDmmFUXKRXw0X/sSCGmUJ3 JUf3Hn5gHr6FYn2tPFaN3dG3++IgnJmicAcelRwWwpkR/q1wCwPDTC5TZPthO+Qybx EzqjUahy+95HG9yyXp17apPWr0UiIPr9hKZz5oyhnECZi6EDNVLa8tgaU+ISvYRL4v s5KpBzMoO+GXnwnH7vbVyCFtTqYGK4vkebhgTaevV7ccErscnTZZVKoPX4/yDrvEnX KOijV+VEL8/EQ== X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id r4kxltHOsmGf; Mon, 8 Nov 2021 19:15:32 -0800 (PST) Received: from keithp.com (koto.keithp.com [192.168.11.2]) by elaine.keithp.com (Postfix) with ESMTPSA id 2CBCD3F31291; Mon, 8 Nov 2021 19:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1636427732; bh=0ha08+lr++XQfRvT0UxjjC+fNyOazqGGcMRgHyR6siE=; h=From:To:Subject:In-Reply-To:References:Date:From; b=fpsHEi5RucnbdjaZFxE9bg/3BSoBCfr2h05D3VQYm2Vigr1x0mdHgaW0SlKfUWr8k cAeePGSuk8Xe8Wd8zfMBxicH4/fTPovm+7Ve/Te+Fea8oURHvGa+2weLbz1Z5/6mgc 2zsTUBAQldnaLhJ/cUr5DPOCX3eS+u1ZbtBCyjKJtRjNNUwCCzgWn6P98TP4DNrSrO Ttf489iOi1mz5KGaLkyECOaUjXIp3k3KbLZQ55n+8oq13tCBnzMUJuNhhiDlaie1Da 2hF7YSkgx9+TqxtwewQOyxFUtdYscoqhavHVCI3aO6Q0Pz9Hh2n9Va/1ohD5nkkf4o 5etlObpm1L0ig== Received: by keithp.com (Postfix, from userid 1000) id F06A71E600CE; Mon, 8 Nov 2021 19:15:31 -0800 (PST) From: Keith Packard To: Mike Frysinger , newlib@sourceware.org Subject: Re: [PATCH] newlib: undefine _FORTIFY_SOURCE In-Reply-To: <20211109025656.26127-1-vapier@gentoo.org> References: <20211109025656.26127-1-vapier@gentoo.org> Date: Mon, 08 Nov 2021 19:15:31 -0800 Message-ID: <87tugmm33g.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 03:15:37 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mike Frysinger writes: > Since newlib isn't prepared to build itself with _FORTIFY_SOURCE, and > it's not clear if it's even useful, disable it when building the code. It is useful; I've caught a few library bugs when I turned this on for picolibc. Fixing newlib to handle -D_FORTIFY_SOURCE could probably start with the patches I did in picolibc, which mostly just #undef the various mem and str functions before defining them. General code: https://github.com/picolibc/picolibc/commit/c2c593afa60b64bff0a958ad930e033= 6463db5bf Arm specific code: https://github.com/picolibc/picolibc/commit/b3946840fb3a677125bc9232ca93ea7= 533375188 =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAmGJ59MACgkQ2yIaaQAA ABGlXRAAgEtJV3mGKKSGTegwmMCxwFcihcsZT5+EiVQ/7JsEAjS4U0Z6igDYqaQa Hha/7AmQscyWEQKlfSPLfoTpFtIu9QkLqr6yEv/BWj2Jjez4uqI89RtB4Ub+3bDo 7H2gB8bTA03dhYwRNFUGNMBuYiQAnk95WKoczsefBwaVhd/Ad0oUL7SvQd1vj9Jm rSZFf3Sq1hXEBpH+YLklGKlb0Vw3d6UKQoVJg3H45TaQ0S1kwP387gLu6as10VHu 6EdOOk7ac5l8qf4K7OTis8yPj4zwFuqdn0ZY0JR37XORlgam/Seh6AVNjUMYHY1i 0tjvrW1Eo8SEHmX4s4J/Fr/AlXypTjh3gJZrQpjtmu7nZqPiNQ7dyEw+Z0ABibWt 5o1Gq/5jYzDK4iyvasybQ87ynFnI6803Tz9uaqBh+0fSUPPoLN6zLIv3jYSazDjN K40lZ/emitvos+7XZrCvTEkATTvSxPyOf9qaR0WvmOrA9tTVa8grIz0VfNuYZjJh otJqsa8R+pa5NiW89hl2uEaIxousE3f0vMlVJ6yY3KI4DTOcFa+CfLGUeL0Trs3j e8KCsKPfT6PIOn8R+HtW/I5vtxXX3WtNUU7tNRHutZxQomIjJ6/LauwpJQrBke3Y qpTMoYalZxij8jks4kPNEh4jSNKZ32zZqRr0Yr+mGPetmaURzIU= =R+Mn -----END PGP SIGNATURE----- --=-=-=--