From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by sourceware.org (Postfix) with ESMTPS id 443DE3959E4F for ; Tue, 1 Sep 2020 19:50:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 443DE3959E4F Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 5B84E3F2D6DB; Tue, 1 Sep 2020 12:50:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yf_tJLzvU3ae; Tue, 1 Sep 2020 12:50:10 -0700 (PDT) Received: from keithp.com (koto.keithp.com [10.0.0.2]) by elaine.keithp.com (Postfix) with ESMTPSA id DD0743F2D6D3; Tue, 1 Sep 2020 12:50:09 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1000) id C6DC61582201; Tue, 1 Sep 2020 12:50:09 -0700 (PDT) From: "Keith Packard" To: Sebastian Huber , newlib@sourceware.org Subject: Re: [PATCH 0/3] ARM with only 32-bit floats do not have fast 64-bit FMA In-Reply-To: References: <20200808223413.4015633-1-keithp@keithp.com> <1fc07c90-694b-01ea-cedc-0656eccdd827@embedded-brains.de> Date: Tue, 01 Sep 2020 12:50:09 -0700 Message-ID: <87tuwhb7ke.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 19:50:12 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Sebastian Huber writes: > It seems to be present in only some multilibs: I did some more digging -- the 'common' one is getting built, but the resulting math library doesn't have it included, which (as you suggest) indicates a problem in the build system. It turns out that the autotools build requires that all filenames across the whole math library must be unique; having 's_fma.c' in both common and machine/arm causes the one from common to be overwritten by the one in machine/arm due to the manual construction of libm.a from the constituent sub-libraries. As all of my testing was using meson instead of autotools, I guess I shouldn't be surprised that I broke the autotools build. I've sent a patch that renames libm/machine/arm/*fma.c and that appears to fix the problem. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAl9OpfEACgkQ2yIaaQAA ABERkg/+NVgbjMgJcM1svAsx2P8HIPeHc0x/PRtahhkcdIBGlOFOto8XrWg50lAD 6XAfoSYMMdkF4Ut8X32szhKOInMQTMJE2hQhlCWDI2EAme/7ZHIyriOmZ/4U+1lG 1pfTk6+s59IlKZpIbw8RLHhG274i6Ae3UWIMeFExhZlIkmvswsLY3coM07q0/ODf oxvJIT9u8EbjhjU1BvHGh/IEAGybMJL6fa/jpBd1VPRqGSnalWqOrQtIFpPiplor fjihToS7hQHIULQSwHBs5oRL29K8vFvdUUwNuyUS8zUNS02c/stg0JBeOoUvfN6k DgPRRr2UQMF12zNzK72CCkFjSc85ymB9GORBzepgg/Cm2rUBRqRn1/oZQbqu0kLf 2Dl/vv8vpxWHEPfjIpuBLjA6cWQvmhMlDJlnIOKhpPSZE+GT0SC/8iIOI8Elk/R/ H+ry5oIHAGTfqQTKGYc/TYJAM3WmHjZDmF3oGNRjdehzc/i1/wz4dfA+PV9DIdlG Wz50YekvI3bE2c9UO+Z9ylrTiHPsyPyqRwMUy7Mae8P1jJlNztxhxw3YhjeIEd1V MkQlyQt+5vIwfKueOyPhWlGjzgFz9r0ARUBtfdmNVgfVf0/0ut0q6gMqvzdBSFNt B8SHurs37QgCZ+gV37THrbi9GQJsi1H3AjErg5SiLCoSkgiqn/c= =IpPC -----END PGP SIGNATURE----- --=-=-=--