From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-045.btinternet.com (mailomta28-re.btinternet.com [213.120.69.121]) by sourceware.org (Postfix) with ESMTPS id A5DB33858D33 for ; Wed, 22 Feb 2023 20:10:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5DB33858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.54.6]) by re-prd-fep-045.btinternet.com with ESMTP id <20230222201055.WCDK10658.re-prd-fep-045.btinternet.com@re-prd-rgout-003.btmx-prd.synchronoss.net>; Wed, 22 Feb 2023 20:10:55 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 61A69BAC43E9A0B3 X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrudejledgudefvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfhffuvfhfjggtgfesthekredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepudevudejteevffehkeefleelleevieffkeehleegjeegleejheeivdelvdeileffnecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeekuddrudehfedrleekrddvgeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddvgeeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopeeurhhirghnrdfknhhglhhishesufhhrgifrdgtrgdprhgtphhtthhopehnvgiflhhisgesshhouhhrtggvfigrrhgvrdhorhhg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.246) by re-prd-rgout-003.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 61A69BAC43E9A0B3; Wed, 22 Feb 2023 20:10:55 +0000 Message-ID: <8ec9372f-2bc9-919d-cd04-3ef3d71020d9@dronecode.org.uk> Date: Wed, 22 Feb 2023 20:10:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Jon Turney Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues To: Brian Inglis , "newlib@sourceware.org" References: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> <381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk> <4c52eb49-e114-53e6-b30b-48bbfb6ba9bc@Shaw.ca> Content-Language: en-GB In-Reply-To: <4c52eb49-e114-53e6-b30b-48bbfb6ba9bc@Shaw.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1189.6 required=5.0 tests=BAYES_00,BODY_8BITS,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/02/2023 23:20, Brian Inglis wrote: > On 2023-02-20 15:03, Jon Turney wrote: >> On 20/02/2023 20:25, Brian Inglis wrote: >>> On 2023-02-20 02:45, Corinna Vinschen wrote: >>>> Hi Brian, >>>> >>>> On Feb 17 13:49, Brian Inglis wrote: >>>>> Brian Inglis (2): >>>>>    newlib/libc/time/strftime.c: split table of conversion >>>>>      specifiers to fix man, tbl, groff multi-page table issues >>>>>    newlib/libc/Makefile.inc: sed fix strftime.3 table format >>>>>      man, tbl, groff multi-page issues >>>>> >>>>>   newlib/libc/time/strftime.c | 3 ++- >>>>>   newlib/libc/Makefile.inc    | 1 + >>>>>   2 files changed, 3 insertions(+), 1 deletion(-) >>>>> >>>>> -- >>>>> 2.39.0 >>>> >>>> Would you mind terribly to add more text to the commit messages? >>>> explaining the problem, and its fix?  Just the subject line is quite >>>> terse. >>>> >>>> For patch 1, why adding the split and what's the desired effect.  For >>>> patch 2, what problem is the sed call fixing and what is the sed >>>> expression doing? >>> >>> Thanks Corinna, You're right - will redo all v3. >> >> You should also describe why this must be fixed in this ad-hoc fasion, >> rather than in the chew markup or makedocbook. > > I'll also ref the discussion with Branden, following comments from > linux-man, > the newlib man generation by docbook2man is incompatible with how man is > incompatible with groff/tbl/grohtml: > > https://lists.gnu.org/archive/html/bug-groff/2023-02/msg00118.html Thanks, interesting reading. > via makedocbook python script which generates xml (attached), then > docbook generates html, man pages, PDFs, texinfo, and the latter > generate libc info.] This statement of yours is incorrect: The embedded documentation is processed ('chewed') by makedoc into texinfo, from which html, info and PDFs are generated. The embedded documentation is also processed by makedocbook into docbook from which manpages are generated. Whatever you think of docbook as a pivot format for generating the manpages, texinfo is much worse. In theory you could use makedocbook as a starting point for directly outputting groff manpages, if that's the only way to generate manpages of the quality desired. > I dug and could not find a good point to alter generation of tables > > page size that may not adversely affect other [newlib] doc man page > tables, where the problem occurs solely on that strftime.3 man page! These seem like generic problem in the docbook2man XSLT, which should be fixed there.