From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Mike Frysinger <vapier@gentoo.org>, newlib@sourceware.org
Subject: Re: [PATCH] newlib: filter out versions from newlib.h to simplify autoreconf
Date: Tue, 17 Oct 2023 07:40:02 +0200 [thread overview]
Message-ID: <90d5591b-fafe-4ffe-b2c3-c14dc5011c48@embedded-brains.de> (raw)
In-Reply-To: <20231015093230.27356-1-vapier@gentoo.org>
On 15.10.23 11:32, Mike Frysinger wrote:
> We've been manually editing newlib.hin after generating it with
> autoheader to drop the version defines that we keep in the separate
> _newlib_version.h header. This is confusing for people, and is an easy
> source of mistakes/errors. Since we're already running sed on newlib.h
> during configure to filter out defines we don't want to expose, add the
> version macros there too. This way we don't have to manually edit
> newlib.hin. This simplifies the autoreconf step in exchange for a
> slightly more complicated configure+sed step, but seems worth the trade-off.
Thanks, this is a nice improvement for occasional contributors like me.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
next prev parent reply other threads:[~2023-10-17 5:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 9:32 Mike Frysinger
2023-10-17 5:40 ` Sebastian Huber [this message]
2023-10-25 23:14 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90d5591b-fafe-4ffe-b2c3-c14dc5011c48@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).