From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: newlib@sourceware.org
Subject: [PATCH, newlib/ARM] Fix cpp invocation for C++ in nano spec
Date: Tue, 07 Feb 2017 16:58:00 -0000 [thread overview]
Message-ID: <9a09dd05-1a47-bb27-b47b-3ea8d03f3a35@foss.arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
Hi,
The changes in c028685518a261f6d0dab0d7ed15f9570ab9b3d0 to use
newlib-nano's include directory work for cc1 but not cc1plus. cc1plus
comes with its own cpp spec which does not have a name attached to it.
This patch uses the renaming trick on cpp_options instead of cpp, as
cpp_options is used both by cc1 and cc1plus.
Tested with a small C program including string.h. Preprocess annotations show
that both when using -x c and -x c++ newlib'nano's newlib.h gets chosen.
Is this ok for master?
Best regards,
Thomas
[-- Attachment #2: fix_nano_spec_cpp_invocation.patch --]
[-- Type: text/x-patch, Size: 1168 bytes --]
From ae65c363338e95148e222dc88c31d12ad4749c3b Mon Sep 17 00:00:00 2001
From: Thomas Preud'homme <thomas.preudhomme@arm.com>
Date: Mon, 6 Feb 2017 15:51:02 +0000
Subject: [PATCH] [PATCH, newlib/ARM] Fix cpp invocation for C++ in nano spec
Hi,
The changes in c028685518a261f6d0dab0d7ed15f9570ab9b3d0 to use
newlib-nano's include directory work for cc1 but not cc1plus. cc1plus
comes with its own cpp spec which does not have a name attached to it.
This patch uses the renaming trick on cpp_options instead of cpp, as
cpp_options is used both by cc1 and cc1plus.
---
libgloss/arm/elf-nano.specs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libgloss/arm/elf-nano.specs b/libgloss/arm/elf-nano.specs
index 575f47d..324107e 100644
--- a/libgloss/arm/elf-nano.specs
+++ b/libgloss/arm/elf-nano.specs
@@ -1,9 +1,9 @@
%rename link nano_link
%rename link_gcc_c_sequence nano_link_gcc_c_sequence
-%rename cpp nano_cpp
+%rename cpp_options nano_cpp_options
-*cpp:
--isystem =/include/newlib-nano %(nano_cpp)
+*cpp_options:
+-isystem =/include/newlib-nano %(nano_cpp_options)
*nano_libc:
-lc_nano
--
1.9.1
next reply other threads:[~2017-02-07 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 16:58 Thomas Preudhomme [this message]
2017-02-13 8:20 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a09dd05-1a47-bb27-b47b-3ea8d03f3a35@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).