From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70044 invoked by alias); 7 Jun 2017 13:14:30 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 70012 invoked by uid 89); 7 Jun 2017 13:14:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-17.8 required=5.0 tests=AWL,BAYES_05,FOREIGN_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=Mitteilung, mitteilung, brains, d-82178 X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 13:14:27 +0000 Received: from [88.198.220.131] (helo=sslproxy02.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1dIan8-0001dB-1o for newlib@sourceware.org; Wed, 07 Jun 2017 15:14:30 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy02.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dIan7-0001yg-Ky for newlib@sourceware.org; Wed, 07 Jun 2017 15:14:29 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 08A2E2A004F for ; Wed, 7 Jun 2017 15:14:26 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id T8gBhsxTVhIy for ; Wed, 7 Jun 2017 15:14:23 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 74A742A160A for ; Wed, 7 Jun 2017 15:14:23 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id a0bJ4sqRxi1L for ; Wed, 7 Jun 2017 15:14:23 +0200 (CEST) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 4331E2A004F for ; Wed, 7 Jun 2017 15:14:23 +0200 (CEST) Subject: Re: [PATCH] Fix RTEMS ioctl() declaration To: newlib@sourceware.org References: <20170607090821.14403-1-sebastian.huber@embedded-brains.de> <20170607131105.GB15217@calimero.vinschen.de> From: Sebastian Huber Message-ID: <9b0bcddf-1cf7-974c-8370-1cdf94c76274@embedded-brains.de> Date: Wed, 07 Jun 2017 13:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170607131105.GB15217@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00395.txt.bz2 On 07/06/17 15:11, Corinna Vinschen wrote: > On Jun 7 11:08, Sebastian Huber wrote: >> Using uint32_t for ioctl_command_t does not work well on 64-bit targets. >> >> Signed-off-by: Sebastian Huber >> --- >> newlib/libc/sys/rtems/include/sys/ioccom.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/newlib/libc/sys/rtems/include/sys/ioccom.h b/newlib/libc/sy= s/rtems/include/sys/ioccom.h >> index 9c5350d1e..2c0e9ee71 100644 >> --- a/newlib/libc/sys/rtems/include/sys/ioccom.h >> +++ b/newlib/libc/sys/rtems/include/sys/ioccom.h >> @@ -36,7 +36,7 @@ >> #include >> #include >>=20=20=20 >> -typedef uint32_t ioctl_command_t; >> +typedef unsigned long ioctl_command_t; > Why do you need a ioctl_command_t at all? It's not in FreeBSD either. Its used by the legacy network stack in RTEMS (e.g. various device=20 drivers). I don't know who introduced this type and why. glibc has also=20 simply "unsigned long". --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.