From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id 569EA3858C53 for ; Mon, 4 Apr 2022 15:12:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 569EA3858C53 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 234BtGKg032645; Mon, 4 Apr 2022 17:12:29 +0200 Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3f6bwjt94m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Apr 2022 17:12:25 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GlQTr6Xx6SFKWr1JINRB/hqwo75XPool6BcQxGGVnA/9MZuabvlokrRMxvDLpr5DPluPw+7nhyeOvWcYZMS0yI8wu3f9Nw6ym0amWxnTFaS5cywTF0lVsxK1N6cfNzGvP35u3mBp2hkCMX3CQbjCLYt5sJTQz2Lf3ELnE+pa40ZJRM/O6F4BiYvIIMacYbqeKgsgrM6bkDLHw44yReOQyx715anyiXgt4HijoN7QWJCHJ2rFXKJG75MBKUA3N0cEL5/JUEyMBx0z4Cos0sq2cMEnM+jURCesYlh0oa7dXOjKZNca2q4KzPALb8+dCFgI5q5buXcB0QS3LJAZ91Vd1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t4BloBeVoRUbrlpzEfgc9Cz/7ga9tC/Lo+LWlS+zI1M=; b=E+WPEThxjz6a7D4/uk22u3lMcWV/nyLLpt4gY/pc6AIxYYgq65dq0ce05hyACWBxDVcVW1E/YKGo1kkFar/UWqdIR3yoSWF+4aapa77viQpyK2Nv/Y3P6bn/eYJ0wEnRcnZy3PZUV3D1KIRNJ6iizUAj3XpCmZE+AT6IkXBb/fxuy2i8u1qHGETMV47ZixpZWu2gTV8xa3T+Z/QIl40l49oKNNDf84rkJlYWbcOLQ0LZh/wOuWlyhZ3t2T5dwb3gRN9VXYMbEq0Hn8oobx8jkjHfNJixj6fidD51bIjjwmIu3PncaPcP4hgssPfXLNapXAJ3WjJJMVMvYMledtTo5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=st.com; dmarc=pass action=none header.from=st.com; dkim=pass header.d=st.com; arc=none Received: from AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:41::30) by AS8PR10MB4998.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:403::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 15:12:24 +0000 Received: from AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM ([fe80::d8a:22af:b4c:fdc5]) by AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM ([fe80::d8a:22af:b4c:fdc5%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 15:12:24 +0000 From: Torbjorn SVENSSON To: Andrea Corallo CC: "newlib@sourceware.org" , "nd@arm.com" Subject: RE: [PATCH V2] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2 Thread-Topic: [PATCH V2] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2 Thread-Index: AQHYSDO92RhCXMa3TU2RMK139pMP26zf27sQ Date: Mon, 4 Apr 2022 15:12:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Enabled=true; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SetDate=2022-04-04T15:10:36Z; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Method=Standard; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Name=23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SiteId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ActionId=56e5ab2d-11e1-45cf-bcef-f39c5c70ecce; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ContentBits=2 msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_enabled: true msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_setdate: 2022-04-04T15:12:22Z msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_method: Standard msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_name: 23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0 msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_siteid: 75e027c9-20d5-47d5-b82f-77d7cd041e8f msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_actionid: 013e8072-7394-465d-9762-de0159d8e378 msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce5b79a1-b97b-4c67-fcd9-08da164d8634 x-ms-traffictypediagnostic: AS8PR10MB4998:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YEzSXhzHYzgAc3gueXoaY2ypqGubp0nFNgKbo1lz1UHTuwfBjXsy+Vw6MhAUI/9EKsluBdUpnn+3dB7jqhGHg/lj6B2cZGWvKD5YimBCF0TkE1gd7LCCdQVRNuwt8qa79f6zo6S8ABIUTyjv4ks7o94GGV4fngvMsAM9mJtToeQlfYWwZDi+C8Cfl9kEcTzOb/OIICkQ/4eQiKAg2MtWfGDuctCCueP4NTdRAjx9/UpGNm1Cl9ocVuW/4xPAoFS1lnHYRznLUrKHfWzW3rrNa4rDjMOVweUxFxc7d79nVnxb+f/zeLLzYlgTDvXXWASBXcMVC8nrEzuJzEf50X2HcDxA/EU28COrqCnTaFVY/DgI6RnMtuZaPqJO7mFO9dLrGXUqoGcbdtBVPV+kiHpQyfBBbMWi9Vew7IAcpj2F8YLh2qAhlrSdIKbfBPtEPKFTlammVV3xS+7NvOoiic4kPUP3lD4Lu+2J56MnO37USmMoqMcjKDTMghgr9jM9QaE2kCjeGWz6ncsSShTIxEXlWJaChkVwtz45W96iem0es75PKs6E+C1GSroB2h02Q5VyBL0DX4Grxh3wC+kC9c6UJ86G6V3SCPubxV6lROUtKjJQ8Ln7yCXH3sAeMHrk8+GdOFUbSU3gxr1xenXHKb2AtM7dTQBAlgdrNvxJDTbInI/V10QTrA4I91NGQotoQwhzqaxa7t3Qy6zKp1ugflsxEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(76116006)(5660300002)(508600001)(86362001)(55236004)(6506007)(8936002)(66556008)(66946007)(33656002)(8676002)(66476007)(64756008)(66446008)(71200400001)(4326008)(52536014)(186003)(26005)(9686003)(7696005)(53546011)(66574015)(316002)(2906002)(83380400001)(38070700005)(54906003)(38100700002)(6916009)(122000001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?vq8jqk8kL5b4wnzVQmaOAdtGeE0fxR8ZqSyyOVItndgsqkzdIHbgOz+pzG?= =?iso-8859-1?Q?YxImL5NRdINb5ZKggQWOqw4vjewldgo6iN9TkNualobbGMisMjdqyO+bXn?= =?iso-8859-1?Q?o6ZA/X5wR/SJRBiBvmDG3VdqFN0Wpl9welNXh0/5LrIh2UgSjmEnc8GXyv?= =?iso-8859-1?Q?phEEoRKcuXPwykFyo10ZoAYKR4ple2RRz5hBGOeOmYHjzro4J3ah1OddZ8?= =?iso-8859-1?Q?JWwBx2K+B32qlc+wuC4hJZBQfonHETat7sQ3lx4ynH+7Z1JLWwqx2gbCUk?= =?iso-8859-1?Q?agu0MWya0QPdq62sAawwEphycx9LWmQyhZvc32oKKDarhyGKomwuC6B9ma?= =?iso-8859-1?Q?X7zd+MCWuuz9KQdq66k/3y00FA89cqgK50RTBnZBGbhjtxNUprSBlurAQI?= =?iso-8859-1?Q?KEOguGQ08KG5+MBoIn15UiAf25TQIvdzxGWiatkmtQfDhZcLrKoOZkJ+n7?= =?iso-8859-1?Q?t22oG5YgoaB8+jcSFHRrb/lA51nhrcqLn9/dqbbGN08FpxlRXcpj+rsNey?= =?iso-8859-1?Q?wbp7qsDj1oRBpejLXUylQoX1j+Iex6nosjuw7vmb9zghy/pZj9TLLnxZp5?= =?iso-8859-1?Q?ByGJTWhwtAVKLuzKIwWnAwWRRopp+FAEVbzUHvDnGqCYQVS6gTbGn3Z6e6?= =?iso-8859-1?Q?ELrCZ/HOHaafIspYlMCWMo/nPxaJ6P0I5F8oB+4bCWMVnZV+f6yNOLO+0u?= =?iso-8859-1?Q?bWkdMHTDgKJKlV4P69O13RqHUAY1XU9A3K/UuqKNHohMM42+tRYNUPA+IP?= =?iso-8859-1?Q?vzhsfA2EFdJALioP+dHJAERXOczpQzyV8dyZK7VZv4A+FfX2ai+v8aRQi1?= =?iso-8859-1?Q?6J12TibdTSpLjkgJS6pWEy63FZwfHPARdhL1lin7a0B3fTUc6TOlR1m+Zw?= =?iso-8859-1?Q?aibiop5hIPm7F2FtjzsWO8XVCjucTSF0KSxVD8iamDnkxDeyFzbiEmht1e?= =?iso-8859-1?Q?P8dm+NMPC99ekhiXK2kHmQUExnk7Wn0Twj6NK1XHM8POf96iWIWw+rbBPc?= =?iso-8859-1?Q?9TIl9ZkIL6UNiekj8ccYAmEfbEA+uJAyr9dxRDo33RRoCAx4cuKTeSl+ZH?= =?iso-8859-1?Q?4usC+FAw6YFPAik5uBJwLChIpK7HB2w8YWSvGhkfPKJKN4XHHdU3J5pMHY?= =?iso-8859-1?Q?j90l8G2opTu6LqJQDxxz4rzhDOOn/SyYL50hjSGM7A4lQEY/fLWnfETKCm?= =?iso-8859-1?Q?ygM0U5KdmbUJAxae/KHyp5j3laOpYdU0PeqMlFatP/8G5HT1QOGB2evAyn?= =?iso-8859-1?Q?/RcQzREUwFLtpncm2Z10tg+zL3k1EfHCOe1+TZfZZt1HTr9cWiSfvtWgq7?= =?iso-8859-1?Q?Zxp9jOAKwum9NX3aVwmN4n35Eozg2TcOZTjq2CO4dViNXXpkuLo5P1ydXU?= =?iso-8859-1?Q?satJtGOytMXlRMHgmxpAN6N/4KBHAtEuf1Qe0kZ/cCcVYFehLD3t/203TX?= =?iso-8859-1?Q?514qmOgwCP/auU4Yl809smne4ytnV2qrZWfIdcZ6iW/v8m2lFYf2mYdxtu?= =?iso-8859-1?Q?E4nVgce1tylgz8dZ7KN6t3YbAU60304nO1Yyo+amw0CxtqTRQCaskPN9Py?= =?iso-8859-1?Q?8N2DkMxyBNs68cCR0Av+vxcA3uyO++UIKCuho7ekNPJ+W4U0pBYehsJssH?= =?iso-8859-1?Q?BVTvGot4bSvO0OD18zBW2pWnc3JGSgFgIi0ezn0gg60aqlB2+h08rHsoBm?= =?iso-8859-1?Q?sNgNcoH/cgsVnvGWClxGhu6DSGf6ZL2D4nl9tfmifR0GM4DuX4GAlaHLuE?= =?iso-8859-1?Q?UkGWosCSyUX6feCB2pf5fE1rhh9o+ljUh26bbbQYhoJWr/W4S9KYjNeEuV?= =?iso-8859-1?Q?+u836Wf8iddYb2zfPkq6KWVXvwrtBS4=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ST.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: ce5b79a1-b97b-4c67-fcd9-08da164d8634 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 15:12:24.5321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vxm1xodijfCVFOKxWrM51vl02Wn1mAP/D6s/kFcBMyfyKP+c5SxThtaTKUihhYc6RuI0v437Eb+qr4XiG38+MtAhH+ZdA5ZSO/Otea+sXpk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB4998 X-Proofpoint-ORIG-GUID: Lrw76CUAicNbnSLxEduDftNTM4lhBlcv X-Proofpoint-GUID: Lrw76CUAicNbnSLxEduDftNTM4lhBlcv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-04_06,2022-03-31_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=978 suspectscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204040087 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 15:12:34 -0000 Hello again, Yes that was the chunk I meant. Apparently, I did not read the code close enough. Now when I go back and l= ook at it again, I suppose it's fine. Sorry for the noise! Kind regards, Torbj=F6rn ST Restricted -----Original Message----- From: Andrea Corallo =20 Sent: den 4 april 2022 16:53 To: Torbjorn SVENSSON Cc: newlib@sourceware.org; nd@arm.com Subject: Re: [PATCH V2] Aarch32/64: Support __FLT_EVAL_METHOD__ values othe= r than 0, 1, 2 Torbjorn SVENSSON writes: > Hello, > > It would have been easier to review the patch if it was inline, but > this will have to do anyway. Hi Torbjorn, sorry most mail readers easily show inline attacchaments of type "text/plain" allowing for inline reply, at the same time this way they can still retain the notion of attached file. This is how I rutinary sent my patches to other GNU projects (including GCC) so far. Has newlib some specific rule around this? > I think there is a typo in math.h. Aren't you supposed to do "#ifndef" an= d not "#ifdef"? I guess we are talking about this hunk? #ifdef __epiphany__ diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h index ba1a8a17e..da056b5b6 100644 --- a/newlib/libc/include/math.h +++ b/newlib/libc/include/math.h @@ -158,6 +158,15 @@ extern int isnan (double); #else /* Implementation-defined. Assume float_t and double_t have been * defined previously for this configuration (e.g. config.h). */ + + /* If __DOUBLE_TYPE is defined (__FLOAT_TYPE is then supposed to be + defined as well) float_t and double_t definition is suggested by + an arch specific header. */ + #ifdef __DOUBLE_TYPE + typedef __DOUBLE_TYPE double_t; + typedef __FLOAT_TYPE float_t; + #endif + /* Assume config.h has provided these types. */ #endif #else /* Assume basic definitions. */ I believe the #ifdef is correct. As the comment suggests if __DOUBLE_TYPE is defined we'll use it to define double_t otherwise we assume is config.h has provided the type definition. I'm reattaching the latest version of this patch with a typo fixed. Thanks! Andrea