From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id 908263858016 for ; Mon, 4 Apr 2022 09:32:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 908263858016 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2347cC9n024755; Mon, 4 Apr 2022 11:32:44 +0200 Received: from eur03-db5-obe.outbound.protection.outlook.com (mail-db5eur03lp2056.outbound.protection.outlook.com [104.47.10.56]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3f6du0g41a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Apr 2022 11:32:43 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NeKWKkh509mtLzKjRQXhuW01C/n8lSE82QW7mfnZrdhVSWCq4zOVMrBkXOMBE1sMLojOvdhJTUT8dpYJewP7+rzvj+YTupagjivpYFy5ISiEGuDyXllnxQ+eh3/WvoGJ0Vau2Pbky1NwO02WqAemwMZYPk64EZxuCMwKL21TkOPn+jsPoBiYH7SU+25SWLjxb9xTk2LAtQXbdiipqHY16T8NyzHhAwn0wVpb/XGsT+m2dc2yfsbDLY26LMlOFBWQd77G/AKa5CtHzE/xUw5tjTL7N0y75S7QMFrKY/0Dv5IWEWtlcWLWgsH/J6cwucEJnovBfbsZgvxw0qG2Cce8Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z5UeILEsotUpb84D60YNl6qbJ9v/vdp3lPp86xfNhO4=; b=eoTu32emmshzS9KUa5fj6CFjsDlbdPyFEmxrZCjH5jUV+lIF0zkgJsxXyXgZ3cnXyxf6WJi9q8/w8U9dH1ttckact5b2fW33iMa1LJFnnxgxa+k63ruLUQrhuYirYd/id9cYthyr8Y2BDRAZu/03I/+tkdvU3z+nKOE9P2WmefimPIqfAa1vKQfACHQCqYboU8YvLXnL5MtdCewPTSX2zmqzoRf2QJxqkVwn7GRWzkNPLMdzQXU3HiLLkQ3xj2U195/gnA8FlaDONrVDPqYmfxqQAfYGpOBgPhJIMkeZ8QFj4maqRf8xzJ2M72V/w1bo0sds4HSEuSHZN/BcxS60OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=st.com; dmarc=pass action=none header.from=st.com; dkim=pass header.d=st.com; arc=none Received: from AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:41::30) by DB7PR10MB2556.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:80::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 09:32:41 +0000 Received: from AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM ([fe80::d8a:22af:b4c:fdc5]) by AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM ([fe80::d8a:22af:b4c:fdc5%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 09:32:41 +0000 From: Torbjorn SVENSSON To: Andrea Corallo , "newlib@sourceware.org" CC: "nd@arm.com" Subject: RE: [PATCH] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2 Thread-Topic: [PATCH] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2 Thread-Index: AQHYR/+VuwBQF7aJgE6TYvDHU8MgbazffXKQ Date: Mon, 4 Apr 2022 09:32:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Enabled=true; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SetDate=2022-04-04T09:32:39Z; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Method=Standard; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Name=23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SiteId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ActionId=31bd6abd-e009-4e7f-ad0b-c2bac5ad02ac; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ContentBits=2 msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_enabled: true msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_setdate: 2022-04-04T09:32:39Z msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_method: Standard msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_name: 23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0 msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_siteid: 75e027c9-20d5-47d5-b82f-77d7cd041e8f msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_actionid: 2ba36cfb-d29c-4099-85bd-b7551ba13229 msip_label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6208fba3-7f55-4357-5609-08da161e1115 x-ms-traffictypediagnostic: DB7PR10MB2556:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p2Yj5ZG8nhJYsQ04fO705afj1rYhqdfPAW6z8m/9VJyMFcE5NDWDIglH0jksWAVDAru5YqapBDd/f/9LXcntIpiISpiBFecqwCX5Uxj+9/R9MNGx+kHiiIZqSVN2QIeyjmV+WIRws4KfJBcTcBOKGYcoeHAlnytfhCEiOAppYZ1O77pXVX5/Xkkg2nbgX7OKe5QuAHP+rUhWMvqFl19O4Wc7oYwdROf6OnGfPh8DstBlhHe1Y8F2a0fiB0emAPvTmTSy7lSxjfqAxNh7YIKLzDnCHUyCRnsnLxFgtNzaRW7zXx1f0w4Qc9ejWqorHJTOGxTLKvE+aOoaIPDMPVNKE4EKRHomGZzZoqxjLrB8Rt6b9qa2pimdNlyg0aKY020F9GT8mjTUFfb1bFncQ+sbmVYn2r5OnHmQcGsJgSJYKPNxG+eP7qn7TLczYayIsTYe/GHjolBJaK10I5n8lZ2D+QQwu2x6tfOAO8cnyauMZ69uCpW0egbuB0H7/sXborzrYT1soBZ8SfyStxqk2AtBP7iyyLdT2ZMUl+Ditzh9UUWSalaKQnktAY3No91q1ijQdKMhYuksWKqsSmbW9BhUZRNuBt0LxU3hSI7OBYO4qlXPUD1wYf7XNMADx+MmEDUk3ZxVfhIK49lAHwt8I1f+dJ+gDUxVYE8I+1dEQ29IEpS4YBV4tY5Xe6mpFJIiaxmPTo4ZrdrhkDq3etkMRg/fXdb/Q6uM0asF4CnghSuIrm7M9eDDW4vsYFwaZv5/HUemFe/kylSgU37L9iuUn3LFedGHbyJlm8MZYdqrVa2f3YI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2906002)(122000001)(83380400001)(38070700005)(33656002)(110136005)(38100700002)(55016003)(6506007)(71200400001)(4326008)(86362001)(8936002)(8676002)(5660300002)(316002)(66946007)(66556008)(66476007)(66446008)(52536014)(64756008)(76116006)(66574015)(26005)(508600001)(7696005)(9686003)(186003)(55236004)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?gDFw8ZFzLWMhTgFkRlKJdZQOb3FMfLSK62O/m2aj7miYNw7KSim8YYnGof?= =?iso-8859-1?Q?o5/Skl8w/A+yO/z5l8AZRZ6prpa05tqYdELAaZJI5a4c5oCodxVUowOHsZ?= =?iso-8859-1?Q?mjWdM/tukhw8efMoi9e0EdVI5ph18QDwtQ/wKu9qC/U9abwrCEjuME8zxK?= =?iso-8859-1?Q?JBEP2XHSxdoj4gTQGbW/6hHpxHsOaRoRzIzN9gyDVMpDqRphSzhoDdnFUq?= =?iso-8859-1?Q?inMkFFYeEMFvGpEhvayoanZ77joeX2ldF52QhaNpujcBSPyVVtblbWlcWH?= =?iso-8859-1?Q?cy2A3X8L407I+vIFOjKaoYEQ16z0prD1HpPZBCTF1D7uHjtbafPoGWujjV?= =?iso-8859-1?Q?+baWilr14/Yvu/5eZMmUhD0O4J5jeGGcHAhYeNl6nawyVjr5IYhx1Y7crc?= =?iso-8859-1?Q?GXP+51rGrNoi1aUFZF/F7RPZ16ZdLSxKW5JItAnyvjh2zxzGe0oyZdk77e?= =?iso-8859-1?Q?xSfYF2EfmBzb7QwKCM6EEKH7vtah46vWtWyeHWgbdJvtJeDVQDF/1/5XK4?= =?iso-8859-1?Q?FpfdLdKzPzy/js2Vrem2fM7qxvtBcMwVsSa6FFTbri5vxmzfebxdpjX4Y5?= =?iso-8859-1?Q?eRw2wuIkLVCF50EK+/RkR2n1vMeXorlWuo8/kmJ7LizJfxDRg011W4qngk?= =?iso-8859-1?Q?sDp9g7R91DMiHYsGWgWQAN/swa3Oqo3PPA43spJhVArYRrMoKsfZMW4l/p?= =?iso-8859-1?Q?6j3CjYs6RcGq0YinGTMbIr9p9yUf9hxw+X+CiVwPF2/JDYV6j5HZ9Sz6S1?= =?iso-8859-1?Q?1K+EY3fqw4EDUjrBYNORvGByOwAu/ageeeBi9iNuE2xshSkaSXU5LFAP5u?= =?iso-8859-1?Q?5iOda1Fd0YUb0wa+j8bJitn6gM5eUSBxt4AOKQ6HwX+CqNuxoM33iIUArS?= =?iso-8859-1?Q?Vbdn74E2JTeVsrZIiXNDsr60Osxo+5pGeDQy6rRBR/L4jl9sj7jgtmI6+K?= =?iso-8859-1?Q?h4WWxn9YIFG2/A6BxcOr4LlL2TgBe18J8zj97i/uoI7emzTKnK1tX98BYN?= =?iso-8859-1?Q?+xNQ+159gpWMnDhafxj/6IisA2KHTUT5H3w47X740dkC8C7X+2hYPb62mS?= =?iso-8859-1?Q?AwL+pNqzgeMXWFo7RexgoXftZlmwg/X0w/s/ds0oBvI6b8tRGrHqwcT/T7?= =?iso-8859-1?Q?YT8DMZQsgrjg4UCK0lJlcc7QCSsnl3+SFNIp8olGpuvn0cVSjIMqHfB6bU?= =?iso-8859-1?Q?ObpJnh2CTmSp8a/cPJXdVgxaBRB5slZ0O/AvWs/v/wcMCF7pXMJCuLUFTy?= =?iso-8859-1?Q?p6Kx0Ws1FwvgK8s+ojyLXlVIUop6Jng7JBuhIJI/nPSBKwl2XSK320sx5f?= =?iso-8859-1?Q?jStdViyuzoxMZjY8JjH2R54fpeTKuXLRqgNsLfffv8zQrw+Z0znDmulOm+?= =?iso-8859-1?Q?YanIqCNqw0mzqYKmgIKoaOihEdm+j6nL6mqu3JBApkdQrhBzCfDcoXt5/x?= =?iso-8859-1?Q?kWIFS5XuzFz0RY0V8G6cr5XqWMGBJJY4SE6hi+hCJ2NFEM7oSBrU+zykA1?= =?iso-8859-1?Q?tQfN9dZrexyoqIrf17WPIBmh7VOuBUTmlJlxnplCC900RvcF+6ezs3KI9l?= =?iso-8859-1?Q?KS2W7KY0BcHDBgCPsq2X05JOpUErC+oaHCloviTOZD+S71kLlNHBQcIrG0?= =?iso-8859-1?Q?qbZjhpVNSAuGHdbHPqnJJt0RauLYEZ05+PguLK9e7BNFlqLf74yiKKPTpS?= =?iso-8859-1?Q?1Jr3KIvZH4U6FHn65mufvsxW9v+CMHy8bQKPLInRqS4iz01PCGXtlqZQpt?= =?iso-8859-1?Q?KadXsfdu58ccqzpD0LcSVLAlR/MpNpbXOuHZmT4PdNOX/tRQ1yW1AZdzK5?= =?iso-8859-1?Q?DO2thIBfZAuTqxgF4dmSXKpRvfJNpbc=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ST.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 6208fba3-7f55-4357-5609-08da161e1115 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 09:32:41.7474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 91H2IWtdss6iTDo2zFOG6AS7C6ReFY9D7khKTpsO0BejQOGLqa4v+PLTBD5mk3SRwWaoWJNq4C5lTK+6QNznR0xdWt7MLV2hk+v1QbXmSZA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR10MB2556 X-Proofpoint-ORIG-GUID: i1bMpIh4ANHukeFTT-niNl9Iwl7NVjzs X-Proofpoint-GUID: i1bMpIh4ANHukeFTT-niNl9Iwl7NVjzs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-04_03,2022-03-31_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 bulkscore=0 malwarescore=0 clxscore=1011 adultscore=0 mlxscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204040053 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 09:32:48 -0000 Hello, It would have been easier to review the patch if it was inline, but this wi= ll have to do anyway. I think there is a typo in math.h. Aren't you supposed to do "#ifndef" and = not "#ifdef"? Kind regards, Torbj=F6rn ST Restricted -----Original Message----- From: Newlib On = Behalf Of Andrea Corallo Sent: den 4 april 2022 10:39 To: newlib@sourceware.org Cc: nd@arm.com Subject: [PATCH] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than = 0, 1, 2 Hi all, when _Float16 in native precision is supported GCC defines __FLT_EVAL_METHOD__ to 16 as per ISO/IEC TS 18661-3. Ex: $ ./arm-none-eabi-gcc -mthumb -march=3Darmv8.1-m.main+fp -mfloat-abi=3Dsof= tfp -xc /dev/null -E -dM | grep FLT_EVAL #define __FLT_EVAL_METHOD__ 16 #define __FLT_EVAL_METHOD_TS_18661_3__ 16 Unfortunately libc/include/math.h understands only values 0, 1 and 2 leading to have newlib non compilable for those configurations. I think in newlib we should either: 1- Handle __FLT_EVAL_METHOD__ =3D=3D 16 2- Build in a C mode which does not enable _Float16 (ex -std=3Dc11) 3- Build without the _FloatN extensions -fpermitted-flt-eval-methods=3Dc11 I think 1 should be the favorite approach. ISO/IEC 9899:201x [1] suggests that for other values of FLT_EVAL_METHOD other than 0, 1, 2 the definition of float_t and double_t is implementation-defined. The suggested patch implements that for arm and Aarch64. Note, some previous discussion on this topic can be found here [2] as follow-up to a patch addressing the same issue (only for the case__FLT_EVAL_METHOD__ =3D=3D 16 case). Best Regards Andrea [1] [2]