From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id A61AE382CF2E for ; Tue, 7 Jun 2022 06:05:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A61AE382CF2E Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 256LUJDx031879; Tue, 7 Jun 2022 08:05:03 +0200 Received: from eur03-dba-obe.outbound.protection.outlook.com (mail-dbaeur03lp2171.outbound.protection.outlook.com [104.47.51.171]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3gfvha6sk1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jun 2022 08:05:03 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejtFCM6V3llvreyUhwEV1ygdEgZ5sqh54eFhAwxkTKVtI2pIHPKsqXoGArIOBF3CWOCj45cdMT6HvEhEyg0Y5Yt01h2Wb6zCe00+elMmYCsmlcRqzkJkC1E72QJ0Sy3i3VpkVjU19LnLO+YmETfRU8JinCHl2GbKufTTwCd5FHA3G1Of1Hf6pvyuSgxhVLlMlkxYJgjPItcr0VFNPdKKceYhjiXaIGrBF42bisdQ6QqBkVssMIvf+TCnuqQaCVN0r8GkQS3dRi7imsmPg7IO+HmcG4CSBFhfxl21PDCaXTTwlTru+Ddlqfl+J21Jyj4ZxvMmns17WYxlWOmbMjzu8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BRs3MdpYH4OlBkYR+k/Ck0THRAjQNzj+xL05hoPzi0g=; b=M/AaCSl5EDA6R/8K/31yY3rVSEwxbWdIret7zHiXgYXybyotVv6kp6fyAOufMLZ7TIuNW+GZlKY13lA3AHGHCCziLjNK2LpE4bEGjftKQxh7DwspKYD4XEQDNXEk9yw/MCSj0y4jyL53+3Y/PzolJ0nNQDgUrvzspAagJDZwb/RNFXqg9sSImeo120t5kWwAULXsticmr+MA0yZbIhX8ZdleU4KDqnC07FNAozlkdskaOIak2fRs4kixaQUA1gKSXoaMK7EjHmDfvwjfX1W3/wCrpZqBHNYaROpABdw1eL3RFndWRUceP/0jYoG/Im/lCWS46aUs6Usu5NIvrcnqSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=st.com; dmarc=pass action=none header.from=st.com; dkim=pass header.d=st.com; arc=none Received: from AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:41::30) by AM6PR10MB2439.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:48::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Tue, 7 Jun 2022 06:05:02 +0000 Received: from AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM ([fe80::d84b:9f70:5c46:901c]) by AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM ([fe80::d84b:9f70:5c46:901c%3]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 06:05:02 +0000 From: Torbjorn SVENSSON To: Hans-Peter Nilsson , "newlib@sourceware.org" Subject: RE: [PATCH] Fix stdio init handling Thread-Topic: [PATCH] Fix stdio init handling Thread-Index: AQHYedISuQEZidlmVUaTAeyNktkmuq1Dc+yA Date: Tue, 7 Jun 2022 06:05:01 +0000 Message-ID: References: <20220606182003.DB8A72041A@pchp3.se.axis.com> In-Reply-To: <20220606182003.DB8A72041A@pchp3.se.axis.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_Enabled=true; MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_SetDate=2022-06-07T06:04:08Z; MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_Method=Privileged; MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_Name=cf8c7287-838c-46dd-b281-b1140229e67a; MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_SiteId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_ActionId=f0db2c63-19ca-45b4-8293-a5743849419a; MSIP_Label_cf8c7287-838c-46dd-b281-b1140229e67a_ContentBits=0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e081deeb-ebfd-499e-7762-08da484ba8ec x-ms-traffictypediagnostic: AM6PR10MB2439:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2hssQ6SgD6plieud3/vpqjJB291h4xRipJRpHFBWMkPUesdWooeYBBXFpT+zXELzlN56bxRcmT5TVmbHsUz+33lQ8LvRKLjFSSg71nEA0tgLLYKvIIWbZGnTjojWpli47+I7If06ilIwZVY/d6h/ekDn0s3htSh9BJ0LQojT0gSswBlA7zKDpuF450FaimLaFnPJ9ctcOzLyRQC0fHBdpqF0Fn8/YoJxlhlmFTom/o5kOdAJXqCwa99mU6RiRgdjP+SyG2hx+IwKL942Oddz3Nc8QcDnStnnrE3QZ9+sAONgXUoCLbfynSBmxcb+i8KC+aMrtMd+ovgVfCb13icLv8avmjIX60mxE3E3DyXMPVr40yB1045LKQKCVgQQ+RD4iHMprUnoEC9X2XjghoCpOvaL1NJDIph76lSYotGgN1jHiMMe5Lje/7nzDXy2O96lUwfFhaai7TGN9kaD7jZjB3soFNa4eonJgcu30Tm7i85xc4QSRUOSFZNJ4vK0cj91vvo3VLzCUSEDw3YduAddqQnbhN8yPABwzue32WIWxTg92clpDqWIi97QV8cGHf8itc8s7QHfVHZfmlW0M11xVuUZqWs0vQdXzfqFf3ZQycwIJXpo2U/TZXKu/L/9jtvCoQB1MmeiKL/UgeOsQHeMjtoRmorx0dadvU1T3udo7hbFjqegfZ8aLcLe/0o3kbImZfVUqQ6YbgRGw8nZLkX6aA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(5660300002)(52536014)(8676002)(66446008)(66476007)(66556008)(64756008)(83380400001)(8936002)(76116006)(38100700002)(2906002)(186003)(316002)(33656002)(9686003)(26005)(38070700005)(110136005)(122000001)(7696005)(6506007)(55236004)(86362001)(53546011)(508600001)(71200400001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?35X4XMqdTatkgk6CZxuhOZbii64wEj6JvfB9h/Ad7AQd5ciDd60az1nKQX?= =?iso-8859-1?Q?Dz/eYktUvaVzeqp+NS6iER2Nd71R5rrpJyRUqdCbBEXiDZrpOuJcrzCGpV?= =?iso-8859-1?Q?NOk+QnyKrgCQhzPrj9o70uAQi2CIPz4xskpsGVOsIpt0TXPm6H1Q37JROR?= =?iso-8859-1?Q?L6n1m8a+/X45UecLh2X3kvTNRsAAJxIDruBPYbxAcCk6QU7wKOggzKUbIr?= =?iso-8859-1?Q?J1RkEha3lf6UWLtoO4pQmd09iOCQsVOFJPHMQSdCgeXfXsSzyKZvn66VpG?= =?iso-8859-1?Q?zFbdMJAXAy1Mz5ituWlAH1KpbDHGUL43aI+KZ6BBX5vJEx3yoxM4+x0881?= =?iso-8859-1?Q?h/bPjeolSFYV8VWbj3HDsWgsc94fGhEA4T58UzmpA3sc4nRCwtWUCDpQCv?= =?iso-8859-1?Q?Me7FSL929mAMPQxJI+KKkvZhSxCkz9f7dGPsU3zGWDGakuELamKCT1NdZy?= =?iso-8859-1?Q?XwcufZ98Aq+IhEcuriD9G0qfQ7C5QCbX//5BTtgFpC3T9qu7BxaffXFvzj?= =?iso-8859-1?Q?nXNwVvuJk5Dgu9JAq6vMUfpddwTcbRVEqVyFIYvNyZXn1zfo+bFrkdwHlz?= =?iso-8859-1?Q?iGxRPBTSgB37WHs+W9Whw1oVQzB5mp3hMj9i7w2K9BzqNAaOBWobgM3v4Y?= =?iso-8859-1?Q?vLmbrdb/sz70yIuZCf3M0fPmcUFyPFHkwHPaZpteCIq3wiaOolDB/U5toE?= =?iso-8859-1?Q?gdNx8OZk2AWPHgVvUopHA2RoyxOabsymnE8Aej7aICJzV9GswBHFvPsBDn?= =?iso-8859-1?Q?o3Zqzgk3yzlj2vD8FfrNNpM6J6ji7/x2aRnjKAhGW9bZHHdUNBvbX2LMCn?= =?iso-8859-1?Q?hCsLrpIb845GMWgiuhHGO5H4mw3L26GKRkCyL1P37xGix4G/e8t+IWsDVl?= =?iso-8859-1?Q?lifzzoPzN/H0bBGNIY4KAH39pL+IMJYl079aVAL7gm1g1E1sn5N+UCrH/4?= =?iso-8859-1?Q?+PAsZFesx/FhUNzuj4cNPs6kYeSs9Erf7OndLF5xmrapLTZgYp6r1YY56r?= =?iso-8859-1?Q?duv4DYlSJaR/irBJw5Lv/dqSXI17zzPS5EZloIvo+rxWMLgHmfbkS4FFUT?= =?iso-8859-1?Q?ui5r1Mi+iY7ZOYMr9/bQTQhZfxJDygqVKdjb6c8Po6oaWIODXJDOj9sQ3Z?= =?iso-8859-1?Q?eDIMZE0fyiMjuOTGN5mFBdPeHPonDnn3XwBmtIW41buCRThPsLm91GtYPM?= =?iso-8859-1?Q?6B/aUtP4y/368Zwq4lcPQAQL1Yrw5gojBl6LifrPMEuxpO4Cpv74itcOTo?= =?iso-8859-1?Q?tfs+s8musnPPDrhjLkp/OSDz3xfPJORn3TresRvbRNqg6kr/Tk9vLe71nQ?= =?iso-8859-1?Q?H5UlJyybmuwERd4qU/rK+Opr9+t6WhO96PMTw06vR5nedhmrv+f6Vna4l8?= =?iso-8859-1?Q?R6nmhAjdoopq7NoxU/PDxaXnhlxqAmBdDrZKXp/yNJUYta2jT4SDE+Ycjp?= =?iso-8859-1?Q?sHYlseKm5Xlk/3r80QbrKSBoV6vz/rhitNMLJOH/V9szz4TlsHjqcWNCpS?= =?iso-8859-1?Q?yvIo+CTbGvZsF+f7vnmmVC5QFY1s7ShbKN2A29a7RKC6zK1csfitN0Dpu+?= =?iso-8859-1?Q?rT/8fyanFikSRGPGhQrlt6XxC7F8+ApjQFjS1Q5f0/vFRLTCvfKBzIyACs?= =?iso-8859-1?Q?yVqwJ6lYKyFS4Oql3Pa77P2BpAESXjw2T4gBnumsmvLEuLqppvXj+SpXdK?= =?iso-8859-1?Q?sR0N7VW9YVYMqNdhSam2uiQ1po5Rx1jtBpK0zsJSyyYRVgGbHyBfFVcMh/?= =?iso-8859-1?Q?LlvKQA/ygBfA9wQHYSGFloTiEr2yOc0l3I4LtVabHWNGpbxGdSTIoBiFIp?= =?iso-8859-1?Q?QN+tVR6/FEkGaDsZLFdj3momvUWclq0=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ST.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: e081deeb-ebfd-499e-7762-08da484ba8ec X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 06:05:02.0006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vN+VDx62GEmRtXBV/l2m+hLxRIq8ULNamND0iaom0EZyKcv74Q3g4RcAqp6Vb6REzbGTNZSPh4rihazhQ6KY6IHE3znRggmH6G0k6UYog7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2439 X-Proofpoint-GUID: VMomJ7VVsqADJsoDdqid2XSxGeKZivOr X-Proofpoint-ORIG-GUID: VMomJ7VVsqADJsoDdqid2XSxGeKZivOr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-07_02,2022-06-03_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 impostorscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxlogscore=669 adultscore=0 suspectscore=0 phishscore=0 clxscore=1011 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206070024 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 06:05:08 -0000 > -----Original Message----- > From: Newlib bounces+torbjorn.svensson=3Dst.com@sourceware.org> On Behalf Of Hans- > Peter Nilsson > Sent: den 6 juni 2022 20:20 > To: newlib@sourceware.org > Subject: [PATCH] Fix stdio init handling >=20 > Ok to commit? >=20 > ----- 8< ----- > After commit e826fbb2ae88 "Fix stdio exit handling", for trivial > newlib using targets such as cris-elf and arm-eabihf, i.e. > (!_REENT_SMALL && !_REENT_GLOBAL_STDIO_STREAMS && !cygwin) stdio > initialization no longer happens properly. At that commit and > after, programs like the following are broken for such targets; > at the first opened file, the first FILE record seems > pre-allocated, unused and free, and is returned as the "FILE *" > at the fopen. At the subsequent fgetc, it's *initialized* as > stdin and the fgetc returns EOF (without errno), yielding > "fgetc-EOF: Success" and the program aborted instead of the > expected "all-ok". >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > /* There must exist a file "./fff" with the first byte an 'f'. */ > #include > #include > #include > int main(void) > { > int e =3D (errno =3D 0); > FILE *f =3D fopen("fff", "r"); > int c =3D fgetc(f); >=20 > if (f =3D=3D NULL) > { > perror("fopen"); > abort(); > } >=20 Unrelated to the patch proposed, but I think you should avoid calling fgetc= (f) prior to checking if f is NULL or a valid pointer. Kind regards, Torbj=F6rn