From: Kinsey Moore <kinsey.moore@oarcorp.com>
To: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
Sebastian Huber <sebastian.huber@embedded-brains.de>,
"newlib@sourceware.org" <newlib@sourceware.org>
Subject: RE: [PATCH v4 0/2] aarch64: Sync with ARM-software/optimized-routines
Date: Thu, 26 Oct 2023 21:55:02 +0000 [thread overview]
Message-ID: <BN6PR19MB3314D82A14E71D1B5A586F3590DDA@BN6PR19MB3314.namprd19.prod.outlook.com> (raw)
In-Reply-To: <eab939c4-35f1-8ddc-f2fd-3203b1528b75@arm.com>
Hi,
It looks like this update has caused a duplicate symbol in the generated libc.a due to the added alias to memmove in newlib/libc/machine/aarch64/memcpy.S. To maintain a closer match to the upstream optimized-routines repository, I'd recommend emptying newlib/libc/machine/aarch64/memmove.S if it needs to remain in place or removing it from the build entirely.
Thanks,
Kinsey
-----Original Message-----
From: Newlib <newlib-bounces+kinsey.moore=oarcorp.com@sourceware.org> On Behalf Of Richard Earnshaw (lists)
Sent: Thursday, October 5, 2023 10:36 AM
To: Sebastian Huber <sebastian.huber@embedded-brains.de>; newlib@sourceware.org
Subject: Re: [PATCH v4 0/2] aarch64: Sync with ARM-software/optimized-routines
On 05/10/2023 13:20, Sebastian Huber wrote:
> This patch set synchronizes AArch64-specific files with the
>
> https://github.com/ARM-software/optimized-routines
>
> upstream.
>
> Sebastian Huber (2):
> aarch64: Sync with ARM-software/optimized-routines
> aarch64: Import memrchr.S
>
> v3:
>
> Use latest commit.
>
> v4:
>
> Update COPYING.NEWLIB.
>
> Sebastian Huber (2):
> aarch64: Sync with ARM-software/optimized-routines
> aarch64: Import memrchr.S
>
> COPYING.NEWLIB | 250 ++++++++++++
> newlib/Makefile.in | 40 ++
> newlib/libc/machine/aarch64/Makefile.inc | 2 +
> newlib/libc/machine/aarch64/asmdefs.h | 106 +++++
> newlib/libc/machine/aarch64/memchr.S | 73 ++--
> newlib/libc/machine/aarch64/memcmp.S | 311 ++++++++-------
> newlib/libc/machine/aarch64/memcpy.S | 272 +++++++------
> newlib/libc/machine/aarch64/memrchr-stub.c | 11 +
> newlib/libc/machine/aarch64/memrchr.S | 115 ++++++
> newlib/libc/machine/aarch64/memset.S | 194 ++-------
> newlib/libc/machine/aarch64/stpcpy.S | 36 +-
> newlib/libc/machine/aarch64/strchr.S | 107 ++---
> newlib/libc/machine/aarch64/strchrnul.S | 90 ++---
> newlib/libc/machine/aarch64/strcmp.S | 282 +++++++------
> newlib/libc/machine/aarch64/strcpy.S | 437 ++++++---------------
> newlib/libc/machine/aarch64/strlen.S | 319 +++++++--------
> newlib/libc/machine/aarch64/strncmp.S | 323 ++++++++-------
> newlib/libc/machine/aarch64/strnlen.S | 256 ++++--------
> newlib/libc/machine/aarch64/strrchr.S | 86 ++--
> 19 files changed, 1644 insertions(+), 1666 deletions(-)
> create mode 100644 newlib/libc/machine/aarch64/asmdefs.h
> create mode 100644 newlib/libc/machine/aarch64/memrchr-stub.c
> create mode 100644 newlib/libc/machine/aarch64/memrchr.S
>
These are OK.
R.
prev parent reply other threads:[~2023-10-26 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 12:20 Sebastian Huber
2023-10-05 12:20 ` [PATCH v4 1/2] " Sebastian Huber
2023-10-05 12:20 ` [PATCH v4 2/2] aarch64: Import memrchr.S Sebastian Huber
2023-10-05 15:35 ` [PATCH v4 0/2] aarch64: Sync with ARM-software/optimized-routines Richard Earnshaw (lists)
2023-10-26 21:55 ` Kinsey Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR19MB3314D82A14E71D1B5A586F3590DDA@BN6PR19MB3314.namprd19.prod.outlook.com \
--to=kinsey.moore@oarcorp.com \
--cc=Richard.Earnshaw@arm.com \
--cc=newlib@sourceware.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).