public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Joel Sherrill <joel@rtems.org>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] riscv/sys/fenv.h: Add missing extern for fe_dfl_env_p
Date: Thu, 17 Oct 2019 16:20:00 -0000	[thread overview]
Message-ID: <CA+yXCZAJ0ucQG0G2GAS5JCmTfeQ6qqgJ9ozLRboiCHi-CtaA+Q@mail.gmail.com> (raw)
In-Reply-To: <1570636881-25491-1-git-send-email-joel@rtems.org>

Hi Joel:

LGTM, verified with rv64gc and rv32g.

Thanks :)

On Thu, Oct 10, 2019 at 12:01 AM Joel Sherrill <joel@rtems.org> wrote:

> ---
>  newlib/libc/machine/riscv/sys/fenv.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/newlib/libc/machine/riscv/sys/fenv.h
> b/newlib/libc/machine/riscv/sys/fenv.h
> index e69978d..6cbd321 100644
> --- a/newlib/libc/machine/riscv/sys/fenv.h
> +++ b/newlib/libc/machine/riscv/sys/fenv.h
> @@ -72,6 +72,8 @@
>  typedef size_t fenv_t;
>  typedef size_t fexcept_t;
>  extern const fenv_t fe_dfl_env;
> +extern const fenv_t *fe_dfl_env_p;
> +
>  #define FE_DFL_ENV fe_dfl_env_p
>
>  #endif /* _SYS_FENV_H */
> --
> 1.8.3.1
>
>

      reply	other threads:[~2019-10-17 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 16:01 Joel Sherrill
2019-10-17 16:20 ` Kito Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZAJ0ucQG0G2GAS5JCmTfeQ6qqgJ9ozLRboiCHi-CtaA+Q@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=joel@rtems.org \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).