From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id AD060386181A for ; Mon, 27 Jul 2020 08:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD060386181A Received: by mail-wm1-x341.google.com with SMTP id 9so13362317wmj.5 for ; Mon, 27 Jul 2020 01:48:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1HfLCfZreq3Vpv+7wXG7kIDmNhoqxzB0D/UOP5/UvbY=; b=ooCswFWSf29iwcLnCFQkRG0v/2ZquhYhtxOkGfwpWXWOFxNCN1duAT4BVUYqRyKFVs R4bqbn0Lpr1dOr4vpkU5R0D7VgqxtnZpO14zBlVH3K4RMNFQ+3If9/QEqulKFjoQmyiA 4cm9PLQBFxAhXPym69cwM7J7epDK7e4dURuo3LAfJ5UADNYURFyUzUsYzEiJd81g+VHA 6+3L7GfltLqr3D68hXTtBkjSdi/GjUEG21tBdo6NcDiAyYrZ4GN7hqE2HqcLaw4PsnIH +55/Re7z90oD3aQ5TuKIzeMlIYSuGW0K+njP5f6zz1nv1bVOG5hL13QRjVXlr/KCC/+x lhUQ== X-Gm-Message-State: AOAM530MQW0WMHLjS6FZ6BBpCP6DUx+4EFKjaqDK3AuQt8SQosys5SG8 zIURrBmtqF4DL9UlIIinuntPPzbMXoTkAAV+1nG0jugKdnE= X-Google-Smtp-Source: ABdhPJwtmBkTp1ejGL5avnNsxUm7ZRD8SmufkBQikYcziK2FrO2SIyIv6K67dxjP//Lv593gLWZz+J2YNK/3LysbJWg= X-Received: by 2002:a7b:cd09:: with SMTP id f9mr3084538wmj.184.1595839709390; Mon, 27 Jul 2020 01:48:29 -0700 (PDT) MIME-Version: 1.0 References: <20200727081514.GD4206@calimero.vinschen.de> In-Reply-To: <20200727081514.GD4206@calimero.vinschen.de> From: Kito Cheng Date: Mon, 27 Jul 2020 16:48:18 +0800 Message-ID: Subject: Re: [PATCH] riscv: fix integer wraparound in memcpy To: Newlib , PkmX Cc: Corinna Vinschen Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 08:48:33 -0000 Hi Chih-Mao: Thanks for your patch :) Hi Corinna: Thanks! On Mon, Jul 27, 2020 at 4:22 PM Corinna Vinschen via Newlib wrote: > > Hi Chen, > > On Jul 24 19:07, PkmX via Newlib wrote: > > This patch fixes a bug in RISC-V's memcpy implementation where an > > integer wraparound occurs when src + size < 8 * sizeof(long), causing > > the word-sized copy loop to be incorrectly entered. > > > > Signed-off-by: Chih-Mao Chen > > --- > > newlib/libc/machine/riscv/memcpy.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/newlib/libc/machine/riscv/memcpy.c > > b/newlib/libc/machine/riscv/memcpy.c > > index 07e8e0076..4098f3ab1 100644 > > --- a/newlib/libc/machine/riscv/memcpy.c > > +++ b/newlib/libc/machine/riscv/memcpy.c > > @@ -51,9 +51,9 @@ small: > > const long *lb = (const long *)b; > > long *lend = (long *)((uintptr_t)end & ~msk); > > > > - if (unlikely (la < (lend - 8))) > > + if (unlikely (lend - la > 8)) > > { > > - while (la < (lend - 8)) > > + while (lend - la > 8) > > { > > long b0 = *lb++; > > long b1 = *lb++; > > -- > > 2.27.0 > > I pushed this, but I had to fix your patch because your MUA broke > the layout (line breaks, white spaces). > > Would you mind to check your MUA settings or send the patch as > attachment next time? > > > Thanks, > Corinna > > -- > Corinna Vinschen > Cygwin Maintainer > Red Hat >