From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com
 [IPv6:2a00:1450:4864:20::429])
 by sourceware.org (Postfix) with ESMTPS id D4800386F82C
 for <newlib@sourceware.org>; Thu, 25 Feb 2021 09:22:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D4800386F82C
Received: by mail-wr1-x429.google.com with SMTP id b3so4490546wrj.5
 for <newlib@sourceware.org>; Thu, 25 Feb 2021 01:22:07 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=VrRoIMqp87JsQHTA1NSlmmm2BZtp/ftHoFAeVFH9iXU=;
 b=bTcktZrxmfFnbah/9axvh42RgQnT3ZCuCGiqrIbrNPUoHlyv20H8kRjvwU1glGTrAe
 9ep7BXtitqSYIW7Z6zNXOGXs89jwQDxPIRaO2hPNw8S7/baUHkw7BL02aPc5vZVmMb4w
 vgaBUpi5qbSSN7HUl5dwRM03l3A+0zHQD1+gYDeTRKVv6atr59q0A8GVWMSCJj1s75Hw
 BkeN4/JZ/87Jjdl8vR4AIH6fqJVu6W+bBAOTRm+6hqu+ZDLszz18UDble+/S8M5IEEdf
 E8t+GNBx4mk/U/oh+dio+1Ac3/2vVhAIvOVuzfQXoAU4eV9jUlyFKfIoxpz4utGZ2R2O
 9YBw==
X-Gm-Message-State: AOAM5327DA62lxskgUd5jF1ysIfRl36YWdExucBilbhhPglc+v2sgkky
 r3ybbcTB1MR86nnU1dHu0w0c4q5rlu5ngjNqBQLzFldQKc8=
X-Google-Smtp-Source: ABdhPJzD/+jSDz16qWCgYfzwWduBoMgCbCXHItw38NdKVjpMfNo2esKu54xQ0qTnZBdh4vX8gi1Mfa9Ntt4IBLphx7A=
X-Received: by 2002:a05:6000:1545:: with SMTP id
 5mr2448316wry.90.1614244926850; 
 Thu, 25 Feb 2021 01:22:06 -0800 (PST)
MIME-Version: 1.0
References: <20210223213117.65475-1-marcus@mc.pp.se>
In-Reply-To: <20210223213117.65475-1-marcus@mc.pp.se>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Thu, 25 Feb 2021 17:21:55 +0800
Message-ID: <CA+yXCZAgQhYcY0TN9DRg_-A2rWDTFfXFBRGzPbwWZUavqRJ3rw@mail.gmail.com>
Subject: Re: [PATCH 0/2] Fixes for big endian RISC-V
To: Marcus Comstedt <marcus@mc.pp.se>
Cc: Newlib <newlib@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: newlib@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Newlib mailing list <newlib.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/newlib>,
 <mailto:newlib-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/newlib/>
List-Post: <mailto:newlib@sourceware.org>
List-Help: <mailto:newlib-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/newlib>,
 <mailto:newlib-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Feb 2021 09:22:10 -0000

This patch set is LGTM, verified with RV64 big-endian,
although RV32 big-endian still has some regression yet,
and not clear is library or compiler issue,
but I am fine to accept both patches and then accept further
patches later for RV32 if needed.


On Wed, Feb 24, 2021 at 6:07 AM Marcus Comstedt <marcus@mc.pp.se> wrote:
>
> Hi.
>
> These are two fixes needed for newlib to work correctly on big endian
> RISC-V, support for which is currently being added to gcc.
>
>
>   // Marcus
>
>
> --
>
>  newlib/libc/include/machine/ieeefp.h |  4 ++++
>  newlib/libc/machine/riscv/strcmp.S   | 40 ++++++++++++++++++++++++++++++++----
>  2 files changed, 40 insertions(+), 4 deletions(-)
>