From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 6FC02386F41C for ; Wed, 16 Dec 2020 08:43:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FC02386F41C Received: by mail-wm1-x32f.google.com with SMTP id g185so1583315wmf.3 for ; Wed, 16 Dec 2020 00:43:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f0BTtNWEpXhviPbLW2s1tWWnkfd1rNBpj3voR9SwklM=; b=oWDMLqlJ8bHXRKEQcYFPMLWZiJSIEuL+AHgBH0EMy5xSe20aCvft2qysKbP/Ha20am NM/uIP8TcmGZEda4TB+3r6pWAQacZ8mhwQ4hTlu3z+YjEbF5oQNyba+bACwUgUcY09+T X0bM4VrGAAyHHyiAamTAocecmPsONd6Tn9165KovvGdkITFAJ+wxwZI8mfK3Gx834lMe DLjfCQP6HVn0TYgffI8lOQpXSB7S4N6Ga2oVjN3BL8DA0oW9XNbqklfuVJgP96WLLh+V 9/sPCZLdK9egJeBiDbPoRtOXtSp2B9oHEJ2m8KEPgNtwU9xMvrTWHz3lpJ163WbC7w+S keWA== X-Gm-Message-State: AOAM533fsus1YfW+Mrt3LpKDFqoM5rW6HJLABaqpxTPsib/o5GCZD6Z5 IzslbFnxP5x7N8M58LymxA5S9UplVpLDCkCespQ= X-Google-Smtp-Source: ABdhPJzmQ9P+7Rw4U2fkS5KY2m5S6F78qgTLbaGfoqMZPfWS4mDjwx2s6cnfb/bxVIhuMHHTxXNiHVt/B9z/n7mi1LM= X-Received: by 2002:a1c:2d8a:: with SMTP id t132mr2200795wmt.128.1608108191369; Wed, 16 Dec 2020 00:43:11 -0800 (PST) MIME-Version: 1.0 References: <694d497b-bc07-a3ba-2643-a7336927e9a7@embecosm.com> <3ef25bfd-65d7-e8a2-cdd6-0b0532b5c4f6@embecosm.com> In-Reply-To: <3ef25bfd-65d7-e8a2-cdd6-0b0532b5c4f6@embecosm.com> From: Kito Cheng Date: Wed, 16 Dec 2020 16:43:00 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add semihosting support To: Craig Blackmore Cc: Jeff Johnston , Newlib Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 08:43:13 -0000 Hi Craig: The v2 patch is LGTM, verified with qemu again, thank you! > I can use SEMIHOST_exit_extended, but I will also need to add a check for the > SH_EXT_EXIT_EXTENDED feature. Can I follow up with this in a later patch? OK to me :)