public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: "Howland, Craig D. - US" <craig.howland@caci.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: riscv fenv.h header file guard typo
Date: Fri, 02 Aug 2019 03:39:00 -0000	[thread overview]
Message-ID: <CA+yXCZBhf3pK5M6Aquv9p3U3YLxNvomFjN-yF-dwAEbcWqYrMA@mail.gmail.com> (raw)
In-Reply-To: <1564614813047.69834@caci.com>

Hi Joel:

Thanks, I've send a patch for that :)

https://www.sourceware.org/ml/newlib/2019/msg00407.html

On Thu, Aug 1, 2019 at 7:13 AM Howland, Craig D. - US via newlib
<newlib@sourceware.org> wrote:
>
>
> ________________________________________
> From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Joel Sherrill <joel@rtems.org>
> Sent: Wednesday, July 31, 2019 6:47 PM
> To: Newlib
> Subject: riscv fenv.h header file guard typo
>
> Hi
>
> While working on the proposed fenv.h infrastructure support, I noticed that
> the riscv fenv.h and sys/fenv.h appear to have very similar header guards
> (only a trailing _ differentiates them).
>
> /libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
> ./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
>
> Would it be better for sys/fenv.h to have _SYS_FENV_H?
>
> --joel
>
> Yes, better.

      reply	other threads:[~2019-08-02  3:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 22:47 Joel Sherrill
2019-07-31 23:13 ` Howland, Craig D. - US via newlib
2019-08-02  3:39   ` Kito Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZBhf3pK5M6Aquv9p3U3YLxNvomFjN-yF-dwAEbcWqYrMA@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=craig.howland@caci.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).